| Message ID | 20240923012446.4965-1-linux@treblig.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | AMDGPU deadcode | expand |
On Sun, Sep 22, 2024 at 9:43 PM <linux@treblig.org> wrote: > > From: "Dr. David Alan Gilbert" <linux@treblig.org> > > Hi, > This is a bunch of deadcode removal in amdgpu; > some of the functions are ones which were previously > used but haven't been for a while, others are functions > that were added a few years ago and haven't ever been used. > > There are some others that I've not removed, which have > been added in the last few years but not been used, > I was worried maybe there are patches in someones tree > about to use them (e.g. amdgpu_lsdma_copy_mem, amdgpu_mes_reg_wait, > amdgpu_ras_unbind_aca, amdgpu_seq64_alloc, and > amdgpu_xcp_prepare_resume) - I'd be happy to take those as > well. There are patches in flight that make use of at least some of these. For example, the seq64 functions are used by the user queues patches which are being reviewed now. Feel free to send out patches though if you are inclined. If someone has plans to use something, they can bring that up in the patch review. > > One other thing I wasn't sure of; I removed > amdgpu_device_ip_is_idle > which has been unused since about 2016, but does that make > the 'is_idle' methods unused or is there something else that calls > them? They've been used on and off in proposed patches over the years. Some of the IP specific code may call the IP specific is idle functions directly rather than using the callbacks. Alex > > (Sent from this kernel booted on my RX550 GPU) > > Dave > > Dr. David Alan Gilbert (5): > drm/amdgpu: Remove unused amdgpu_device_ip_is_idle > drm/amdgpu: Remove unused amdgpu_atpx functions > drm/amdgpu: Remove unused amdgpu_gmc_vram_cpu_pa > drm/amdgpu: Remove unused amdgpu_gfx_bit_to_me_queue > drm/amdgpu: Remove unused amdgpu_i2c functions > > drivers/gpu/drm/amd/amdgpu/amdgpu.h | 10 -------- > .../gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c | 12 --------- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 24 ------------------ > drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 10 -------- > drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 2 -- > drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 12 --------- > drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.h | 1 - > drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c | 25 ------------------- > drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.h | 4 --- > 9 files changed, 100 deletions(-) > > -- > 2.46.1 >
* Alex Deucher (alexdeucher@gmail.com) wrote: > On Sun, Sep 22, 2024 at 9:43 PM <linux@treblig.org> wrote: > > > > From: "Dr. David Alan Gilbert" <linux@treblig.org> > > > > Hi, > > This is a bunch of deadcode removal in amdgpu; > > some of the functions are ones which were previously > > used but haven't been for a while, others are functions > > that were added a few years ago and haven't ever been used. > > > > There are some others that I've not removed, which have > > been added in the last few years but not been used, > > I was worried maybe there are patches in someones tree > > about to use them (e.g. amdgpu_lsdma_copy_mem, amdgpu_mes_reg_wait, > > amdgpu_ras_unbind_aca, amdgpu_seq64_alloc, and > > amdgpu_xcp_prepare_resume) - I'd be happy to take those as > > well. Hi Alex, Thanks for taking the series, and the reply. > There are patches in flight that make use of at least some of these. > For example, the seq64 functions are used by the user queues patches > which are being reviewed now. Feel free to send out patches though if > you are inclined. If someone has plans to use something, they can > bring that up in the patch review. OK, I've made myself a note and will swing back at some point. > > One other thing I wasn't sure of; I removed > > amdgpu_device_ip_is_idle > > which has been unused since about 2016, but does that make > > the 'is_idle' methods unused or is there something else that calls > > them? > > They've been used on and off in proposed patches over the years. Some > of the IP specific code may call the IP specific is idle functions > directly rather than using the callbacks. Do you think the 'is_idle' member itself should go? Dave > Alex > > > > > (Sent from this kernel booted on my RX550 GPU) > > > > Dave > > > > Dr. David Alan Gilbert (5): > > drm/amdgpu: Remove unused amdgpu_device_ip_is_idle > > drm/amdgpu: Remove unused amdgpu_atpx functions > > drm/amdgpu: Remove unused amdgpu_gmc_vram_cpu_pa > > drm/amdgpu: Remove unused amdgpu_gfx_bit_to_me_queue > > drm/amdgpu: Remove unused amdgpu_i2c functions > > > > drivers/gpu/drm/amd/amdgpu/amdgpu.h | 10 -------- > > .../gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c | 12 --------- > > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 24 ------------------ > > drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 10 -------- > > drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 2 -- > > drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 12 --------- > > drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.h | 1 - > > drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c | 25 ------------------- > > drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.h | 4 --- > > 9 files changed, 100 deletions(-) > > > > -- > > 2.46.1 > >
From: "Dr. David Alan Gilbert" <linux@treblig.org> Hi, This is a bunch of deadcode removal in amdgpu; some of the functions are ones which were previously used but haven't been for a while, others are functions that were added a few years ago and haven't ever been used. There are some others that I've not removed, which have been added in the last few years but not been used, I was worried maybe there are patches in someones tree about to use them (e.g. amdgpu_lsdma_copy_mem, amdgpu_mes_reg_wait, amdgpu_ras_unbind_aca, amdgpu_seq64_alloc, and amdgpu_xcp_prepare_resume) - I'd be happy to take those as well. One other thing I wasn't sure of; I removed amdgpu_device_ip_is_idle which has been unused since about 2016, but does that make the 'is_idle' methods unused or is there something else that calls them? (Sent from this kernel booted on my RX550 GPU) Dave Dr. David Alan Gilbert (5): drm/amdgpu: Remove unused amdgpu_device_ip_is_idle drm/amdgpu: Remove unused amdgpu_atpx functions drm/amdgpu: Remove unused amdgpu_gmc_vram_cpu_pa drm/amdgpu: Remove unused amdgpu_gfx_bit_to_me_queue drm/amdgpu: Remove unused amdgpu_i2c functions drivers/gpu/drm/amd/amdgpu/amdgpu.h | 10 -------- .../gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c | 12 --------- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 24 ------------------ drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 10 -------- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 2 -- drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 12 --------- drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.h | 1 - drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c | 25 ------------------- drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.h | 4 --- 9 files changed, 100 deletions(-)