mbox series

[v4,0/6] DRM_SET_CLIENT_NAME ioctl

Message ID 20240927084848.263718-1-pierre-eric.pelloux-prayer@amd.com (mailing list archive)
Headers show
Series DRM_SET_CLIENT_NAME ioctl | expand

Message

Pierre-Eric Pelloux-Prayer Sept. 27, 2024, 8:48 a.m. UTC
v4 changelog:
* DRM_SET_NAME -> DRM_SET_CLIENT_NAME (Dmitry)
* reject names that would mess up with formatting (Sima),
  and use a stricter filter (isgraph allowed extended ASCII
  which weren't looking great)
* documentation edits, minor fixups (Dmitry, Trvtko)
* clarified commit message of commit 3/6 (Trvtko)
* reworked amdgpu_vm_set_task_info a bit in 4/6 (Trvtko)

v3: https://lists.freedesktop.org/archives/dri-devel/2024-September/470488.html

Pierre-Eric Pelloux-Prayer (6):
  drm: add DRM_SET_CLIENT_NAME ioctl
  drm: use drm_file client_name in fdinfo
  drm/amdgpu: delay the use of amdgpu_vm_set_task_info
  drm/amdgpu: alloc and init vm::task_info from first submit
  drm/amdgpu: make process_name a flexible array
  drm/amdgpu: use drm_file::name in task_info::process_desc

 Documentation/gpu/drm-usage-stats.rst         |  5 ++
 drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h    |  1 +
 .../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c  |  3 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c        |  6 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c   |  2 +-
 .../gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c  |  4 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_job.c       |  2 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c        | 62 +++++++++++++------
 drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h        |  4 +-
 drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c        |  2 +-
 drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c        |  2 +-
 drivers/gpu/drm/amd/amdgpu/gmc_v12_0.c        |  2 +-
 drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c         |  2 +-
 drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c         |  2 +-
 drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c        |  2 +-
 drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c      |  2 +-
 drivers/gpu/drm/amd/amdkfd/kfd_events.c       |  2 +-
 drivers/gpu/drm/amd/amdkfd/kfd_process.c      |  3 +
 drivers/gpu/drm/drm_debugfs.c                 | 14 +++--
 drivers/gpu/drm/drm_file.c                    | 10 +++
 drivers/gpu/drm/drm_ioctl.c                   | 55 ++++++++++++++++
 include/drm/drm_file.h                        |  9 +++
 include/uapi/drm/drm.h                        | 17 +++++
 23 files changed, 171 insertions(+), 42 deletions(-)

Comments

Christian König Sept. 27, 2024, 9:07 a.m. UTC | #1
Am 27.09.24 um 10:48 schrieb Pierre-Eric Pelloux-Prayer:
> v4 changelog:
> * DRM_SET_NAME -> DRM_SET_CLIENT_NAME (Dmitry)
> * reject names that would mess up with formatting (Sima),
>    and use a stricter filter (isgraph allowed extended ASCII
>    which weren't looking great)
> * documentation edits, minor fixups (Dmitry, Trvtko)
> * clarified commit message of commit 3/6 (Trvtko)
> * reworked amdgpu_vm_set_task_info a bit in 4/6 (Trvtko)

If nobody has any more additional comments on this I'm going to pick it 
up and merge it through drm-misc-next by the end of today.

Regards,
Christian

>
> v3: https://lists.freedesktop.org/archives/dri-devel/2024-September/470488.html
>
> Pierre-Eric Pelloux-Prayer (6):
>    drm: add DRM_SET_CLIENT_NAME ioctl
>    drm: use drm_file client_name in fdinfo
>    drm/amdgpu: delay the use of amdgpu_vm_set_task_info
>    drm/amdgpu: alloc and init vm::task_info from first submit
>    drm/amdgpu: make process_name a flexible array
>    drm/amdgpu: use drm_file::name in task_info::process_desc
>
>   Documentation/gpu/drm-usage-stats.rst         |  5 ++
>   drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h    |  1 +
>   .../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c  |  3 +-
>   drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c        |  6 +-
>   drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c   |  2 +-
>   .../gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c  |  4 +-
>   drivers/gpu/drm/amd/amdgpu/amdgpu_job.c       |  2 +-
>   drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c        | 62 +++++++++++++------
>   drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h        |  4 +-
>   drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c        |  2 +-
>   drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c        |  2 +-
>   drivers/gpu/drm/amd/amdgpu/gmc_v12_0.c        |  2 +-
>   drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c         |  2 +-
>   drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c         |  2 +-
>   drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c        |  2 +-
>   drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c      |  2 +-
>   drivers/gpu/drm/amd/amdkfd/kfd_events.c       |  2 +-
>   drivers/gpu/drm/amd/amdkfd/kfd_process.c      |  3 +
>   drivers/gpu/drm/drm_debugfs.c                 | 14 +++--
>   drivers/gpu/drm/drm_file.c                    | 10 +++
>   drivers/gpu/drm/drm_ioctl.c                   | 55 ++++++++++++++++
>   include/drm/drm_file.h                        |  9 +++
>   include/uapi/drm/drm.h                        | 17 +++++
>   23 files changed, 171 insertions(+), 42 deletions(-)
>
Jani Nikula Sept. 27, 2024, 9:16 a.m. UTC | #2
On Fri, 27 Sep 2024, Christian König <christian.koenig@amd.com> wrote:
> Am 27.09.24 um 10:48 schrieb Pierre-Eric Pelloux-Prayer:
>> v4 changelog:
>> * DRM_SET_NAME -> DRM_SET_CLIENT_NAME (Dmitry)
>> * reject names that would mess up with formatting (Sima),
>>    and use a stricter filter (isgraph allowed extended ASCII
>>    which weren't looking great)
>> * documentation edits, minor fixups (Dmitry, Trvtko)
>> * clarified commit message of commit 3/6 (Trvtko)
>> * reworked amdgpu_vm_set_task_info a bit in 4/6 (Trvtko)
>
> If nobody has any more additional comments on this I'm going to pick it 
> up and merge it through drm-misc-next by the end of today.

AFAICT the userspace is not reviewed and ready for merging [1].

BR,
Jani.


[1] https://gitlab.freedesktop.org/virgl/virglrenderer/-/merge_requests/1428
Dmitry Osipenko Sept. 28, 2024, 12:34 p.m. UTC | #3
On 9/27/24 12:16, Jani Nikula wrote:
> On Fri, 27 Sep 2024, Christian König <christian.koenig@amd.com> wrote:
>> Am 27.09.24 um 10:48 schrieb Pierre-Eric Pelloux-Prayer:
>>> v4 changelog:
>>> * DRM_SET_NAME -> DRM_SET_CLIENT_NAME (Dmitry)
>>> * reject names that would mess up with formatting (Sima),
>>>    and use a stricter filter (isgraph allowed extended ASCII
>>>    which weren't looking great)
>>> * documentation edits, minor fixups (Dmitry, Trvtko)
>>> * clarified commit message of commit 3/6 (Trvtko)
>>> * reworked amdgpu_vm_set_task_info a bit in 4/6 (Trvtko)
>>
>> If nobody has any more additional comments on this I'm going to pick it 
>> up and merge it through drm-misc-next by the end of today.
> 
> AFAICT the userspace is not reviewed and ready for merging [1].
> 
> BR,
> Jani.
> 
> 
> [1] https://gitlab.freedesktop.org/virgl/virglrenderer/-/merge_requests/1428

Userspace has been discussed in the past. I'll merge virglrenderer MR
once Pierre will update it based on this v4 and after the kernel patch
will land to misc-next.