[v3,0/3] drm/panthor: Fix group state reporting

Message

Boris Brezillon Oct. 29, 2024, 3:29 p.m. UTC

Hello,

What initially started as a simple fix to avoid queueing jobs to a group
that can't be scheduled has turned into a series of three patches
improving the group state reporting. Two of them are actual fixes, the
last one is an improvement to properly report innocence/guiltiness of
a group when a group becomes unusable. With this new
GROUP_STATE_INNOCENT, we can distinguish between
GL_INNOCENT_CONTEXT_RESET and GL_GUILT_CONTEXT_RESET (see this mesa
MR for more details [1]).

Regards,

Boris

[1]https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31868

Boris Brezillon (3):
  drm/panthor: Fail job creation when the group is dead
  drm/panthor: Report group as timedout when we fail to properly suspend
  drm/panthor: Report innocent group kill

 drivers/gpu/drm/panthor/panthor_drv.c   |  2 +-
 drivers/gpu/drm/panthor/panthor_sched.c | 38 ++++++++++++++++++++++---
 include/uapi/drm/panthor_drm.h          |  9 ++++++
 3 files changed, 44 insertions(+), 5 deletions(-)

Comments

Boris Brezillon Oct. 30, 2024, 3:41 p.m. UTC | #1

On Tue, 29 Oct 2024 16:29:09 +0100
Boris Brezillon <[e-mail]> wrote:

> Hello,
> 
> What initially started as a simple fix to avoid queueing jobs to a group
> that can't be scheduled has turned into a series of three patches
> improving the group state reporting. Two of them are actual fixes, the
> last one is an improvement to properly report innocence/guiltiness of
> a group when a group becomes unusable. With this new
> GROUP_STATE_INNOCENT, we can distinguish between
> GL_INNOCENT_CONTEXT_RESET and GL_GUILT_CONTEXT_RESET (see this mesa
> MR for more details [1]).
> 
> Regards,
> 
> Boris
> 
> [1]https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31868
> 
> Boris Brezillon (3):
>   drm/panthor: Fail job creation when the group is dead
>   drm/panthor: Report group as timedout when we fail to properly suspend

First two patches are queued to drm-misc-fixes.

>   drm/panthor: Report innocent group kill

I'll send a v4 of the third one and wait for a backmerge of Linus' tree
in drm-misc-next before applying.

> 
>  drivers/gpu/drm/panthor/panthor_drv.c   |  2 +-
>  drivers/gpu/drm/panthor/panthor_sched.c | 38 ++++++++++++++++++++++---
>  include/uapi/drm/panthor_drm.h          |  9 ++++++
>  3 files changed, 44 insertions(+), 5 deletions(-)
>