From patchwork Fri Dec 20 18:11:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dave Stevenson X-Patchwork-Id: 13917235 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5890DE77188 for ; Fri, 20 Dec 2024 18:11:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DDCC410E09D; Fri, 20 Dec 2024 18:11:24 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="haNWy/Ib"; dkim-atps=neutral Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by gabe.freedesktop.org (Postfix) with ESMTPS id A155D10E09D for ; Fri, 20 Dec 2024 18:11:23 +0000 (UTC) Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-385e3621518so1214578f8f.1 for ; Fri, 20 Dec 2024 10:11:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1734718282; x=1735323082; darn=lists.freedesktop.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=K6BQVShD3NoC5b7ILwEQ6K46fu5E4ShUBfYTzpiyij8=; b=haNWy/Ib8ewlVSg2kKDS4U2btklDUIyx7Ac31bFWDhi5YOiHIUIT9WPfb437KwP6tC 4ybA3DaaAwVycwYC0Lcc3oesweR1u5kVDsQUUvTASSKzUnhCfBc0iPyZ2mIVtGbPNr9G zOX939CUxmbjTba7SxyJHo/W5zENJNmIHFiVnxhg2vq6DhT3up3Siaw6J0jXLqygALyi XWgu/d7NOdveaXCikk/lmDvAsbIb9sQIqcZSC7jLcXrxPWEDpKEQAzTrDim5WeJsp3PM fh/smMbraRolZ2POiVprdNgs5uSpMn5X1OnB7+nqksW6SlDbxd4j6Lv7PNazN/B5i0PM 7Mlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734718282; x=1735323082; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=K6BQVShD3NoC5b7ILwEQ6K46fu5E4ShUBfYTzpiyij8=; b=U/+snOe6UuNfjx0fkJKahHvdPJ8Ae8j75SMvlW1L+CjPgbeT7L4BLeRqbhlBNGPTNt SPZbTzgr8Rm/2x1mB21+xsWIH2hTKLwTo/sOlRohjfevBxeyFBpH1F9XxoUXrfxzv4zr Ka+OxRCWWmcSJxMd0cKWWIbPH095+n/i4HrM/iVV60mPa5cTShAa8orgUbH13ebwr9MZ KIBJBkSxVpmuLbDtvEPIQjBguU7vYNEj6Xi/j68x4GeKgBWJQ3gNZglvnJO/v89UdXbv pDw34KiB51bUlDXColXYhBGFkqFQA7WZ8d0o7xfSekDzdlYSLjbeUX8Q7vct2aJT2tq4 HaDQ== X-Gm-Message-State: AOJu0YwZK4DCiFBvN5/upyt36DwKslpKs8THr3Us0J4/Av5tycs0X3Wx aKVmiDh53XN7Y5CgZTTNgTUS2SyFbim4ovwqo0qgK9wEJRx2HuieoUE8peaV2c4= X-Gm-Gg: ASbGncvRvcRFQs1bH9L6KITqIB1pk4V59dadfW9kg/nHlI/lbKE0YYBNl2w6gn96mfO j/cpFoSeJsvFlQA0/LEb6r5q3byJg+Z+taHtlVeKIyykulkNEebzilyedQ07Xds5T9K8bmTUZKK YM/bmQGHcLGtW3ofdmp66vla+JNAFO3KCfNZbOs39ZJ4itWSGIEFm6WUUk7LxOWX5gOkB59w/zj p4GnDFH4ZyyxzAzssf2uBgytsBd+NhmRj2g9GdwjWfT+fBj X-Google-Smtp-Source: AGHT+IGbM/Tx3G6ve1QyNsrVLV/jOarA/uAXeuaovxRW6LqTq8ldWR2fwVR13hiCBtPxlntlYTq/qw== X-Received: by 2002:a05:6000:4023:b0:385:f220:f788 with SMTP id ffacd0b85a97d-38a223fd77bmr3911254f8f.48.1734718282035; Fri, 20 Dec 2024 10:11:22 -0800 (PST) Received: from [127.0.1.1] ([2a00:1098:3142:e::8]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-4366127c488sm51460075e9.27.2024.12.20.10.11.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Dec 2024 10:11:20 -0800 (PST) From: Dave Stevenson Subject: [PATCH v5 0/3] drm/vc4: Fixup DT and DT binding issues from recent patchset Date: Fri, 20 Dec 2024 18:11:10 +0000 Message-Id: <20241220-dt-bcm2712-fixes-v5-0-cbbf13d2e97a@raspberrypi.com> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAD+zZWcC/4XQQavCMAwH8K8iPVtp02zrPL3vIR66LNUedKOV8 kT23V/0XQQHXgL/hPwCeajCOXFR+81DZa6ppOkqodluFJ3D9cQ6jZIVGEBrwevxpge6QGdBx/T LRYc4GPbBBOxaJWtz5tdAtg5HyedUblO+vy5U++z+Y1I+sWq10TFQ2xFB7H34yaHMA+d8n9OOp ot6khXeGLvGgDCu6X3LBkcTcZ1x3xgnDGLoonO9cc6uM/jOrHyoojANEnk/tATQfzLLsvwBjLr YbosBAAA= To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Eric Anholt , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance , Ray Jui , Scott Branden , Doug Berger , Linus Walleij , Bartosz Golaszewski , Thomas Gleixner , Stefan Wahren Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Florian Fainelli , linux-gpio@vger.kernel.org, Dave Stevenson , Krzysztof Kozlowski X-Mailer: b4 0.14.1 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" I missed the DT errors from the recent patchset[1] (DT patches in linux-next via Florian, DRM bindings patches on dri-misc-next) as Rob's bot report got spam filtered, so this is a fixup set. Largely it was changes to number of interrupts or clocks in the bindings, so those are now covered. I've fixed up the missing "interrupt-controller" flags for 2711 and 2712 whilst here. I can't get my head around what is meant to happen with ranges: "soc@107c000000: firmware: 'ranges' is a required property" The meaning seems obvious. However if I add it then I get: "firmware: '#address-cells', '#size-cells', 'dma-ranges', 'ranges' do not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/arm/bcm/raspberrypi,bcm2835-firmware.yaml# There's obviously some other flag I need to set in the bindings, but I can't work it out. We have similar errors for all the Pi platforms for one or more nodes. Please advise and I'll happily fix them all. Thanks Dave [1] https://lore.kernel.org/linux-arm-kernel/20241025-drm-vc4-2712-support-v2-0-35efa83c8fc0@raspberrypi.com/ Signed-off-by: Dave Stevenson --- Changes in v5: - Removed all changes to HDMI bindings for earlier hardware revisions. - Updated commit text to make it explicit that clock and interrupt names are required by the driver for 2712. - Added clock-names and interrupt-names: false for 2711 and 2835 (the existing variants). - Updated commit text to state clock and interrupt names are required by the driver for 2712. - Link to v4: https://lore.kernel.org/r/20241218-dt-bcm2712-fixes-v4-0-54cc88b6c229@raspberrypi.com Changes in v4: - 1/7 Removed the duplication - 2/7 Added "minItems: 2" and added to the commit text that the clock and interrupt names are required for bcm2712 - 3/7 Already applied by Bartosz, and 5-7/7 applied by Florian - 4/7 added Krzysztof Acked-by - Link to v3: https://lore.kernel.org/r/20241212-dt-bcm2712-fixes-v3-0-44a7f3390331@raspberrypi.com Thanks Krzysztof for your comments. Terms such as "widest constraints" may be obvious to those regularly doing dtschemas, but not to me who does them once in a blue-moon. Changes in v3: - Fixed up indentation on 1/7. (I fixed it once, but obviously reworked things and lost it). - Link to v2: https://lore.kernel.org/r/20241212-dt-bcm2712-fixes-v2-0-35986e04d0f4@raspberrypi.com Thanks to Stefan and Krzysztof for their reviews. Hopefully I've addressed all points raised in the correct manner. Changes in v2: - Commits have now be merged from drm-misc-next to linux-next, so all commit hashes are valid on linux-next. - 1/7 Removed references to "previous commit". Fixed up indentation. Added maxItems - 2/7 Defined widest constraints - 3/7 Added maxItems and removed reference to Linux - 4/7 Described the errors. Split into two for fix of node name vs addr being wrong. - Added new patch removing "required" for interrupt-controller and interrupt-cells for bcm2836-l1-intc - 5/7 (now 7/7) Removed the intc node for 2712 - it's irrelevant on 64bit systems - 6/7 dropped as updating the binding is the correct answer - 7/7 dropped. simple-bus claims ranges is required, but adding it creates other errors. I'm unclear as to the right solution. - Link to v1: https://lore.kernel.org/r/20241202-dt-bcm2712-fixes-v1-0-fac67cc2f98a@raspberrypi.com --- Dave Stevenson (3): dt-bindings: display: bcm2711-hdmi: Add interrupt details for BCM2712 dt-bindings: display: Fix brcm,bcm2835-hvs bindings for BCM2712 dt-bindings: interrupt-controller: brcm,bcm2836-l1-intc: Drop interrupt-controller requirement .../bindings/display/brcm,bcm2711-hdmi.yaml | 76 +++++++++++++++---- .../bindings/display/brcm,bcm2835-hvs.yaml | 88 ++++++++++++++++++---- .../interrupt-controller/brcm,bcm2836-l1-intc.yaml | 2 - 3 files changed, 136 insertions(+), 30 deletions(-) --- base-commit: 29978a81e62128d2cee56f066ec92de584f4ab5f change-id: 20241128-dt-bcm2712-fixes-afb0e8a0a476 Best regards,