From patchwork Tue Feb 4 14:57:28 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Ripard X-Patchwork-Id: 13959316 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8502FC02194 for ; Tue, 4 Feb 2025 14:58:15 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F065210E11A; Tue, 4 Feb 2025 14:58:14 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="oG4cusLh"; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id 48D1E89701 for ; Tue, 4 Feb 2025 14:58:07 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 7BA515C6A26; Tue, 4 Feb 2025 14:57:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 62ADAC4CEDF; Tue, 4 Feb 2025 14:58:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1738681086; bh=l7sGNTCxwBCWkOY0Y/B2TGXHIezeQ5vKU7frQJLBHto=; h=From:Subject:Date:To:Cc:From; b=oG4cusLhCjDAZJbtEhSHPhwMbrK1mcut5VfuIpwmZH36PtEQIZrexEwsckzJaMjmO ydRoH+vaiIe+lZ39xjah3Mq3Ni62yVT8qSwVI10ANQtgpxCPKH5eRb6iqU5LwSsxfq 2YmdT5gXVxY/ASFScre5KLKIZp8KI+c6als2k3cNtUgQT4e4DQEOXV6MWY8CWxQ7LL 3Ko9Y58Vnk1fIxk4kONgoBKVLN/uUCwZQH4btgm4bhJ8C5Uz6iHNCTJ8VG2E0Ymf/D SZxNtSWWTsJ15y8dXw+91mz7UmOMjps7y2FQKKJd8ZxdwQhT4gBIN+aginxv3Rd5D7 XLF6uzHnJsd1g== From: Maxime Ripard Subject: [PATCH v2 00/35] drm/bridge: Various quality of life improvements Date: Tue, 04 Feb 2025 15:57:28 +0100 Message-Id: <20250204-bridge-connector-v2-0-35dd6c834e08@kernel.org> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIANkqomcC/32NTQ7CIBBGr9LMWgygxdaV9zBdIAztRANmMETTc HexB3D5Xr6fFTIyYYZztwJjoUwpNtC7Dtxi44yCfGPQUvdSqV7cmHyzLsWI7pVYhPGgxiNqcwo BWu3JGOi9TV6nxgvlFvtsD0X97J+xooQUo9UBnR8GY83ljhzxsU88w1Rr/QJggiGKsQAAAA== X-Change-ID: 20250115-bridge-connector-f93194e267ff To: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Douglas Anderson Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard , Simona Vetter X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=9295; i=mripard@kernel.org; h=from:subject:message-id; bh=l7sGNTCxwBCWkOY0Y/B2TGXHIezeQ5vKU7frQJLBHto=; b=owGbwMvMwCmsHn9OcpHtvjLG02pJDOmLtF7kOM9hT0+4aP5tc6Xl5JZI81Wl57535P9RDtz59 aDWqdVmHVNZGIQ5GWTFFFmeyISdXt6+uMrBfuUPmDmsTCBDGLg4BWAiM54w1tk05m086JX7a+Pl U6//Pvkn9lAnzkS56OZcDY7Dce4TbTeyPVdXD2+QV649uXe6r+WGHsaGQ1OMhJ6X25TJqchK96/ er+L3h9vkxd/rjnc2McdO6T3Ly6AvVcS+oDrqS1t+ZWOouDMA X-Developer-Key: i=mripard@kernel.org; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, Here's a series of changes after to the KMS helpers and bridge API following a bunch of reviews I did. It's mostly centered across providing an easier time to deal with bridge states, and a somewhat consistent with the other entities API. It's build tested only, with arm64 allmodconfig. Maxime Signed-off-by: Maxime Ripard --- Changes in v2: - Pass the full atomic state to bridge atomic hooks - Make attach take the encoder as a parameter - Mark bridge->encoder as deprecated - Rework the logic to detect if a bridge uses a state or not at atomic_check time - Add lockdep assertion to drm_bridge_get_current_state() - Link to v1: https://lore.kernel.org/r/20250115-bridge-connector-v1-0-9a2fecd886a6@kernel.org --- Maxime Ripard (35): drm/atomic: Document history of drm_atomic_state drm/bridge: Pass full state to atomic_pre_enable drm/bridge: Pass full state to atomic_enable drm/bridge: Pass full state to atomic_disable drm/bridge: Pass full state to atomic_post_disable drm/atomic-helper: Fix commit_tail state variable name drm/atomic-helper: Change parameter name of drm_atomic_helper_wait_for_dependencies() drm/atomic-helper: Change parameter name of drm_atomic_helper_commit_tail() drm/atomic-helper: Change parameter name of drm_atomic_helper_commit_tail_rpm() drm/atomic-helper: Change parameter name of drm_atomic_helper_modeset_disables() drm/atomic-helper: Change parameter name of disable_outputs() drm/bridge: Change parameter name of drm_atomic_bridge_chain_disable() drm/bridge: Change parameter name of drm_atomic_bridge_chain_post_disable() drm/atomic-helper: Change parameter name of drm_atomic_helper_update_legacy_modeset_state() drm/atomic-helper: Change parameter name of crtc_set_mode() drm/atomic-helper: Change parameter name of drm_atomic_helper_commit_planes() drm/atomic-helper: Change parameter name of drm_atomic_helper_commit_modeset_enables() drm/bridge: Change parameter name of drm_atomic_bridge_chain_pre_enable() drm/bridge: Change parameter name of drm_atomic_bridge_chain_enable() drm/atomic-helper: Change parameter name of drm_atomic_helper_commit_writebacks() drm/atomic-helper: Change parameter name of drm_atomic_helper_fake_vblank() drm/atomic-helper: Change parameter name of drm_atomic_helper_commit_hw_done() drm/atomic-helper: Change parameter name of drm_atomic_helper_wait_for_vblanks() drm/atomic-helper: Change parameter name of drm_atomic_helper_cleanup_planes() drm/atomic-helper: Change parameter name of drm_atomic_helper_commit_cleanup_done() drm/atomic-helper: Change parameter name of drm_atomic_helper_wait_for_flip_done() drm/bridge: Add encoder parameter to drm_bridge_funcs.attach drm/bridge: Provide a helper to retrieve current bridge state drm/bridge: Assume that a bridge is atomic if it has atomic_reset drm/bridge: Provide pointers to the connector and crtc in bridge state drm/bridge: Make encoder pointer deprecated drm/bridge: cdns-csi: Switch to atomic helpers drm/bridge: tc358775: Switch to atomic commit drm/bridge: tc358768: Convert to atomic helpers drm/bridge: ti-sn65dsi86: Use bridge_state crtc pointer drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 3 +- drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 3 +- drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c | 3 +- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 26 +-- drivers/gpu/drm/bridge/analogix/anx7625.c | 11 +- drivers/gpu/drm/bridge/aux-bridge.c | 3 +- drivers/gpu/drm/bridge/aux-hpd-bridge.c | 1 + drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c | 30 ++- .../gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 6 +- drivers/gpu/drm/bridge/chipone-icn6211.c | 13 +- drivers/gpu/drm/bridge/chrontel-ch7033.c | 5 +- drivers/gpu/drm/bridge/display-connector.c | 1 + drivers/gpu/drm/bridge/fsl-ldb.c | 8 +- drivers/gpu/drm/bridge/imx/imx-ldb-helper.c | 7 +- drivers/gpu/drm/bridge/imx/imx-ldb-helper.h | 2 +- drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c | 3 +- drivers/gpu/drm/bridge/imx/imx8mp-hdmi-pvi.c | 10 +- drivers/gpu/drm/bridge/imx/imx8qm-ldb.c | 10 +- drivers/gpu/drm/bridge/imx/imx8qxp-ldb.c | 21 +- .../gpu/drm/bridge/imx/imx8qxp-pixel-combiner.c | 8 +- drivers/gpu/drm/bridge/imx/imx8qxp-pixel-link.c | 13 +- drivers/gpu/drm/bridge/imx/imx8qxp-pxl2dpi.c | 11 +- drivers/gpu/drm/bridge/ite-it6263.c | 18 +- drivers/gpu/drm/bridge/ite-it6505.c | 10 +- drivers/gpu/drm/bridge/ite-it66121.c | 8 +- drivers/gpu/drm/bridge/lontium-lt8912b.c | 3 +- drivers/gpu/drm/bridge/lontium-lt9211.c | 8 +- drivers/gpu/drm/bridge/lontium-lt9611.c | 21 +- drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 3 +- drivers/gpu/drm/bridge/lvds-codec.c | 3 +- .../drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c | 1 + drivers/gpu/drm/bridge/microchip-lvds.c | 3 +- drivers/gpu/drm/bridge/nwl-dsi.c | 13 +- drivers/gpu/drm/bridge/nxp-ptn3460.c | 5 +- drivers/gpu/drm/bridge/panel.c | 15 +- drivers/gpu/drm/bridge/parade-ps8622.c | 1 + drivers/gpu/drm/bridge/parade-ps8640.c | 7 +- drivers/gpu/drm/bridge/samsung-dsim.c | 11 +- drivers/gpu/drm/bridge/sii902x.c | 9 +- drivers/gpu/drm/bridge/sil-sii8620.c | 1 + drivers/gpu/drm/bridge/simple-bridge.c | 5 +- drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c | 5 +- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 8 +- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 11 +- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi2.c | 11 +- drivers/gpu/drm/bridge/tc358762.c | 12 +- drivers/gpu/drm/bridge/tc358764.c | 3 +- drivers/gpu/drm/bridge/tc358767.c | 22 +- drivers/gpu/drm/bridge/tc358768.c | 33 ++- drivers/gpu/drm/bridge/tc358775.c | 39 ++-- drivers/gpu/drm/bridge/thc63lvd1024.c | 3 +- drivers/gpu/drm/bridge/ti-dlpc3433.c | 10 +- drivers/gpu/drm/bridge/ti-sn65dsi83.c | 10 +- drivers/gpu/drm/bridge/ti-sn65dsi86.c | 63 ++++-- drivers/gpu/drm/bridge/ti-tdp158.c | 12 +- drivers/gpu/drm/bridge/ti-tfp410.c | 5 +- drivers/gpu/drm/bridge/ti-tpd12s015.c | 3 +- drivers/gpu/drm/drm_atomic_helper.c | 242 ++++++++++----------- drivers/gpu/drm/drm_atomic_state_helper.c | 5 + drivers/gpu/drm/drm_bridge.c | 98 +++------ drivers/gpu/drm/i2c/tda998x_drv.c | 1 + drivers/gpu/drm/imx/ipuv3/parallel-display.c | 3 +- drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 9 +- drivers/gpu/drm/mcde/mcde_dsi.c | 3 +- drivers/gpu/drm/mediatek/mtk_dp.c | 9 +- drivers/gpu/drm/mediatek/mtk_dpi.c | 3 +- drivers/gpu/drm/mediatek/mtk_dsi.c | 11 +- drivers/gpu/drm/mediatek/mtk_hdmi.c | 12 +- drivers/gpu/drm/meson/meson_encoder_cvbs.c | 8 +- drivers/gpu/drm/meson/meson_encoder_dsi.c | 8 +- drivers/gpu/drm/meson/meson_encoder_hdmi.c | 8 +- drivers/gpu/drm/msm/dp/dp_display.c | 28 +-- drivers/gpu/drm/msm/dp/dp_drm.c | 19 +- drivers/gpu/drm/msm/dp/dp_drm.h | 6 +- drivers/gpu/drm/msm/dsi/dsi_manager.c | 3 +- drivers/gpu/drm/omapdrm/dss/dpi.c | 3 +- drivers/gpu/drm/omapdrm/dss/dsi.c | 3 +- drivers/gpu/drm/omapdrm/dss/hdmi4.c | 8 +- drivers/gpu/drm/omapdrm/dss/hdmi5.c | 8 +- drivers/gpu/drm/omapdrm/dss/sdi.c | 3 +- drivers/gpu/drm/omapdrm/dss/venc.c | 3 +- drivers/gpu/drm/renesas/rcar-du/rcar_lvds.c | 8 +- drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi.c | 7 +- drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c | 8 +- drivers/gpu/drm/stm/lvds.c | 16 +- drivers/gpu/drm/tidss/tidss_encoder.c | 3 +- drivers/gpu/drm/vc4/vc4_dsi.c | 12 +- drivers/gpu/drm/xlnx/zynqmp_dp.c | 17 +- drivers/platform/arm64/acer-aspire1-ec.c | 3 +- include/drm/drm_atomic.h | 45 ++++ include/drm/drm_bridge.h | 39 +++- 91 files changed, 681 insertions(+), 574 deletions(-) --- base-commit: 50d0a57d3a4193862a53fae0de7ed7749908cd8f change-id: 20250115-bridge-connector-f93194e267ff Best regards,