From patchwork Wed Feb 19 11:53:53 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nemesa Garg X-Patchwork-Id: 13982035 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7261BC021B1 for ; Wed, 19 Feb 2025 11:59:38 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2EFF410E29D; Wed, 19 Feb 2025 11:59:37 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="IdpPRoHy"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id 09C2510E263; Wed, 19 Feb 2025 11:59:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1739966376; x=1771502376; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=sbrJy5ytrQ7LJSKpTOeGcrnVN9+M5jjiVuUzcDFJnkc=; b=IdpPRoHyq/eaaCfXXWHMHfzi5iRKCFRI/OyujEfAlGOoJ+hH/DY915BV jcxtqn2H2tCWRRzyIEhnEwW4VtA86cpDW7RD5z2SH4T2OGVOgIQiAcIeT FdencNMQJhh7+hY7WcRk8i0TBuBHTHbG2zq9sIWI+fkiRu2Z8kpwmK6rE W3olMUgNSnxZcV0GdtlSPFQgixDYnT7CqiBQ25kVN/vvAyLxg5tVg2Ods 0Y93iBHSjdRufvtXARI+YP6/Uq1gUwXb+lrTqJ60kwjY5hbEkdGwb4vfI /kdaRPH6T8SRafLM04emJJh5kncl+1v0TaTZfWCaORQdyEXe1z/2HICxL A==; X-CSE-ConnectionGUID: xS36h71sQraferrVQfzVgA== X-CSE-MsgGUID: nc2QfA5VTP64LQ8UrpGWiA== X-IronPort-AV: E=McAfee;i="6700,10204,11348"; a="52103057" X-IronPort-AV: E=Sophos;i="6.13,298,1732608000"; d="scan'208";a="52103057" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Feb 2025 03:59:34 -0800 X-CSE-ConnectionGUID: VrPo7NzSTNKZKCaZD9rAlg== X-CSE-MsgGUID: LNdKdGHmQ0WJ7eEGaGQhzw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,298,1732608000"; d="scan'208";a="114544870" Received: from nemesa.iind.intel.com ([10.190.239.22]) by fmviesa006.fm.intel.com with ESMTP; 19 Feb 2025 03:59:32 -0800 From: Nemesa Garg To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: Nemesa Garg Subject: [PATCH 0/6] Introduce drm sharpness property Date: Wed, 19 Feb 2025 17:23:53 +0530 Message-Id: <20250219115359.2320992-1-nemesa.garg@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Many a times images are blurred or upscaled content is also not as crisp as original rendered image. Traditional sharpening techniques often apply a uniform level of enhancement across entire image, which sometimes result in over-sharpening of some areas and potential loss of natural details. Intel has come up with Display Engine based adaptive sharpening filter with minimal power and performance impact. From LNL onwards, the Display hardware can use one of the pipe scaler for adaptive sharpness filter. This can be used for both gaming and non-gaming use cases like photos, image viewing. It works on a region of pixels depending on the tap size. This is an attempt to introduce an adaptive sharpness solution which helps in improving the image quality. For this new CRTC property is added. The user can set this property with desired sharpness strength value with 0-255. A value of 1 representing minimum sharpening strength and 255 representing maximum sharpness strength. A strength value of 0 means no sharpening or sharpening feature disabled. It works on a region of pixels depending on the tap size. The coefficients are used to generate an alpha value which is used to blend the sharpened image to original image. Middleware MR link: https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/3665 IGT patchwork link: https://patchwork.freedesktop.org/series/130218/ Continuing discussions from: https://patchwork.freedesktop.org/series/129888/ Nemesa Garg (6): drm: Introduce sharpness strength property drm/i915/display: Compute the scaler filter coefficients drm/i915/display: Enable the second scaler drm/i915/display: Configure the second scaler for sharpness drm/i915/display: Add registers and compute the strength drm/i915/display: Load the lut values and enable sharpness drivers/gpu/drm/drm_atomic_uapi.c | 4 + drivers/gpu/drm/drm_crtc.c | 35 +++ drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/display/intel_casf.c | 272 ++++++++++++++++++ drivers/gpu/drm/i915/display/intel_casf.h | 24 ++ .../gpu/drm/i915/display/intel_casf_regs.h | 41 +++ drivers/gpu/drm/i915/display/intel_crtc.c | 3 + .../drm/i915/display/intel_crtc_state_dump.c | 5 + drivers/gpu/drm/i915/display/intel_display.c | 45 ++- .../drm/i915/display/intel_display_device.h | 1 + .../drm/i915/display/intel_display_types.h | 16 ++ drivers/gpu/drm/i915/display/intel_pfit.c | 8 + drivers/gpu/drm/i915/display/skl_scaler.c | 105 ++++++- drivers/gpu/drm/i915/display/skl_scaler.h | 1 + drivers/gpu/drm/xe/Makefile | 1 + include/drm/drm_crtc.h | 17 ++ 16 files changed, 563 insertions(+), 16 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/intel_casf.c create mode 100644 drivers/gpu/drm/i915/display/intel_casf.h create mode 100644 drivers/gpu/drm/i915/display/intel_casf_regs.h