| Message ID | 20250224205908.26336-1-soci@c64.rulez.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Refactoring of framebuffer drawing routines | expand |
On 2/24/25 21:59, Zsolt Kajtar wrote: > Proper refactoring of the framebuffer drawing routines. This time it's > not only the merging of duplicated code. It isn't half finished either > so the various combinations of foreign endianness, pixel reversing, bits > per pixel, cpu word sizes and byte order should work. > > Added myself to look after this code. Based on the time spent on proving > it I don't expect a busy inbox. Famous last words. > > Zsolt Kajtar (1): > Refactoring of framebuffer drawing routines I'd like to give this patch a chance to live in for-next for a few days, although I don't like such a big rewrite as one patch. But in this case it's probably necessary to make an exception. Important: please add a proper commit message to your patch! Explain why you do that, and what advantages it gives. Describe what should be different. Is something maybe faster or slower? Then, the patch did not applied for me and git mentioned that the patch was corrupt. Not sure yet, if the problem is on my side... Helge > MAINTAINERS | 16 + > drivers/video/fbdev/core/Kconfig | 10 +- > drivers/video/fbdev/core/cfbcopyarea.c | 428 +------------------- > drivers/video/fbdev/core/cfbfillrect.c | 362 +---------------- > drivers/video/fbdev/core/cfbimgblt.c | 357 +---------------- > drivers/video/fbdev/core/cfbmem.h | 43 ++ > drivers/video/fbdev/core/fb_copyarea.h | 405 +++++++++++++++++++ > drivers/video/fbdev/core/fb_draw.h | 274 ++++++------- > drivers/video/fbdev/core/fb_fillrect.h | 280 ++++++++++++++ > drivers/video/fbdev/core/fb_imageblit.h | 495 ++++++++++++++++++++++++ > drivers/video/fbdev/core/syscopyarea.c | 369 +----------------- > drivers/video/fbdev/core/sysfillrect.c | 324 +--------------- > drivers/video/fbdev/core/sysimgblt.c | 333 +--------------- > drivers/video/fbdev/core/sysmem.h | 39 ++ > 14 files changed, 1480 insertions(+), 2255 deletions(-) > create mode 100644 drivers/video/fbdev/core/cfbmem.h > create mode 100644 drivers/video/fbdev/core/fb_copyarea.h > create mode 100644 drivers/video/fbdev/core/fb_fillrect.h > create mode 100644 drivers/video/fbdev/core/fb_imageblit.h > create mode 100644 drivers/video/fbdev/core/sysmem.h >
On 2/24/25 21:59, Zsolt Kajtar wrote: > Proper refactoring of the framebuffer drawing routines. This time it's > not only the merging of duplicated code. It isn't half finished either > so the various combinations of foreign endianness, pixel reversing, bits > per pixel, cpu word sizes and byte order should work. > > Added myself to look after this code. Based on the time spent on proving > it I don't expect a busy inbox. Famous last words. > > Zsolt Kajtar (1): > Refactoring of framebuffer drawing routines > > MAINTAINERS | 16 + > drivers/video/fbdev/core/Kconfig | 10 +- > drivers/video/fbdev/core/cfbcopyarea.c | 428 +------------------- > drivers/video/fbdev/core/cfbfillrect.c | 362 +---------------- > drivers/video/fbdev/core/cfbimgblt.c | 357 +---------------- > drivers/video/fbdev/core/cfbmem.h | 43 ++ > drivers/video/fbdev/core/fb_copyarea.h | 405 +++++++++++++++++++ > drivers/video/fbdev/core/fb_draw.h | 274 ++++++------- > drivers/video/fbdev/core/fb_fillrect.h | 280 ++++++++++++++ > drivers/video/fbdev/core/fb_imageblit.h | 495 ++++++++++++++++++++++++ > drivers/video/fbdev/core/syscopyarea.c | 369 +----------------- > drivers/video/fbdev/core/sysfillrect.c | 324 +--------------- > drivers/video/fbdev/core/sysimgblt.c | 333 +--------------- > drivers/video/fbdev/core/sysmem.h | 39 ++ > 14 files changed, 1480 insertions(+), 2255 deletions(-) > create mode 100644 drivers/video/fbdev/core/cfbmem.h > create mode 100644 drivers/video/fbdev/core/fb_copyarea.h > create mode 100644 drivers/video/fbdev/core/fb_fillrect.h > create mode 100644 drivers/video/fbdev/core/fb_imageblit.h > create mode 100644 drivers/video/fbdev/core/sysmem.h I've applied that series to the fbdev git tree so that it gets some testing... Helge