mbox series

[0/5] drm/amd/pm: Prevent division by zero

Message ID 20250321105239.10096-1-arefev@swemel.ru (mailing list archive)
Headers show
Series drm/amd/pm: Prevent division by zero | expand

Message

Denis Arefev March 21, 2025, 10:52 a.m. UTC 
This series of patches prevents possible division by zero.

The user can set any speed value.
If speed is greater than UINT_MAX/8, division by zero is possible.

Found by Linux Verification Center (linuxtesting.org) with SVACE. 

Denis Arefev (5):
  drm/amd/pm: Prevent division by zero
  drm/amd/pm: Prevent division by zero
  drm/amd/pm: Prevent division by zero
  drm/amd/pm: Prevent division by zero
  drm/amd/pm: Prevent division by zero

 drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_thermal.c   | 6 +++---
 drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_thermal.c | 4 ++--
 drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_thermal.c | 2 +-
 drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c       | 3 +++
 drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c          | 2 +-
 5 files changed, 10 insertions(+), 7 deletions(-)

I did not change these files, because the functions you are 
interested in are not used there for a long time.
drivers/gpu/drm/radeon/si_dpm.c
drivers/gpu/drm/radeon/ci_dpm.c

Comments

Alex Deucher March 21, 2025, 1:40 p.m. UTC | #1 
On Fri, Mar 21, 2025 at 6:53 AM Denis Arefev <arefev@swemel.ru> wrote:
>
> This series of patches prevents possible division by zero.
>
> The user can set any speed value.
> If speed is greater than UINT_MAX/8, division by zero is possible.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.

Applied the series.  Thanks!

Alex

>
> Denis Arefev (5):
>   drm/amd/pm: Prevent division by zero
>   drm/amd/pm: Prevent division by zero
>   drm/amd/pm: Prevent division by zero
>   drm/amd/pm: Prevent division by zero
>   drm/amd/pm: Prevent division by zero
>
>  drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_thermal.c   | 6 +++---
>  drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_thermal.c | 4 ++--
>  drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_thermal.c | 2 +-
>  drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c       | 3 +++
>  drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c          | 2 +-
>  5 files changed, 10 insertions(+), 7 deletions(-)
>
> I did not change these files, because the functions you are
> interested in are not used there for a long time.
> drivers/gpu/drm/radeon/si_dpm.c
> drivers/gpu/drm/radeon/ci_dpm.c
>
> --
> 2.43.0
>