From patchwork Tue Apr 8 10:24:56 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nemesa Garg X-Patchwork-Id: 14042679 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B7402C369A5 for ; Tue, 8 Apr 2025 10:30:01 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F00A810E62E; Tue, 8 Apr 2025 10:29:59 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="jjDLRV+G"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7781210E212; Tue, 8 Apr 2025 10:29:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1744108199; x=1775644199; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=/42qCsYube2Is1JLKyCIxIG0MHbAzrTOdxZOHeulfs8=; b=jjDLRV+G5/3vAJ4In4YF2uBjc6MNmoc7gxsRbIWawjgREEexaeZma/X7 9txyMoELvkadgEdIW1Zp7QX5DN3CL1M4sdqTkrVb9ty8LXtQhL80hDoXo JJsWOa98HJ9bOsyDCDxW04LMk7MWkaKTSATswuu3thRm1YWoWoVVgpMEn nNF7JeUBqC8STrwwWEnWsUJF4/340UiaAR6pWfcupAWp/APbve5aNcJUA HlGXzM15uNauiiPym2WzuiR5rzJecAfCnQWnkGxlQ0P8kj50DG7spB3lA rqH35TkCzhspotzXf8qwywe66KyqgNe7FwglAvAVlUwYTt/6PhziuBi49 A==; X-CSE-ConnectionGUID: hGIIX5D0SQCesDWJfj4nCw== X-CSE-MsgGUID: vdfwhfLQTxydBIKvFjQObA== X-IronPort-AV: E=McAfee;i="6700,10204,11397"; a="62934136" X-IronPort-AV: E=Sophos;i="6.15,197,1739865600"; d="scan'208";a="62934136" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2025 03:29:53 -0700 X-CSE-ConnectionGUID: jnqbSuCySD6EpMI3FPnf9g== X-CSE-MsgGUID: AktY6Mv0TK6TM0VwBmPzkA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,197,1739865600"; d="scan'208";a="133391980" Received: from nemesa.iind.intel.com ([10.190.239.22]) by fmviesa004.fm.intel.com with ESMTP; 08 Apr 2025 03:29:51 -0700 From: Nemesa Garg To: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org Cc: Nemesa Garg Subject: [PATCH 00/10] Introduce drm sharpness property Date: Tue, 8 Apr 2025 15:54:56 +0530 Message-Id: <20250408102506.1053569-1-nemesa.garg@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Many a times images are blurred or upscaled content is also not as crisp as original rendered image. Traditional sharpening techniques often apply a uniform level of enhancement across entire image, which sometimes result in over-sharpening of some areas and potential loss of natural details. Intel has come up with Display Engine based adaptive sharpening filter with minimal power and performance impact. From LNL onwards, the Display hardware can use one of the pipe scaler for adaptive sharpness filter. This can be used for both gaming and non-gaming use cases like photos, image viewing. It works on a region of pixels depending on the tap size. This is an attempt to introduce an adaptive sharpness solution which helps in improving the image quality. For this new CRTC property is added. The user can set this property with desired sharpness strength value with 0-255. A value of 1 representing minimum sharpening strength and 255 representing maximum sharpness strength. A strength value of 0 means no sharpening or sharpening feature disabled. It works on a region of pixels depending on the tap size. The coefficients are used to generate an alpha value which is used to blend the sharpened image to original image. Middleware MR link: https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/3665 IGT patchwork link: https://patchwork.freedesktop.org/series/130218/ Continuing discussions from: https://patchwork.freedesktop.org/series/129888/ Nemesa Garg (10): drm/i915/display: Introduce sharpness strength property drm/i915/display: Introduce HAS_CASF for sharpness support drm/i915/display: Add strength and winsize register drm/i915/display: Add filter lut values drm/i915/display: Compute the scaler coefficients drm/i915/display: Add and compute scaler parameter drm/i915/display: Configure the second scaler drm/i915/display: Set and get the casf config drm/i915/display: Enable/disable casf drm/i915/display: Expose sharpness strength property drivers/gpu/drm/drm_atomic_uapi.c | 4 + drivers/gpu/drm/drm_crtc.c | 35 +++ drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/display/intel_casf.c | 280 ++++++++++++++++++ drivers/gpu/drm/i915/display/intel_casf.h | 24 ++ .../gpu/drm/i915/display/intel_casf_regs.h | 40 +++ drivers/gpu/drm/i915/display/intel_crtc.c | 3 + .../drm/i915/display/intel_crtc_state_dump.c | 7 + drivers/gpu/drm/i915/display/intel_display.c | 37 ++- .../drm/i915/display/intel_display_device.h | 1 + .../drm/i915/display/intel_display_types.h | 15 + drivers/gpu/drm/i915/display/skl_scaler.c | 90 +++++- drivers/gpu/drm/i915/display/skl_scaler.h | 1 + drivers/gpu/drm/xe/Makefile | 1 + include/drm/drm_crtc.h | 17 ++ 15 files changed, 543 insertions(+), 13 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/intel_casf.c create mode 100644 drivers/gpu/drm/i915/display/intel_casf.h create mode 100644 drivers/gpu/drm/i915/display/intel_casf_regs.h