[v3,0/3] drm/panel: Support Rocktech jh057n00900 DSI panel

Message

Guido Günther March 4, 2019, 5:53 p.m. UTC

It's a 5.5" 720x1440 TFT LCD MIPI DSI panel with built in touchscreen and
backlight as found in the Librem 5 devkit.

These patches are against linux next as of 2019-02-08.

Changes from v2
* As per review comments from Sam Ravnborg
  * Lowercase sentinel
  * Drop '_panel' postfix
  * DRM_DEV_ logging instead of plain DRM_
* Add Sam's Reviewed-by:
* Add "panel-rocktech-" to the driver name following
  the pattern from other drm panel drivers.

Changes from v1
* As per review comments from Sam Ravnborg
  * Make SPDX-License-Identifier match MODULE_LICENSE
  * Sort include files alphabetically
  * Drop drmP.h and use individual includes
  * Drop superfuous 'x' in mode printout on error path
  * Allpixelson_set: Add proper space around '*'
  * Drop superfluous put_device(&ctx->backlight->dev);
  * Add /* Sentinel */ in jh057n_of_match
  * Drop jh057n->enabled
  * Drop drm_display_info_set_bus_formats
* Kconfig: Depend on BACKLIGHT_CLASS_DEVICE which somehow got lost
* Move jh057n_enable close to jh057n_disable

Guido Günther (3):
  dt-bindings: Add vendor prefix for ROCKTECH DISPLAYS LIMITED
  dt-bindings: Add Rocktech jh057n00900 panel bindings
  drm/panel: Add Rocktech jh057n00900 panel driver

 .../display/panel/rocktech,jh057n00900.txt    |  18 +
 .../devicetree/bindings/vendor-prefixes.txt   |   1 +
 drivers/gpu/drm/panel/Kconfig                 |  13 +
 drivers/gpu/drm/panel/Makefile                |   1 +
 .../drm/panel/panel-rocktech-jh057n00900.c    | 386 ++++++++++++++++++
 5 files changed, 419 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.txt
 create mode 100644 drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c

Comments

Sam Ravnborg March 4, 2019, 6:05 p.m. UTC | #1

Hi Thierry.

> Changes from v2
> * As per review comments from Sam Ravnborg
>   * Lowercase sentinel
>   * Drop '_panel' postfix
>   * DRM_DEV_ logging instead of plain DRM_
> * Add Sam's Reviewed-by:
> * Add "panel-rocktech-" to the driver name following
>   the pattern from other drm panel drivers.

With the changes done in v2 the patch series is IMO
ready to be applied.

	Sam

Guido Günther March 14, 2019, 6:01 p.m. UTC | #2

Hi,
On Mon, Mar 04, 2019 at 07:05:52PM +0100, Sam Ravnborg wrote:
> Hi Thierry.
> 
> > Changes from v2
> > * As per review comments from Sam Ravnborg
> >   * Lowercase sentinel
> >   * Drop '_panel' postfix
> >   * DRM_DEV_ logging instead of plain DRM_
> > * Add Sam's Reviewed-by:
> > * Add "panel-rocktech-" to the driver name following
> >   the pattern from other drm panel drivers.
> 
> With the changes done in v2 the patch series is IMO
> ready to be applied.

Thanks a lot for the review. Is there anything I can do to get it
applied?
Cheers,
 -- Guido