mbox series

[v2,0/4] drm/panel: jh057n0090: Add regulators and drop magic value in init

Message ID cover.1561542477.git.agx@sigxcpu.org (mailing list archive)
Headers show
Series drm/panel: jh057n0090: Add regulators and drop magic value in init | expand

Message

Guido Günther June 26, 2019, 10:37 a.m. UTC
Fix the omission of a regulators for the recently added panel and make sure all
dsi commands start with a command instead of one having a magic constant (which
already caused confusion).

Also adds a mail alias to the panel's MAINTAINER entry to reduce the bus
factor.

Changes from v1:
* As per review comments from Sam Ravnborg:
  - Print error on devm_regulator_get() failres
  - Fix typos in commit messages
* Print an error on regulator_enable()
* Disable vcc if iovcc fails to enable

Guido Günther (4):
  MAINTAINERS: Add Purism mail alias as reviewer for their devkit's
    panel
  drm/panel: jh057n00900: Don't use magic constant
  dt-bindings: display/panel: jh057n00900: Document power supply
    properties
  drm/panel: jh057n00900: Add regulator support

 .../display/panel/rocktech,jh057n00900.txt    |  5 +++
 MAINTAINERS                                   |  1 +
 .../drm/panel/panel-rocktech-jh057n00900.c    | 44 ++++++++++++++++++-
 3 files changed, 49 insertions(+), 1 deletion(-)

Comments

Sam Ravnborg June 26, 2019, 12:41 p.m. UTC | #1
Hi Guido.

On Wed, Jun 26, 2019 at 12:37:47PM +0200, Guido Günther wrote:
> Fix the omission of a regulators for the recently added panel and make sure all
> dsi commands start with a command instead of one having a magic constant (which
> already caused confusion).
> 
> Also adds a mail alias to the panel's MAINTAINER entry to reduce the bus
> factor.
> 
> Changes from v1:
> * As per review comments from Sam Ravnborg:
>   - Print error on devm_regulator_get() failres
>   - Fix typos in commit messages
> * Print an error on regulator_enable()
> * Disable vcc if iovcc fails to enable
> 
> Guido Günther (4):
>   MAINTAINERS: Add Purism mail alias as reviewer for their devkit's
>     panel
>   drm/panel: jh057n00900: Don't use magic constant
>   dt-bindings: display/panel: jh057n00900: Document power supply
>     properties
>   drm/panel: jh057n00900: Add regulator support

Patches applied to drm-misc-next and pushed out

	Sam
Guido Günther June 26, 2019, 1:15 p.m. UTC | #2
Hi,
On Wed, Jun 26, 2019 at 02:41:39PM +0200, Sam Ravnborg wrote:
> Hi Guido.
> 
> On Wed, Jun 26, 2019 at 12:37:47PM +0200, Guido Günther wrote:
> > Fix the omission of a regulators for the recently added panel and make sure all
> > dsi commands start with a command instead of one having a magic constant (which
> > already caused confusion).
> > 
> > Also adds a mail alias to the panel's MAINTAINER entry to reduce the bus
> > factor.
> > 
> > Changes from v1:
> > * As per review comments from Sam Ravnborg:
> >   - Print error on devm_regulator_get() failres
> >   - Fix typos in commit messages
> > * Print an error on regulator_enable()
> > * Disable vcc if iovcc fails to enable
> > 
> > Guido Günther (4):
> >   MAINTAINERS: Add Purism mail alias as reviewer for their devkit's
> >     panel
> >   drm/panel: jh057n00900: Don't use magic constant
> >   dt-bindings: display/panel: jh057n00900: Document power supply
> >     properties
> >   drm/panel: jh057n00900: Add regulator support
> 
> Patches applied to drm-misc-next and pushed out

Thank you!
 -- Guido

> 
> 	Sam
>