| Message ID | cover.1564146727.git.agx@sigxcpu.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm/panel: jh057n00900: Move dsi init sequence to prepare | expand |
Hi Guido. On Fri, Jul 26, 2019 at 03:14:35PM +0200, Guido Günther wrote: > > If the panel is wrapped in a panel_bridge it gets prepar()ed before the > upstream DSI bridge which can cause hangs (e.g. with imx-nwl since clocks > are not enabled yet). To avoid this move the panel's first DSI access to > enable() so the upstream bridge can prepare the DSI host controller in > it's pre_enable(). > > The second patch makes the disable() call symmetric to the above and the third > one just eases debugging. > > Changes from v1: > * As per review comments by Sam Ravnborg > * Ignore failures to disable the backlight in jh057n_disable() > * Add 'drm/panel: jh057n00900: Use drm_panel_{unprepare,disable} consistently' > * Collected Reviewed-By: Thanks Sam! > > To: "Guido Günther" <agx@sigxcpu.org>,Purism Kernel Team <kernel@puri.sm>,Thierry Reding <thierry.reding@gmail.com>,Sam Ravnborg <sam@ravnborg.org>,David Airlie <airlied@linux.ie>,Daniel Vetter <daniel@ffwll.ch>,dri-devel@lists.freedesktop.org,linux-kernel@vger.kernel.org > > > Guido Günther (4): > drm/panel: jh057n00900: Move panel DSI init to enable() > drm/panel: jh057n00900: Move mipi_dsi_dcs_set_display_off to disable() > drm/panel: jh057n00900: Print error code on all DRM_DEV_ERROR()s > drm/panel: jh057n00900: Use drm_panel_{unprepare,disable} consistently Looks good. Series applied to drm-misc-next and pushed out. Sam
If the panel is wrapped in a panel_bridge it gets prepar()ed before the upstream DSI bridge which can cause hangs (e.g. with imx-nwl since clocks are not enabled yet). To avoid this move the panel's first DSI access to enable() so the upstream bridge can prepare the DSI host controller in it's pre_enable(). The second patch makes the disable() call symmetric to the above and the third one just eases debugging. Changes from v1: * As per review comments by Sam Ravnborg * Ignore failures to disable the backlight in jh057n_disable() * Add 'drm/panel: jh057n00900: Use drm_panel_{unprepare,disable} consistently' * Collected Reviewed-By: Thanks Sam! To: "Guido Günther" <agx@sigxcpu.org>,Purism Kernel Team <kernel@puri.sm>,Thierry Reding <thierry.reding@gmail.com>,Sam Ravnborg <sam@ravnborg.org>,David Airlie <airlied@linux.ie>,Daniel Vetter <daniel@ffwll.ch>,dri-devel@lists.freedesktop.org,linux-kernel@vger.kernel.org Guido Günther (4): drm/panel: jh057n00900: Move panel DSI init to enable() drm/panel: jh057n00900: Move mipi_dsi_dcs_set_display_off to disable() drm/panel: jh057n00900: Print error code on all DRM_DEV_ERROR()s drm/panel: jh057n00900: Use drm_panel_{unprepare,disable} consistently .../drm/panel/panel-rocktech-jh057n00900.c | 31 ++++++++++--------- 1 file changed, 17 insertions(+), 14 deletions(-)