[v3,0/2] drm/i915: Avoid full proxy f_ops debug attributes

Message

Deepak R Varma Jan. 11, 2023, 3:50 p.m. UTC

This patch series proposes to replace a combination of DEFINE_SIMPLE_ATTRIBUTE() +
debugfs_create_file() by a combination of DEFINE_DEBUGFS_ATTRIBUTE() +
debugfs_create_file_unsafe(). The change reduced overhead in terms of managing
the full proxy f_ops at runtime. The patches 1 & 2 covers for the DRRS and FBC
f_ops debugfs attributes respectively.

Following coccicheck make command helped identify this change:

make coccicheck M=drivers/gpu/drm/i915/ MODE=patch COCCI=./scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci

Changes in v3:
   Patch 1/2: fix checkpatch function parameter alignment complaint
   Patch 2/2: None

Changes in v2:
   - Individual patches clubbed in patch set
   - Update patch log message to include coccicheck make command


Deepak R Varma (2):
  drm/i915/display: Avoid full proxy f_ops for DRRS debug attributes
  drm/i915/fbc: Avoid full proxy f_ops for FBC debug attributes

 drivers/gpu/drm/i915/display/intel_drrs.c |  8 ++++----
 drivers/gpu/drm/i915/display/intel_fbc.c  | 12 ++++++------
 2 files changed, 10 insertions(+), 10 deletions(-)

Comments

Rodrigo Vivi Jan. 13, 2023, 7:05 p.m. UTC | #1

On Wed, Jan 11, 2023 at 09:20:40PM +0530, Deepak R Varma wrote:
> This patch series proposes to replace a combination of DEFINE_SIMPLE_ATTRIBUTE() +
> debugfs_create_file() by a combination of DEFINE_DEBUGFS_ATTRIBUTE() +
> debugfs_create_file_unsafe(). The change reduced overhead in terms of managing
> the full proxy f_ops at runtime. The patches 1 & 2 covers for the DRRS and FBC
> f_ops debugfs attributes respectively.
> 
> Following coccicheck make command helped identify this change:
> 
> make coccicheck M=drivers/gpu/drm/i915/ MODE=patch COCCI=./scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci

pushed both patches to drm-intel-next. Thanks for the patches.

> 
> Changes in v3:
>    Patch 1/2: fix checkpatch function parameter alignment complaint
>    Patch 2/2: None
> 
> Changes in v2:
>    - Individual patches clubbed in patch set
>    - Update patch log message to include coccicheck make command
> 
> 
> Deepak R Varma (2):
>   drm/i915/display: Avoid full proxy f_ops for DRRS debug attributes
>   drm/i915/fbc: Avoid full proxy f_ops for FBC debug attributes
> 
>  drivers/gpu/drm/i915/display/intel_drrs.c |  8 ++++----
>  drivers/gpu/drm/i915/display/intel_fbc.c  | 12 ++++++------
>  2 files changed, 10 insertions(+), 10 deletions(-)
> 
> -- 
> 2.34.1
> 
> 
>