From patchwork Wed Jan 10 01:08:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Sandor Yu X-Patchwork-Id: 13515563 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 95141C47077 for ; Wed, 10 Jan 2024 01:09:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C465310E54A; Wed, 10 Jan 2024 01:09:57 +0000 (UTC) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20601.outbound.protection.outlook.com [IPv6:2a01:111:f403:2613::601]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0944410E54A for ; Wed, 10 Jan 2024 01:09:55 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Hi9MH7/vcQqHXFS+LNNH/Cw579h33KyOlxM1RIqr3IRyhrtkWdoRvcpmzeIANfj2ahPwa9xgT9MVV97Zk+V3VvkyPQzwRfGn1lbueufY4st0cmcWwAcGrIbxFmO9LrH4hP28bXAo0tOBrt1Gf0nJJLsUHGxivmTAgeNKE/3cEGu1otNqVose7By0ZBOKuN+fTMHI73F5QkdUmRIVfccS04yUenJiL/NFRxrpLbpNJvwTOEIxlbF+9yKZPyuG+InQaZPu91ISNk3aqFlTXRPlHF2q7367sOxnzFOZWoT3IbhWNeXovlT6gq6v7dsV1xCDsLYmoulzOE37WhObEW1HjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=o/aIxW6s1Y02ApE3Fq0m9Vd3LptkSrQjTExOx7xf5zs=; b=S7KDTaa0vYFyb17FEOH94niGNnAdD1v06/L1QIaUrO/FK/TcoXVoFoJ0/LJ+6c5vJOipvsmwcUoLIRUeEKKTEyVerxRYgyavqtvfrMgXchZZk2tG9gN48w9TqRiP2EKpnbRDDbJkKmYrJcTntNmlkm4H8Hut/hgSFcqaTv9Xp4LO8AGLhlj+GwYaWI+nm/oQwOutKc1z3IZ7Los9w5bw/17G9+uxEl2/oM9xc7Wdmi72Fr5/Hwn++xMsqOfXlSRfXK2Qo9M1A9TUfwORLo4GPyyBGWINMQ3BPGcwNENL1mLwqr8wA0yQS5hd1S9aiP5vQtkmANkffVSs0HapB/3QZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=o/aIxW6s1Y02ApE3Fq0m9Vd3LptkSrQjTExOx7xf5zs=; b=Y37icVCP1jdzmOpywAFR5EqVpshyyusuxP1pP+UAyQGRQo/pY+7yks+o9guhk7iyOI12vP6TFCIvgfgMl63M5mjzNuXRs5PMGjs2JASQz7xdQQ1XxrLAnlD4iW0l+nWJUN8Oi6p3lGoqTqfFPZY2BbnZyhhZrLoyZz/Qiq2PYvk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9448.eurprd04.prod.outlook.com (2603:10a6:102:2b1::21) by VI1PR04MB9836.eurprd04.prod.outlook.com (2603:10a6:800:1d9::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.23; Wed, 10 Jan 2024 01:09:52 +0000 Received: from PAXPR04MB9448.eurprd04.prod.outlook.com ([fe80::e6e0:d026:3089:17d5]) by PAXPR04MB9448.eurprd04.prod.outlook.com ([fe80::e6e0:d026:3089:17d5%5]) with mapi id 15.20.7159.020; Wed, 10 Jan 2024 01:09:52 +0000 From: Sandor Yu To: dmitry.baryshkov@linaro.org, andrzej.hajda@intel.com, neil.armstrong@linaro.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, airlied@gmail.com, daniel@ffwll.ch, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, vkoul@kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org Subject: [PATCH v12 0/7] Initial support Cadence MHDP8501(HDMI/DP) for i.MX8MQ Date: Wed, 10 Jan 2024 09:08:41 +0800 Message-Id: X-Mailer: git-send-email 2.34.1 X-ClientProxiedBy: SI1PR02CA0045.apcprd02.prod.outlook.com (2603:1096:4:1f6::16) To PAXPR04MB9448.eurprd04.prod.outlook.com (2603:10a6:102:2b1::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9448:EE_|VI1PR04MB9836:EE_ X-MS-Office365-Filtering-Correlation-Id: 93a42f71-8575-4e2b-48b3-08dc1178d977 X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: g9JYN2A9HF/El0cjgjnMBSq7oz/upom5NkhPu5TEF46IYZAQcAHTmf09fMGADuyWa4R5/abTL79MEdeVd7cVfPlB5m5W+yyjhRloXiG560d1ohzclpe8STDu/eaKUamGz+lPOHN1adVIKZGDDLcqzQKcJk93W6u0p4wqXADGOGiWRX5ojpiz5h5idJlb5TiJdFH7Y2oJQn3MQpO1GvWXfN0GMzhG9ubL5xXEeXP4d5ER/PpK+za6md9uXCBdtZdLx+HJhhfx6M2kMRikQNscEQ0u6dCgk5/XGmEXyvZP/33YmS5auGqGKgpi0fqfRWwq2e7bxaLBQ6Ya5ogYoknuOtD4o5cHKiev2znyROHgyJeFs7K5WZ0hqrCYU5dnbg9TBfBTdiFfRRRz1D9Xx2H9sv119Thp7HU6NR3uFIG4XxC93tzqb8SWKtQv14PSwqzhjMAR8GWc69z2/XZGV+LgVLishusPaVUC7CZJd5YDhNRNwA05eSWENeaLy3EPQG+rWR0hMPAjGJ9d7vQKjG6gmr4rH/Ps8UcR2zGuViaSh2vUz0EMNcY0QOQ4QpYNP/ph3fCOHeZ1EIM9wuotOJkIOq6iQLjURj17TNvLY03vP0ecBNfbdYApwLzGrZH/XNYo X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR04MB9448.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(376002)(366004)(396003)(136003)(346002)(230922051799003)(451199024)(1800799012)(64100799003)(186009)(83380400001)(38100700002)(38350700005)(36756003)(921011)(86362001)(26005)(2616005)(52116002)(6512007)(4326008)(316002)(66476007)(6486002)(8936002)(66556008)(66946007)(966005)(478600001)(6506007)(6666004)(8676002)(41300700001)(2906002)(5660300002)(7416002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?YQbgBCk4WIcisCcNCJaKmN1ICbbp?= =?utf-8?q?+r7eiWGanBfVUddFcDLmOWqQ5K40hHqjlPYG9F5WtCTaUcgurPvKA/+AbtnDRV+IZ?= =?utf-8?q?Ii5e5PtcNa59N4XHwxIkb9Q8zfaxF+ANr8ZxBetMKPSYh2B6g32PnFRApIUf9dp7P?= =?utf-8?q?IaDlpSpv/k2jK3r4FxLMeDQlbxr5ksys1QjqrdzxoQrl7eEYvYGEsJUS4b/fRADPr?= =?utf-8?q?mKMBdQdYbwSTpDr1BS06hBCtcPvbS9DuAnZhta5508uSuVl//etvwgwabsHvPdWmw?= =?utf-8?q?3IRgF15+mxw8mzH6iP9AmxLtF4jhWN/wohK2Mj2nrMw/a2nhD8yPucM2qSyIQ+y+c?= =?utf-8?q?ePFqjgjqyqLnoqxXsuDytdkTwtqBIgwkGmwCecGDn3zh4W7WVvmBOj4qCC6VLjhyW?= =?utf-8?q?ekZtU0IuN80XbW61SJDNOd+MVG4eQDvbvC4gEX8U++P+x2DAquvttEJ9IiQT4nIV4?= =?utf-8?q?chzIeS8rSl/QyevCW7E5zPfSI6QWx1XIpjW0psVZMzxnAHhIFhC1Qoj6pmEBTX0sB?= =?utf-8?q?rPvK1K/jq7ooRoj2tNOKZ2yfQBYtyPY3dyPFU72DrPUsRtG9MHRM3xHu8tX7CGvPL?= =?utf-8?q?Q7pvtTBC0MoGz7AKcR4KArhJyaOUPxP20FiDI9rXNqyy8PpMwhjV3ftzs74TvzvN8?= =?utf-8?q?SByP+OVG1KgrjCxlnjsml5CTZrWdGX95oyU3AuulpkRXwKI2L8qVO1gdMK7DU5uiW?= =?utf-8?q?NYzLnXJ3/hx5BtNFSNKU8uMXhwpDe8Y2s66x0zxWO4XpPsmoof3Q4+GLalgglLLXK?= =?utf-8?q?KuCxRm9OdJK1sEvbZJbj932xqlw1zLXBNyC/ejage0/n3gHIdHxvcY+i/csq4l1xv?= =?utf-8?q?eqsVDp3Rp5rgL3wvh0x+FNCXgFIKMrIJsCpLrBtegtFiAtObVb7xO8A6aQ4orbwqE?= =?utf-8?q?XbcyHmVv4aMRPR0sdXF07EkMHle/rcwr6CDwo0sUJzyyboWbkEgncQ4RzJ0NgJ3vn?= =?utf-8?q?5mJkFbU08RPwQvRNaUjqmukIigaInpc3vBVdNelNBwoWqyXToQNHFMd1FA3gwPr5a?= =?utf-8?q?v/R+6ivKblp3YekzgayY04aX1vBhdxiIQIw7EKUWHuYotW3GJK+MKXbjJZvbFoEEE?= =?utf-8?q?SgZH1OjPX0GQf2sTMX1IF3T7I2wKnXtZ7paAR9ki/8lJ3y1iREOfZQops2D4tkHzy?= =?utf-8?q?nFDikI/k5GMK5uG/XHk7HH565KPiovcVvwAY55SBBh0f1lU8q5dqr82n/PryVibCu?= =?utf-8?q?XI8qW8pYN9YPNyf8xWo7YI/jHX2y897gzxAZuODJldbQAsFVAXTwrVIf8MFyE/o7/?= =?utf-8?q?AewmZoBF6cYMGCW27LgUS3pkOWFCJxku2Y/9q84NehFXkUcKm+SgD+I5rGnYsze8z?= =?utf-8?q?+KGFgXdEUWA83uVZsp++Qo07082Bt3MDGKMZTYXtb7MZ+grYNCttUBH49SRK5s2qX?= =?utf-8?q?2/Mu7FbMQqh7hD85VUgMVPOwk/lHopuVLCue5HplcWCIAKAmr+GkMDZYkvboj5+0y?= =?utf-8?q?B+j94PQL8HkQWxlFs3zB9iK0p/s73N86ZTAI9mRR8c1D55jdVph5JynNAQQ851W9o?= =?utf-8?q?a0Pt0UlMkxfc?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 93a42f71-8575-4e2b-48b3-08dc1178d977 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9448.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2024 01:09:52.3971 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DxmxivCdHw/hD2u40QX8ZTC7x+Vze0wvdhpASt9sdmZwwzS7BBPJ+oJJvu0771UZ7hh+OnjmMoVGAWripgLitA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB9836 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: oliver.brown@nxp.com, alexander.stein@ew.tq-group.com, Sandor.yu@nxp.com, linux-imx@nxp.com, kernel@pengutronix.de, sam@ravnborg.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The patch set initial support Cadence MHDP8501(HDMI/DP) DRM bridge driver and Cadence HDP-TX PHY(HDMI/DP) drivers for Freescale i.MX8MQ. The patch set compose of DRM bridge drivers and PHY drivers. Both of them need patch #1 and #2 to pass build. DRM bridges driver patches: #1: drm: bridge: Cadence: Creat mhdp helper driver #2: phy: Add HDMI configuration options #3: dt-bindings: display: bridge: Add Cadence MHDP8501 #4: drm: bridge: Cadence: Add MHDP8501 DP/HDMI driver PHY driver patches: #1: drm: bridge: Cadence: Creat mhdp helper driver #2: phy: Add HDMI configuration options #5: dt-bindings: phy: Add Freescale iMX8MQ DP and HDMI PHY #6: phy: freescale: Add DisplayPort PHY driver for i.MX8MQ #7: phy: freescale: Add HDMI PHY driver for i.MX8MQ v11->v12: Patch #1: - Move status initialize out of mbox_mutex. - Reorder API functions in alphabetical. - Add notes for malibox access functions. - Add year 2024 to copyright. Patch #4: - Replace DRM_INFO with dev_info or dev_warn. - Replace DRM_ERROR with dev_err. - Return ret when cdns_mhdp_dpcd_read failed in function cdns_dp_aux_transferi(). - Remove unused parmeter in function cdns_dp_get_msa_misc and use two separate variables for color space and bpc. - Add year 2024 to copyright. Patch #6: - Return error code to replace -1 for function wait_for_ack(). - Set cdns_phy->power_up = false in phy_power_down function. - Remove "RATE_8_1 = 810000", it is not used in driver. - Add year 2024 to copyright. Patch #7: - Adjust clk disable order. - Return error code to replace -1 for function wait_for_ack(). - Use bool for variable pclk_in. - Add year 2024 to copyright. v10->v11: - rewrite cdns_mhdp_set_firmware_active() in mhdp8546 core driver, use cdns_mhdp_mailbox_send() to replace cdns_mhdp_mailbox_write() same as the other mailbox access functions. - use static for cdns_mhdp_mailbox_write() and cdns_mhdp_mailbox_read() and remove them from EXPORT_SYMBOL_GPL(). - remove MODULE_ALIAS() from mhdp8501 driver. v9->v10: - Create mhdp helper driver to replace macro functions, move all mhdp mailbox access functions and common functions into the helper driver. Patch #1:drm: bridge: Cadence: Creat mhdp helper driver it is totaly different with v9. v8->v9: - Remove compatible string "cdns,mhdp8501" that had removed from dt-bindings file in v8. - Add Dmitry's R-b tag to patch #2 - Add Krzysztof's R-b tag to patch #3 v7->v8: MHDP8501 HDMI/DP: - Correct DT node name to "display-bridge". - Remove "cdns,mhdp8501" from mhdp8501 dt-binding doc. HDMI/DP PHY: - Introduced functions `wait_for_ack` and `wait_for_ack_clear` to handle waiting with acknowledgment bits set and cleared respectively. - Use FIELD_PRE() to set bitfields for both HDMI and DP PHY. v6->v7: MHDP8501 HDMI/DP: - Combine HDMI and DP driver into one mhdp8501 driver. Use the connector type to load the corresponding functions. - Remove connector init functions. - Add in phy_hdmi.h to reuse ‘enum hdmi_colorspace’. HDMI/DP PHY: - Lowercase hex values - Fix parameters indent issue on some functions - Replace ‘udelay’ with ‘usleep_range’ v5->v6: HDMI/DP bridge driver - 8501 is the part number of Cadence MHDP on i.MX8MQ. Use MHDP8501 to name hdmi/dp drivers and files. - Add compatible "fsl,imx8mq-mhdp8501-dp" for i.MX8MQ DP driver - Add compatible "fsl,imx8mq-mhdp8501-hdmi" for i.MX8MQ HDMI driver - Combine HDMI and DP dt-bindings into one file cdns,mhdp8501.yaml - Fix HDMI scrambling is not enable issue when driver working in 4Kp60 mode. - Add HDMI/DP PHY API mailbox protect. HDMI/DP PHY driver: - Rename DP and HDMI PHY files and move to folder phy/freescale/ - Remove properties num_lanes and link_rate from DP PHY driver. - Combine HDMI and DP dt-bindings into one file fsl,imx8mq-dp-hdmi-phy.yaml - Update compatible string to "fsl,imx8mq-dp-phy". - Update compatible string to "fsl,imx8mq-hdmi-phy". v4->v5: - Drop "clk" suffix in clock name. - Add output port property in the example of hdmi/dp. v3->v4: dt-bindings: - Correct dt-bindings coding style and address review comments. - Add apb_clk description. - Add output port for HDMI/DP connector PHY: - Alphabetically sorted in Kconfig and Makefile for DP and HDMI PHY - Remove unused registers define from HDMI and DP PHY drivers. - More description in phy_hdmi.h. - Add apb_clk to HDMI and DP phy driver. HDMI/DP: - Use get_unaligned_le32() to replace hardcode type conversion in HDMI AVI infoframe data fill function. - Add mailbox mutex lock in HDMI/DP driver for phy functions to reslove race conditions between HDMI/DP and PHY drivers. - Add apb_clk to both HDMI and DP driver. - Rename some function names and add prefix with "cdns_hdmi/cdns_dp". - Remove bpc 12 and 16 optional that not supported. v2->v3: Address comments for dt-bindings files. - Correct dts-bindings file names Rename phy-cadence-hdptx-dp.yaml to cdns,mhdp-imx8mq-dp.yaml Rename phy-cadence-hdptx-hdmi.yaml to cdns,mhdp-imx8mq-hdmi.yaml - Drop redundant words and descriptions. - Correct hdmi/dp node name. v2 is a completely different version compared to v1. Previous v1 can be available here [1]. v1->v2: - Reuse Cadence mailbox access functions from mhdp8546 instead of rockchip DP. - Mailbox access functions be convert to marco functions that will be referenced by HDP-TX PHY(HDMI/DP) driver too. - Plain bridge instead of component driver. - Standalone Cadence HDP-TX PHY(HDMI/DP) driver. - Audio driver are removed from the patch set, it will be add in another patch set later. [1] https://patchwork.kernel.org/project/linux-rockchip/cover/cover.1590982881.git.Sandor.yu@nxp.com/ Sandor Yu (7): drm: bridge: Cadence: Create mhdp helper driver phy: Add HDMI configuration options dt-bindings: display: bridge: Add Cadence MHDP8501 drm: bridge: Cadence: Add MHDP8501 DP/HDMI driver dt-bindings: phy: Add Freescale iMX8MQ DP and HDMI PHY phy: freescale: Add DisplayPort PHY driver for i.MX8MQ phy: freescale: Add HDMI PHY driver for i.MX8MQ .../display/bridge/cdns,mhdp8501.yaml | 104 ++ .../bindings/phy/fsl,imx8mq-dp-hdmi-phy.yaml | 53 + drivers/gpu/drm/bridge/cadence/Kconfig | 20 + drivers/gpu/drm/bridge/cadence/Makefile | 3 + .../gpu/drm/bridge/cadence/cdns-mhdp-helper.c | 304 ++++++ .../drm/bridge/cadence/cdns-mhdp8501-core.c | 315 ++++++ .../drm/bridge/cadence/cdns-mhdp8501-core.h | 365 +++++++ .../gpu/drm/bridge/cadence/cdns-mhdp8501-dp.c | 699 +++++++++++++ .../drm/bridge/cadence/cdns-mhdp8501-hdmi.c | 678 +++++++++++++ .../drm/bridge/cadence/cdns-mhdp8546-core.c | 403 ++------ .../drm/bridge/cadence/cdns-mhdp8546-core.h | 44 +- drivers/phy/freescale/Kconfig | 20 + drivers/phy/freescale/Makefile | 2 + drivers/phy/freescale/phy-fsl-imx8mq-dp.c | 726 +++++++++++++ drivers/phy/freescale/phy-fsl-imx8mq-hdmi.c | 959 ++++++++++++++++++ include/drm/bridge/cdns-mhdp-helper.h | 97 ++ include/linux/phy/phy-hdmi.h | 24 + include/linux/phy/phy.h | 7 +- 18 files changed, 4448 insertions(+), 375 deletions(-) create mode 100644 Documentation/devicetree/bindings/display/bridge/cdns,mhdp8501.yaml create mode 100644 Documentation/devicetree/bindings/phy/fsl,imx8mq-dp-hdmi-phy.yaml create mode 100644 drivers/gpu/drm/bridge/cadence/cdns-mhdp-helper.c create mode 100644 drivers/gpu/drm/bridge/cadence/cdns-mhdp8501-core.c create mode 100644 drivers/gpu/drm/bridge/cadence/cdns-mhdp8501-core.h create mode 100644 drivers/gpu/drm/bridge/cadence/cdns-mhdp8501-dp.c create mode 100644 drivers/gpu/drm/bridge/cadence/cdns-mhdp8501-hdmi.c create mode 100644 drivers/phy/freescale/phy-fsl-imx8mq-dp.c create mode 100644 drivers/phy/freescale/phy-fsl-imx8mq-hdmi.c create mode 100644 include/drm/bridge/cdns-mhdp-helper.h create mode 100644 include/linux/phy/phy-hdmi.h