From patchwork Mon Jun 3 13:36:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Karolina Stolarek X-Patchwork-Id: 13683856 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A601AC25B75 for ; Mon, 3 Jun 2024 13:36:33 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1D12610E25C; Mon, 3 Jun 2024 13:36:32 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="nk8TjBLt"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7C4BB10E184 for ; Mon, 3 Jun 2024 13:36:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1717421790; x=1748957790; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=mMZVLxVittL9rIukHk0vXfJBcqdmIhCWGkq6rfl7KYw=; b=nk8TjBLtU9YLBSfkSQn+6rbDSvwiXW0oW2Ef41xd7bA2gpK2d9NTyHeY hujf2gWlV5FLVWifpWXeHBjw35WSldBn8fUoltrXbK9UmF9WOPBmKgK7Q IkAsHYpyBq2ukMFJdPZss/fE0g0sRUZc/8T76QFX/NLHFVP4uf+Bwg+Ow ez7PIuhi678QNV3ZcBWc26LbbmKCeHJ6y7Ews2JXI+W18YGcJPCn1PTbJ FjZq7FthGdH3ILbv/q9BjpCQWeqqZw5PlDAOB+hAGd67f4W7zX2hlpEGQ XQOlTtOC9SI2SGNONtSLw30RRkQflDoGptWVlbNd77utqWbIserA0BIAO A==; X-CSE-ConnectionGUID: rzT3SNDNRcKJ+P2Yk1V2yQ== X-CSE-MsgGUID: FHLpAWe3RciWUSsrqKjT7g== X-IronPort-AV: E=McAfee;i="6600,9927,11092"; a="17752501" X-IronPort-AV: E=Sophos;i="6.08,211,1712646000"; d="scan'208";a="17752501" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jun 2024 06:36:28 -0700 X-CSE-ConnectionGUID: NA+h2ZghQVuxP7KEnyP6/g== X-CSE-MsgGUID: oKILnOF0R5mnnMsQYE3yxg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,211,1712646000"; d="scan'208";a="36959969" Received: from fpallare-mobl3.ger.corp.intel.com (HELO kdrobnik-desk.toya.net.pl) ([10.245.245.157]) by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jun 2024 06:36:26 -0700 From: Karolina Stolarek To: dri-devel@lists.freedesktop.org Cc: =?utf-8?q?Christian_K=C3=B6nig?= , Matthew Auld , Amaranath Somalapuram , =?utf-8?q?Thomas_Hellstr=C3=B6m?= , Karolina Stolarek Subject: [PATCH v13 00/12] Improve test coverage of TTM Date: Mon, 3 Jun 2024 15:36:03 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Introduce tests for ttm_bo_validate()/ttm_bo_init_validate() that exercise simple BO placement as well as eviction (including the case where the evict domain also requires eviction to fit the incoming buffer). Prepare KUnit helpers to handle such scenarios and add a mock VRAM manager. This series also includes some updates to the helpers and more definitions used to define "special" memory domains (e.g., one that can't allocate resources or is busy), as well as drive-by fixes for the tests. There are a couple of areas in which this test suite can be improved. Suggestions for future work can be found in the TODO file. Use kunit_tool script to manually run all the tests: $ ./tools/testing/kunit/kunit.py run --kunitconfig=drivers/gpu/drm/ttm/tests To build a kernel with TTM KUnit tests, use a UML configuration, enable CONFIG_KUNIT, and then select CONFIG_DRM_TTM_KUNIT_TEST. Many thanks, Karolina v13 (all suggestions by Thomas): - Drop CONFIG_DRM_BUDDY=y from .kunitconfig - Remove ttm_bo_wait_ctx(bo, ctx) call from the mock move, it's not needed - Update MODULE_LICENSE descriptions (also respectively, 11/12) - Use u32 and u64 types instead uint(32|64)_t (also respectively, 12/12) - Update TODO to describe how the mock manager can be rewritten v12: - Rewrite "drm/ttm/tests: Fix a warning in ttm_bo_unreserve_bulk" patch to extend ttm_bo_kunit_init() helper to accept a dma_resv object and update calls to that helper (Christian) - Update drm_buddy_free_list() calls with an extra argument v11: - Delete CONFIG_DRM_KUNIT_TEST_HELPERS from .kunitconfig file, as it gets automatically selected when TTM KUnit tests are enabled - Call ttm_bo_put() in ttm_bo_validate_pinned() test case (Matt) - Fix a copy-paste mistake in ttm_mem_type_cases definition (Matt) - Update mock_move definition to do a hop on VRAM -> sysmem move and delete a dummy multihop domain. Fix the eviction tests accordingly (Matt) - Update ttm_bo_validate_swapout() to use TT domain instead of VRAM - Update eviction test cases to create TT domain, so they can perform multihop - Update TODO file, as it got outdated already Karolina Stolarek (12): drm/ttm/tests: Fix a warning in ttm_bo_unreserve_bulk drm/ttm/tests: Delete unnecessary config option drm/ttm/tests: Set DMA mask in KUnit device drm/ttm/tests: Use an init function from the helpers lib drm/ttm/tests: Test simple BO creation and validation drm/ttm/tests: Add tests with mock resource managers drm/ttm/tests: Add test cases dependent on fence signaling drm/ttm/tests: Add eviction testing drm/ttm/tests: Add tests for ttm_tt_populate drm/ttm/tests: Add TODO file drm/ttm/tests: Correct modules' licenses drm/ttm/tests: Use u32 and u64 over uint*_t types drivers/gpu/drm/Kconfig | 1 + drivers/gpu/drm/ttm/tests/.kunitconfig | 1 - drivers/gpu/drm/ttm/tests/Makefile | 2 + drivers/gpu/drm/ttm/tests/TODO | 27 + drivers/gpu/drm/ttm/tests/ttm_bo_test.c | 54 +- .../gpu/drm/ttm/tests/ttm_bo_validate_test.c | 1224 +++++++++++++++++ drivers/gpu/drm/ttm/tests/ttm_device_test.c | 2 +- drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 180 ++- drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h | 17 +- drivers/gpu/drm/ttm/tests/ttm_mock_manager.c | 233 ++++ drivers/gpu/drm/ttm/tests/ttm_mock_manager.h | 30 + drivers/gpu/drm/ttm/tests/ttm_pool_test.c | 8 +- drivers/gpu/drm/ttm/tests/ttm_resource_test.c | 20 +- drivers/gpu/drm/ttm/tests/ttm_tt_test.c | 168 ++- drivers/gpu/drm/ttm/ttm_tt.c | 3 + 15 files changed, 1882 insertions(+), 88 deletions(-) create mode 100644 drivers/gpu/drm/ttm/tests/TODO create mode 100644 drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c create mode 100644 drivers/gpu/drm/ttm/tests/ttm_mock_manager.c create mode 100644 drivers/gpu/drm/ttm/tests/ttm_mock_manager.h