From patchwork Thu Apr 17 10:08:40 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 4007511 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id C2E209F2CC for ; Thu, 17 Apr 2014 10:08:44 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0802220353 for ; Thu, 17 Apr 2014 10:08:44 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 2F2A72034E for ; Thu, 17 Apr 2014 10:08:43 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8CCC26E4AC; Thu, 17 Apr 2014 03:08:42 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout3.samsung.com (mailout3.samsung.com [203.254.224.33]) by gabe.freedesktop.org (Postfix) with ESMTP id 1A9466E4AC for ; Thu, 17 Apr 2014 03:08:41 -0700 (PDT) Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N4600GGS6UG3A30@mailout3.samsung.com> for dri-devel@lists.freedesktop.org; Thu, 17 Apr 2014 19:08:40 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.48]) by epcpsbgr2.samsung.com (EPCPMTA) with SMTP id E3.1A.09028.828AF435; Thu, 17 Apr 2014 19:08:40 +0900 (KST) X-AuditID: cbfee68e-b7f566d000002344-8f-534fa828c7a3 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 8F.8F.28157.828AF435; Thu, 17 Apr 2014 19:08:40 +0900 (KST) Received: from DOJG1HAN03 ([12.36.166.146]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0N46005WD6UGU810@mmp2.samsung.com>; Thu, 17 Apr 2014 19:08:40 +0900 (KST) From: Jingoo Han To: 'David Airlie' , dri-devel@lists.freedesktop.org References: <003c01cf5a24$ae1ecb90$0a5c62b0$%han@samsung.com> In-reply-to: <003c01cf5a24$ae1ecb90$0a5c62b0$%han@samsung.com> Subject: [PATCH 5/6] drm/exynos: dsi: use IS_ERR() to check devm_ioremap_resource() results Date: Thu, 17 Apr 2014 19:08:40 +0900 Message-id: <004201cf5a25$01730a40$04591ec0$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac9aJK3M+aa/fkaIQ9m2BBCdDlwGWwAAEWew Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrGIsWRmVeSWpSXmKPExsVy+t8zA12NFf7BBvdfiVr0njvJZHHl63s2 i0n3J7BYXF54idXixb2LLBZnm96wW8yY/JLNgd1j+7cHrB73u48zefRtWcUYwBzFZZOSmpNZ llqkb5fAlbHr7gT2go3sFRf+f2dqYFzM1sXIwSEhYCJx40p5FyMnkCkmceHeeqAwF4eQwDJG iYWnJzBDJEwkOh73sIDYQgLTGSUOr+CBKPrNKPFq1xNWkASbgJrEly+H2UFsEQE3iUetj1lA ipgFLjFKTD37ixmi21bi06oGsAZOATuJ+feXsIBcISwQK/HhuTpImEVAVeLny41gYV6g8oeb wap5BQQlfky+B3YDs4CWxPqdx5kgbHmJzWveMkP8oi7x6K8uxAVGEounbGSHKBGR2PfiHSPI NRIC99glnrc2s0KsEpD4NvkQC0SvrMSmA1DvSkocXHGDZQKjxCwkm2ch2TwLyeZZSFYsYGRZ xSiaWpBcUJyUXmSkV5yYW1yal66XnJ+7iRESp307GG8esD7EmAy0fiKzlGhyPjDO80riDY3N jCxMTUyNjcwtzUgTVhLnXfQwKUhIID2xJDU7NbUgtSi+qDQntfgQIxMHp1QDY0fMuhN9ScHs 5XU6sn/97C2DF85SN9xycN71IuVZTBtnpWs57WdIYHyw57tp56b397yXbVg2u39CCRe7i1hn uflXpgoJvcn+j2Kb9U19Eubd3P51ivDX6yvPGOQXtS2QX3XYos3Z7m7E/HsNKj/jo/d6Tp2x zfvf4e2sjz9ESZgmvgkynX3siRJLcUaioRZzUXEiANJdpsjpAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrCKsWRmVeSWpSXmKPExsVy+t9jQV2NFf7BBjtvCVr0njvJZHHl63s2 i0n3J7BYXF54idXixb2LLBZnm96wW8yY/JLNgd1j+7cHrB73u48zefRtWcUYwBzVwGiTkZqY klqkkJqXnJ+SmZduq+QdHO8cb2pmYKhraGlhrqSQl5ibaqvk4hOg65aZA7ReSaEsMacUKBSQ WFyspG+HaUJoiJuuBUxjhK5vSBBcj5EBGkhYx5ix6+4E9oKN7BUX/n9namBczNbFyMkhIWAi 0fG4hwXCFpO4cG89WFxIYDqjxOEVPF2MXED2b0aJV7uesIIk2ATUJL58OcwOYosIuEk8an3M AlLELHCJUWLq2V/MEN22Ep9WNYA1cArYScy/vwSoiINDWCBW4sNzdZAwi4CqxM+XG8HCvEDl DzeDVfMKCEr8mHwP7B5mAS2J9TuPM0HY8hKb17xlBimXEFCXePRXF+ICI4nFUzayQ5SISOx7 8Y5xAqPQLCSTZiGZNAvJpFlIWhYwsqxiFE0tSC4oTkrPNdIrTswtLs1L10vOz93ECE4Dz6R3 MK5qsDjEKMDBqMTDy/nbL1iINbGsuDL3EKMEB7OSCO+SXv9gId6UxMqq1KL8+KLSnNTiQ4zJ QH9OZJYSTc4Hpqi8knhDYxMzI0sjMwsjE3Nz0oSVxHkPtloHCgmkJ5akZqemFqQWwWxh4uCU amD0FpjdVs4/IUn7dvfd1aXypzRUZjfbXn80ZWm+7Lw0Hs/SpJdFh9r9Xjln26w5183Pq60i tn2t4YkLGi2n5e8eNz2ve+PdkwurV67bJVf7JGJ64tO4I3LK/S5nehqmH3c45NIiHC/7O85g 0WwZ/uh1G/+prZ1qxC14hePEr/m/1tWVlnayV+kpsRRnJBpqMRcVJwIAA7spyEcDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Cc: 'Kyungmin Park' , 'Seung-Woo Kim' X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP devm_ioremap_resource() retunrs an error pointer, not NULL. Thus, the result should be checked with IS_ERR(). Signed-off-by: Jingoo Han --- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c index ae81124..84661fe 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c @@ -1465,9 +1465,9 @@ static int exynos_dsi_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); dsi->reg_base = devm_ioremap_resource(&pdev->dev, res); - if (!dsi->reg_base) { + if (IS_ERR(dsi->reg_base)) { dev_err(&pdev->dev, "failed to remap io region\n"); - return -EADDRNOTAVAIL; + return PTR_ERR(dsi->reg_base); } dsi->phy = devm_phy_get(&pdev->dev, "dsim");