From patchwork Wed Sep 21 16:46:36 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 9343889 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7E7036077A for ; Wed, 21 Sep 2016 16:46:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7E3FE2A6BB for ; Wed, 21 Sep 2016 16:46:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 727762A766; Wed, 21 Sep 2016 16:46:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id E03FE2A6BB for ; Wed, 21 Sep 2016 16:46:44 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E97E76E0FF; Wed, 21 Sep 2016 16:46:43 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mout.web.de (mout.web.de [212.227.15.4]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9923A6E0FF for ; Wed, 21 Sep 2016 16:46:42 +0000 (UTC) Received: from [192.168.1.2] ([77.182.212.253]) by smtp.web.de (mrweb004) with ESMTPSA (Nemesis) id 0LdrkJ-1b4JEF3Epf-00j2wA; Wed, 21 Sep 2016 18:46:36 +0200 Subject: [PATCH 05/14] GPU-DRM-OMAP: Improve a size determination in dmm_txn_append() To: dri-devel@lists.freedesktop.org, David Airlie , Laurent Pinchart , Tomi Valkeinen References: <566ABCD9.1060404@users.sourceforge.net> <0ea38611-3d93-0ade-a1fb-f8cc2e0b8d61@users.sourceforge.net> From: SF Markus Elfring Message-ID: <04c409d1-cca5-1774-e9c6-6b4d8a36dfee@users.sourceforge.net> Date: Wed, 21 Sep 2016 18:46:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <0ea38611-3d93-0ade-a1fb-f8cc2e0b8d61@users.sourceforge.net> X-Provags-ID: V03:K0:kfOcROHnhqXq+l1i5MDbwEmQzx5xjliw2OmErQgDeVq3fuj2bh7 jYwHzbWTgnC3EBPDENvazhd1s3qFHfw6lr3NitOhgynRGrVsRBtIlfFtiXCILkl08Vf9zaR 15Smw1v2z1kqfKAIfWhLu6Wvm1hHXWQiM4VRIUk7tQ2hqbChkkPL8woCd2TsT4y81dsUlpJ snkbDMmPKa1YurFRDlWFw== X-UI-Out-Filterresults: notjunk:1; V01:K0:4s+fOvIEB34=:hsGdMAAI2ZhBbau7Ki5Pp9 OsdWJ9dAy1NwLf1VcmNCJds4KBuTFjj+yTt9gtV3eM+SBg6dfy8btzf/ILE5P4JXxpSndJRoc b2sCNINGi/W+vyK2ChmMQMWBEfKSvcFMirXS3db5+bqHsIEdIUl5J8NFKdvSMAkbbvTVB/MGW dRCf2BEwgBLPZp00HZFb56otvE9PPGFDlLBGH6kfJLKJ11qLg6feJH1S8jhtHX29ijzRjCd/j C5Zin7V1J4SN/lVMxC8gWIf4U1dQ6ArdC+83Y24ByD7kWlv076bOQHBKVVPFQxxXrYD8AoMMW QnrjWs53PBgTvwlBprFiAD/gAtiD3eK/xV+wAkvMmESwBQ+cAmgdJT48HQtJO+srEbU7Dlr8f f1YG1eU0XX50dzt8HDjhFjqCGKLp50hahg/EmOapjOLtZdR+3XyfaSP51gLU3T6YRlb8HkowA +WOAlGHydAd0HaSP1DeSG20X6Lt3oV8VRAh69ziyNnHqVfR7TA2xMqn2kkqUMe+5Gj2oEQK3M QSyXRWbsQmaD1iO7TsTVefEIP1lpNkHkPBx1yz/5LJdcCJJxbf66EmrqfJVcS92zgYOFu8kZc VB3W1nkDx8dcqXE3e1I8fhb4/xqmKPkeOYxH1Kxl9bj0tZfhfF8mxHddeOHr1rOqAgg9MdZcD ADObZH9s64PWUZyxZXUADIrkumdSIVgtS52N1CR1UWfc9xvDRVkJlJVRkB0+/HMTChtF5CDHW H0CWvm+6VBJOGUqazLlj86Rm9jJ+ZUFQRuP26mdd6T425DIums3ViQGB4QAs1Gkv/dk2qzbOF 63aTPoS Cc: Julia Lawall , kernel-janitors@vger.kernel.org, LKML X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Markus Elfring Date: Wed, 21 Sep 2016 13:53:11 +0200 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c index c262ef5..f110965 100644 --- a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c +++ b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c @@ -224,7 +224,7 @@ static void dmm_txn_append(struct dmm_txn *txn, struct pat_area *area, int rows = (1 + area->y1 - area->y0); int i = columns*rows; - pat = alloc_dma(txn, sizeof(struct pat), &pat_pa); + pat = alloc_dma(txn, sizeof(*pat), &pat_pa); if (txn->last_pat) txn->last_pat->next_pa = (uint32_t)pat_pa;