| Message ID | 077964b92af5c0fdf6a8e6767ef8dfccfe4c008f.1551303673.git.jsarha@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/bridge: sii902x: HDMI-audio support and some fixes | expand |
On 27.02.2019 22:54, Jyri Sarha wrote: > "drm/bridge/sii902x: Fix EDID readback"-commit added a dependency to > I2C_MUX, but not indicate it in the Kconfig entry. Fix it by selecting > I2C_MUX for DRM_SII902X config option. > > Fixes: 88664675239 ("drm/bridge/sii902x: Fix EDID readback") > Signed-off-by: Jyri Sarha <jsarha@ti.com> Reviewed-by: Andrzej Hajda <a.hajda@samsung.com> -- Regards Andrzej > --- > drivers/gpu/drm/bridge/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig > index fb0b37918382..a6f6ff8f06b3 100644 > --- a/drivers/gpu/drm/bridge/Kconfig > +++ b/drivers/gpu/drm/bridge/Kconfig > @@ -95,6 +95,7 @@ config DRM_SII902X > depends on OF > select DRM_KMS_HELPER > select REGMAP_I2C > + select I2C_MUX > ---help--- > Silicon Image sii902x bridge chip driver. >
Hi Jyri, Thank you for the patch. On Wed, Feb 27, 2019 at 11:54:22PM +0200, Jyri Sarha wrote: > "drm/bridge/sii902x: Fix EDID readback"-commit added a dependency to > I2C_MUX, but not indicate it in the Kconfig entry. Fix it by selecting > I2C_MUX for DRM_SII902X config option. > > Fixes: 88664675239 ("drm/bridge/sii902x: Fix EDID readback") > Signed-off-by: Jyri Sarha <jsarha@ti.com> > --- > drivers/gpu/drm/bridge/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig > index fb0b37918382..a6f6ff8f06b3 100644 > --- a/drivers/gpu/drm/bridge/Kconfig > +++ b/drivers/gpu/drm/bridge/Kconfig > @@ -95,6 +95,7 @@ config DRM_SII902X > depends on OF > select DRM_KMS_HELPER > select REGMAP_I2C > + select I2C_MUX > ---help--- > Silicon Image sii902x bridge chip driver. > This is already present in v5.0. commit ea6b13e9fed0fda9532ee04d38ed1bef1edbfdbf Author: Fabrizio Castro <fabrizio.castro@bp.renesas.com> Date: Mon Nov 19 13:26:18 2018 +0000 drm/bridge/sii902x: Add missing dependency on I2C_MUX Fabrizio stated in the commit message that "Quite obviously the driver depends on I2C_MUX, but adding a "depends on" introduces a recursive dependency, therefore this patch selects I2C_MUX instead.". Given that I2C_MUX is a tristate user-selectable option, "depend on" should be the right solution. I wonder if we could fix the root cause of the recursive dependency.
diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig index fb0b37918382..a6f6ff8f06b3 100644 --- a/drivers/gpu/drm/bridge/Kconfig +++ b/drivers/gpu/drm/bridge/Kconfig @@ -95,6 +95,7 @@ config DRM_SII902X depends on OF select DRM_KMS_HELPER select REGMAP_I2C + select I2C_MUX ---help--- Silicon Image sii902x bridge chip driver.
"drm/bridge/sii902x: Fix EDID readback"-commit added a dependency to I2C_MUX, but not indicate it in the Kconfig entry. Fix it by selecting I2C_MUX for DRM_SII902X config option. Fixes: 88664675239 ("drm/bridge/sii902x: Fix EDID readback") Signed-off-by: Jyri Sarha <jsarha@ti.com> --- drivers/gpu/drm/bridge/Kconfig | 1 + 1 file changed, 1 insertion(+)