From patchwork Mon Jun 6 00:32:12 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Dietsche X-Patchwork-Id: 853252 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by demeter2.kernel.org (8.14.4/8.14.3) with ESMTP id p56IwGXD004659 for ; Mon, 6 Jun 2011 18:58:38 GMT Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 746659E7F1 for ; Mon, 6 Jun 2011 11:58:16 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Mon, 06 Jun 2011 18:58:38 +0000 (UTC) X-Greylist: delayed 1214 seconds by postgrey-1.31 at gabe; Sun, 05 Jun 2011 17:54:06 PDT Received: from que21.charter.net (que21.charter.net [209.225.8.22]) by gabe.freedesktop.org (Postfix) with ESMTP id E4F2F9E81C for ; Sun, 5 Jun 2011 17:54:06 -0700 (PDT) Received: from imp11 ([10.20.200.11]) by mta31.charter.net (InterMail vM.7.09.02.04 201-2219-117-106-20090629) with ESMTP id <20110606003220.UVXH7341.mta31.charter.net@imp11>; Sun, 5 Jun 2011 20:32:20 -0400 Received: from www.farmergreg.com ([96.42.32.177]) by imp11 with smtp.charter.net id sQYL1g00C3pHlLY05QYLGf; Sun, 05 Jun 2011 20:32:20 -0400 X-Authority-Analysis: v=1.1 cv=vT9vkN3vVXssH3Ov7r/wQUs/sfIFjNPEFFf4aeKIi4A= c=1 sm=1 a=b_ZAEtL4iiMA:10 a=lDGNyK2vIvEA:10 a=xzrYXqw+0zwiO4gHSXHcAg==:17 a=Zh0XGXoQGCX4B2KpgjUA:9 a=xzrYXqw+0zwiO4gHSXHcAg==:117 Received: from red.farmergreg.com ([10.0.0.128]) by www.farmergreg.com with esmtp (Exim 4.72) (envelope-from ) id 1QTNju-00060q-Ay; Sun, 05 Jun 2011 19:32:18 -0500 Received: from greg by red.farmergreg.com with local (Exim 4.72) (envelope-from ) id 1QTNjv-0008BP-Uh; Sun, 05 Jun 2011 19:32:19 -0500 From: Greg Dietsche To: airlied@linux.ie Subject: [PATCH] savage: remove unecessary if statement Date: Sun, 5 Jun 2011 19:32:12 -0500 Message-Id: <1307320332-31429-1-git-send-email-Gregory.Dietsche@cuw.edu> X-Mailer: git-send-email 1.7.2.5 X-Mailman-Approved-At: Mon, 06 Jun 2011 11:56:56 -0700 Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Greg Dietsche X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org the code always returns ret regardless, so if(ret) check is unecessary. Signed-off-by: Greg Dietsche --- drivers/gpu/drm/savage/savage_bci.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/savage/savage_bci.c b/drivers/gpu/drm/savage/savage_bci.c index bf5f83e..cb1ee4e 100644 --- a/drivers/gpu/drm/savage/savage_bci.c +++ b/drivers/gpu/drm/savage/savage_bci.c @@ -647,9 +647,6 @@ int savage_driver_firstopen(struct drm_device *dev) ret = drm_addmap(dev, aperture_base, SAVAGE_APERTURE_SIZE, _DRM_FRAME_BUFFER, _DRM_WRITE_COMBINING, &dev_priv->aperture); - if (ret) - return ret; - return ret; }