From patchwork Thu Aug 4 05:41:00 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joonyoung Shim X-Patchwork-Id: 1033892 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by demeter2.kernel.org (8.14.4/8.14.4) with ESMTP id p745c7O9016317 for ; Thu, 4 Aug 2011 05:38:28 GMT Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A43209E93C for ; Wed, 3 Aug 2011 22:38:07 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout3.samsung.com (mailout3.samsung.com [203.254.224.33]) by gabe.freedesktop.org (Postfix) with ESMTP id 2044C9E9AC for ; Wed, 3 Aug 2011 22:37:11 -0700 (PDT) Received: from epcpsbgm2.samsung.com (mailout3.samsung.com [203.254.224.33]) by mailout3.samsung.com (Oracle Communications Messaging Exchange Server 7u4-19.01 64bit (built Sep 7 2010)) with ESMTP id <0LPE00D7T283EG40@mailout3.samsung.com> for dri-devel@lists.freedesktop.org; Thu, 04 Aug 2011 14:37:10 +0900 (KST) X-AuditID: cbfee61b-b7c3dae000002cb8-c9-4e3a30061698 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (MMPCPMTA) with SMTP id 59.A4.11448.6003A3E4; Thu, 04 Aug 2011 14:37:10 +0900 (KST) Received: from TNRNDGASPAPP1.tn.corp.samsungelectronics.net ([165.213.149.150]) by mmp2.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTPA id <0LPE008MF29Y6L@mmp2.samsung.com> for dri-devel@lists.freedesktop.org; Thu, 04 Aug 2011 14:37:10 +0900 (KST) Received: from dofmind-linux ([165.213.219.123]) by TNRNDGASPAPP1.tn.corp.samsungelectronics.net with Microsoft SMTPSVC(6.0.3790.4675); Thu, 04 Aug 2011 14:37:12 +0900 Date: Thu, 04 Aug 2011 14:41:00 +0900 From: Joonyoung Shim Subject: [PATCH 1/2] drm: Fix irq install error handling To: dri-devel@lists.freedesktop.org Message-id: <1312436461-7972-1-git-send-email-jy0922.shim@samsung.com> X-Mailer: git-send-email 1.7.1 X-OriginalArrivalTime: 04 Aug 2011 05:37:12.0647 (UTC) FILETIME=[8F9DED70:01CC5268] X-Brightmail-Tracker: AAAAAA== Cc: kyungmin.park@samsung.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Thu, 04 Aug 2011 05:38:28 +0000 (UTC) The registered irq should be unregistered by free_irq() if irq_postinstall() returns the error after request_irq() is called successfully. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/drm_irq.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c index 2022a5c..7497c89 100644 --- a/drivers/gpu/drm/drm_irq.c +++ b/drivers/gpu/drm/drm_irq.c @@ -368,6 +368,7 @@ int drm_irq_install(struct drm_device *dev) mutex_lock(&dev->struct_mutex); dev->irq_enabled = 0; mutex_unlock(&dev->struct_mutex); + free_irq(drm_dev_to_irq(dev), dev); } return ret;