| Message ID | 1343737385-23337-3-git-send-email-l.krishna@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hello. On 31-07-2012 16:23, Leela Krishna Amudala wrote: > Exynos5 has VIDTCON and VIDCON registers at different offsets > from the previous SOCs. Hence, adding the macros. > Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com> > --- > include/video/samsung_fimd.h | 7 +++++++ > 1 files changed, 7 insertions(+), 0 deletions(-) > diff --git a/include/video/samsung_fimd.h b/include/video/samsung_fimd.h > index e979f42..820f190 100644 > --- a/include/video/samsung_fimd.h > +++ b/include/video/samsung_fimd.h > @@ -524,3 +524,10 @@ > * 1110 -none- -none- -none- -none- -none- > * 1111 -none- -none- -none- -none- -none- > */ > + > +/*EXYNOS5 FIMD REG OFFSET */ > +#define EXYNOS5_VIDTCON0 (0x20010) > +#define EXYNOS5_VIDTCON1 (0x20014) > +#define EXYNOS5_VIDTCON2 (0x20018) > +#define EXYNOS5_VIDTCON3 (0x2001C) > +#define EXYNOS5_VIDCON1 (0x20004) Parens not needed around simple literals. WBR, Sergei
On Tuesday, July 31, 2012 9:23 PM Leela Krishna Amudala wrote: > > Exynos5 has VIDTCON and VIDCON registers at different offsets > from the previous SOCs. Hence, adding the macros. > > Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com> > --- > include/video/samsung_fimd.h | 7 +++++++ > 1 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/include/video/samsung_fimd.h b/include/video/samsung_fimd.h > index e979f42..820f190 100644 > --- a/include/video/samsung_fimd.h > +++ b/include/video/samsung_fimd.h > @@ -524,3 +524,10 @@ > * 1110 -none- -none- -none- -none- -none- > * 1111 -none- -none- -none- -none- -none- > */ > + > +/*EXYNOS5 FIMD REG OFFSET */ ^ Please insert one space between '/*' and 'EXYNOS5'. As Sylwester Nawrocki mentioned, the following seems to be better. /* EXYNOS5 specific register offset definitions */ Best regards, Jingoo Han > +#define EXYNOS5_VIDTCON0 (0x20010) > +#define EXYNOS5_VIDTCON1 (0x20014) > +#define EXYNOS5_VIDTCON2 (0x20018) > +#define EXYNOS5_VIDTCON3 (0x2001C) > +#define EXYNOS5_VIDCON1 (0x20004) > -- > 1.7.0.4
Leela Krishna Amudala wrote: > > Exynos5 has VIDTCON and VIDCON registers at different offsets > from the previous SOCs. Hence, adding the macros. > > Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com> > --- > include/video/samsung_fimd.h | 7 +++++++ > 1 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/include/video/samsung_fimd.h b/include/video/samsung_fimd.h > index e979f42..820f190 100644 > --- a/include/video/samsung_fimd.h > +++ b/include/video/samsung_fimd.h > @@ -524,3 +524,10 @@ > * 1110 -none- -none- -none- -none- -none- > * 1111 -none- -none- -none- -none- -none- > */ > + > +/*EXYNOS5 FIMD REG OFFSET */ > +#define EXYNOS5_VIDTCON0 (0x20010) > +#define EXYNOS5_VIDTCON1 (0x20014) > +#define EXYNOS5_VIDTCON2 (0x20018) > +#define EXYNOS5_VIDTCON3 (0x2001C) > +#define EXYNOS5_VIDCON1 (0x20004) > -- > 1.7.0.4 All of EXYNOS5 SoCs including upcoming SoCs _really_ have same address like above? I don't think so. You need to consider its flexibility or some compatibility when definitions are added. Thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.
diff --git a/include/video/samsung_fimd.h b/include/video/samsung_fimd.h index e979f42..820f190 100644 --- a/include/video/samsung_fimd.h +++ b/include/video/samsung_fimd.h @@ -524,3 +524,10 @@ * 1110 -none- -none- -none- -none- -none- * 1111 -none- -none- -none- -none- -none- */ + +/*EXYNOS5 FIMD REG OFFSET */ +#define EXYNOS5_VIDTCON0 (0x20010) +#define EXYNOS5_VIDTCON1 (0x20014) +#define EXYNOS5_VIDTCON2 (0x20018) +#define EXYNOS5_VIDTCON3 (0x2001C) +#define EXYNOS5_VIDCON1 (0x20004)
Exynos5 has VIDTCON and VIDCON registers at different offsets from the previous SOCs. Hence, adding the macros. Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com> --- include/video/samsung_fimd.h | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-)