From patchwork Wed Aug 15 14:31:07 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Paul Menzel X-Patchwork-Id: 1325871 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by patchwork1.kernel.org (Postfix) with ESMTP id 577CF3FD8C for ; Wed, 15 Aug 2012 14:31:33 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 181C29F4BA for ; Wed, 15 Aug 2012 07:31:32 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail.gw90.de (mail.gw90.de [188.40.100.199]) by gabe.freedesktop.org (Postfix) with ESMTP id A52819E925 for ; Wed, 15 Aug 2012 07:31:17 -0700 (PDT) Received: from e178248075.adsl.alicedsl.de ([85.178.248.75] helo=[192.168.178.20]) by mail.gw90.de with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1T1ect-0001vZ-1e; Wed, 15 Aug 2012 14:31:15 +0000 Message-ID: <1345041067.4264.16.camel@mattotaupa> Subject: [PATCH] drm: Add EDID_QUIRK_FORCE_REDUCED_BLANKING for Philips 32PFL5404H From: Paul Menzel To: dri-devel@lists.freedesktop.org Date: Wed, 15 Aug 2012 16:31:07 +0200 X-Mailer: Evolution 3.2.2-1+b1 Mime-Version: 1.0 Cc: Ian Pilcher , stable@vger.kernel.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Date: Wed, 8 Aug 2012 23:12:19 +0200 < ajax> i would preface this whole discussion with the observation that all tvs are garbage Connecting the Philips 32PFL5404H [1] a garbled screen is shown with vertical stripes in the top half. As written in the referenced Bugzilla #26294 report I am pretty sure this worked sometime before 2010. My guess is that EDID beforehand was interpreted incorrectly – as probably MS Windows does – which made it work. In commit bc42aabc [2] commit bc42aabc6a01b92b0f961d65671564e0e1cd7592 Author: Adam Jackson Date: Wed May 23 16:26:54 2012 -0400 drm/edid/quirks: ViewSonic VA2026w Adam Jackson added the quirk `EDID_QUIRK_FORCE_REDUCED_BLANKING` which is also needed for this Philips TV. The problem is that the Model number is set to zero. I hope this will not break other Philips TVs out there. All log files and output from `xrandr` is included in the referenced Bugzilla report #26294. [1] http://www.p4c.philips.com/cgi-bin/dcbint/cpindex.pl?ctn=32PFL5404H/12&scy=DE&slg=de [2] http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commit;h=bc42aabc6a01b92b0f961d65671564e0e1cd7592 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=26294 Tested-by: Paul Menzel (ASUS Eee PC 701 4G with Debian Sid/unstable connected over VGA) Signed-off-by: Paul Menzel Cc: Cc: Adam Jackson Cc: Ian Pilcher Cc: --- Ian, I did not base this patch on your series, to make it easier to get back ported. I can easily rebase it though, so hopefully some maintainer can tell me what to do. I also do not know if URLs in the quirk comments are considered useful or not. --- drivers/gpu/drm/drm_edid.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index a8743c3..eb452e6 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -111,6 +111,11 @@ static struct edid_quirk { { "LPL", 0, EDID_QUIRK_DETAILED_USE_MAXIMUM_SIZE }, { "LPL", 0x2a00, EDID_QUIRK_DETAILED_USE_MAXIMUM_SIZE }, + /* Philips 32PFL5404H TV */ + /* http://www.p4c.philips.com/cgi-bin/dcbint/cpindex.pl?ctn=32PFL5404H/12&scy=DE&slg=de */ + /* https://bugs.freedesktop.org/show_bug.cgi?id=26294 */ + { "PHL", 0, EDID_QUIRK_FORCE_REDUCED_BLANKING }, + /* Philips 107p5 CRT */ { "PHL", 57364, EDID_QUIRK_FIRST_DETAILED_PREFERRED },