From patchwork Fri Aug 17 09:50:50 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Inki Dae X-Patchwork-Id: 1338261 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by patchwork1.kernel.org (Postfix) with ESMTP id 7A1E63FC71 for ; Fri, 17 Aug 2012 09:54:46 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5E5A4A0E2E for ; Fri, 17 Aug 2012 02:54:46 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout4.samsung.com (mailout4.samsung.com [203.254.224.34]) by gabe.freedesktop.org (Postfix) with ESMTP id E12AEA0909 for ; Fri, 17 Aug 2012 02:51:03 -0700 (PDT) Received: from epcpsbgm2.samsung.com (mailout4.samsung.com [203.254.224.34]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0M8W00BBS8OHZZ00@mailout4.samsung.com> for dri-devel@lists.freedesktop.org; Fri, 17 Aug 2012 18:51:01 +0900 (KST) X-AuditID: cbfee61b-b7faf6d00000476a-d3-502e14054d61 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 51.6E.18282.5041E205; Fri, 17 Aug 2012 18:51:01 +0900 (KST) Received: from daeinki-desktop.10.32.193.11 ([10.90.51.53]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0M8W005HH8OZZTB0@mmp2.samsung.com> for dri-devel@lists.freedesktop.org; Fri, 17 Aug 2012 18:51:01 +0900 (KST) From: Inki Dae To: airlied@linux.ie, dri-devel@lists.freedesktop.org Subject: [PATCH 04/13] drm/exynos: use empty function instead of drm_helper_connector_dpms Date: Fri, 17 Aug 2012 18:50:50 +0900 Message-id: <1345197059-25583-5-git-send-email-inki.dae@samsung.com> X-Mailer: git-send-email 1.7.4.1 In-reply-to: <1345197059-25583-1-git-send-email-inki.dae@samsung.com> References: <1345197059-25583-1-git-send-email-inki.dae@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrMJMWRmVeSWpSXmKPExsVy+t9jQV1WEb0Agxm31CyufH3P5sDocb/7 OFMAYxSXTUpqTmZZapG+XQJXxtnbjcwFh7grzi34xtTA+Jmzi5GTQ0LARGJuw3YmCFtM4sK9 9WxdjFwcQgLTGSW+/VnDCOGsZ5LYu/QyC0gVm4CqxMQV99lAbBEBU4mOSUvB4swChRILe56C 2cICMRIX51xkB7FZgOoPzzrPCGLzCrhI3Fh1nAVim4LEgntvweZwCrhK3F0+GewKIaCaxs09 rBMYeRcwMqxiFE0tSC4oTkrPNdIrTswtLs1L10vOz93ECPb6M+kdjKsaLA4xCnAwKvHwHijT DRBiTSwrrsw9xCjBwawkwrviI1CINyWxsiq1KD++qDQntfgQozQHi5I4r9d/oJRAemJJanZq akFqEUyWiYNTqoGR15z1jbCu4/RLLxUcJ8ocnP5/jejqb7alK8s7voVcyeyVK8hlfrOMZ8UL r8uypkJqS0pWu/jHTPKqErn30+S427qm1ccDf95+sEzEcN/XpLq51XdOewTO9n/CXbA+p+j0 5PTak8FsO70kBA69E1xk4+ttm36pv2VGjPO/qK9nphwuFVw72/qzEktxRqKhFnNRcSIADT7G TfYBAAA= X-TM-AS-MML: No Cc: kyungmin.park@samsung.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org crtc and encoder's dpms callback will be called before connector's dpms is called so drm_helper_connector_dpms doesn't need to be called. Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_connector.c | 9 ++++++++- 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_connector.c b/drivers/gpu/drm/exynos/exynos_drm_connector.c index d956819..65acf0d 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_connector.c +++ b/drivers/gpu/drm/exynos/exynos_drm_connector.c @@ -226,6 +226,13 @@ static struct drm_connector_helper_funcs exynos_connector_helper_funcs = { .best_encoder = exynos_drm_best_encoder, }; +static void exynos_drm_connector_dpms(struct drm_connector *connector, int mode) +{ + DRM_DEBUG_KMS("%s\n", __FILE__); + + /* drm framework doesn't check NULL. */ +} + static int exynos_drm_connector_fill_modes(struct drm_connector *connector, unsigned int max_width, unsigned int max_height) { @@ -285,7 +292,7 @@ static void exynos_drm_connector_destroy(struct drm_connector *connector) } static struct drm_connector_funcs exynos_connector_funcs = { - .dpms = drm_helper_connector_dpms, + .dpms = exynos_drm_connector_dpms, .fill_modes = exynos_drm_connector_fill_modes, .detect = exynos_drm_connector_detect, .destroy = exynos_drm_connector_destroy,