| Message ID | 1345641813-10070-2-git-send-email-s.shirish@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Aug 22, 2012 at 06:53:33PM +0530, Shirish S wrote: > From: Shirish Shankarappa <s.shirish@samsung.com> > > The value of MAX_EDID is now valid only for 2 > block EDID data which is 256, but to support > 4 block EDID (E-DDC) this needs to be 512. > > Signed-off-by: Shirish Shankarappa <s.shirish@samsung.com> > --- > drivers/gpu/drm/exynos/exynos_drm_connector.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_connector.c b/drivers/gpu/drm/exynos/exynos_drm_connector.c > index d956819..69d02b5 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_connector.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_connector.c > @@ -32,7 +32,7 @@ > #include "exynos_drm_drv.h" > #include "exynos_drm_encoder.h" > > -#define MAX_EDID 256 > +#define MAX_EDID 512 > #define to_exynos_connector(x) container_of(x, struct exynos_drm_connector,\ > drm_connector) Shouldn't this be in a common drm/edid header to begin with? -Daniel
Hi Daniel, On 2012? 08? 23? 17:50, Daniel Vetter wrote: > On Wed, Aug 22, 2012 at 06:53:33PM +0530, Shirish S wrote: >> From: Shirish Shankarappa <s.shirish@samsung.com> >> >> The value of MAX_EDID is now valid only for 2 >> block EDID data which is 256, but to support >> 4 block EDID (E-DDC) this needs to be 512. >> >> Signed-off-by: Shirish Shankarappa <s.shirish@samsung.com> >> --- >> drivers/gpu/drm/exynos/exynos_drm_connector.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/gpu/drm/exynos/exynos_drm_connector.c b/drivers/gpu/drm/exynos/exynos_drm_connector.c >> index d956819..69d02b5 100644 >> --- a/drivers/gpu/drm/exynos/exynos_drm_connector.c >> +++ b/drivers/gpu/drm/exynos/exynos_drm_connector.c >> @@ -32,7 +32,7 @@ >> #include "exynos_drm_drv.h" >> #include "exynos_drm_encoder.h" >> >> -#define MAX_EDID 256 >> +#define MAX_EDID 512 >> #define to_exynos_connector(x) container_of(x, struct exynos_drm_connector,\ >> drm_connector) > > Shouldn't this be in a common drm/edid header to begin with? This value is not real maximum length of EDID and it is only used for memory allocation by exynos connector. Actually, this allocation is unnecessary because edid is already allocated by drm_get_edid(). So, I have plan to remove this allocation and the definition once Jani Nikula's patches for removing raw_edid related memory leaks are applied. > -Daniel > Thanks and Regards, - Seung-Woo Kim
Hello, On Thu, Aug 23, 2012 at 2:52 AM, ??? <sw0312.kim@samsung.com> wrote: > Hi Daniel, > > On 2012? 08? 23? 17:50, Daniel Vetter wrote: > > On Wed, Aug 22, 2012 at 06:53:33PM +0530, Shirish S wrote: > >> From: Shirish Shankarappa <s.shirish@samsung.com> > >> > >> The value of MAX_EDID is now valid only for 2 > >> block EDID data which is 256, but to support > >> 4 block EDID (E-DDC) this needs to be 512. > >> > >> Signed-off-by: Shirish Shankarappa <s.shirish@samsung.com> > >> --- > >> drivers/gpu/drm/exynos/exynos_drm_connector.c | 2 +- > >> 1 files changed, 1 insertions(+), 1 deletions(-) > >> > >> diff --git a/drivers/gpu/drm/exynos/exynos_drm_connector.c > b/drivers/gpu/drm/exynos/exynos_drm_connector.c > >> index d956819..69d02b5 100644 > >> --- a/drivers/gpu/drm/exynos/exynos_drm_connector.c > >> +++ b/drivers/gpu/drm/exynos/exynos_drm_connector.c > >> @@ -32,7 +32,7 @@ > >> #include "exynos_drm_drv.h" > >> #include "exynos_drm_encoder.h" > >> > >> -#define MAX_EDID 256 > >> +#define MAX_EDID 512 > >> #define to_exynos_connector(x) container_of(x, struct > exynos_drm_connector,\ > >> drm_connector) > > > > Shouldn't this be in a common drm/edid header to begin with? > > This value is not real maximum length of EDID and it is only used for > memory allocation by exynos connector. Actually, this allocation is > unnecessary because edid is already allocated by drm_get_edid(). > > So, I have plan to remove this allocation and the definition once Jani > Nikula's patches for removing raw_edid related memory leaks are applied. > > I was not aware of your plans to remove it, anyways for verifying the patch for 4 block EDID data, this modification is required,hence i thought of posting this patch. > > -Daniel > > > > Thanks and Regards, > - Seung-Woo Kim > > > -- > Seung-Woo Kim > Samsung Software R&D Center > -- > > Thanks& Regards, Shirish S > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel >
diff --git a/drivers/gpu/drm/exynos/exynos_drm_connector.c b/drivers/gpu/drm/exynos/exynos_drm_connector.c index d956819..69d02b5 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_connector.c +++ b/drivers/gpu/drm/exynos/exynos_drm_connector.c @@ -32,7 +32,7 @@ #include "exynos_drm_drv.h" #include "exynos_drm_encoder.h" -#define MAX_EDID 256 +#define MAX_EDID 512 #define to_exynos_connector(x) container_of(x, struct exynos_drm_connector,\ drm_connector)