From patchwork Fri Sep 14 04:29:34 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Inki Dae X-Patchwork-Id: 1455341 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by patchwork2.kernel.org (Postfix) with ESMTP id 0489EDF280 for ; Fri, 14 Sep 2012 04:30:47 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D63BFA0F34 for ; Thu, 13 Sep 2012 21:30:46 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 90B80A0F0B for ; Thu, 13 Sep 2012 21:29:36 -0700 (PDT) Received: from epcpsbgm1.samsung.com (epcpsbgm1 [203.254.230.26]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MAB00MR5OGTOPJ0@mailout1.samsung.com> for dri-devel@lists.freedesktop.org; Fri, 14 Sep 2012 13:29:35 +0900 (KST) X-AuditID: cbfee61a-b7fb46d00000656d-5e-5052b2af844e Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 9A.F8.25965.FA2B2505; Fri, 14 Sep 2012 13:29:35 +0900 (KST) Received: from daeinki-desktop.10.32.193.11 ([10.90.51.53]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MAB00974OHA6G50@mmp1.samsung.com> for dri-devel@lists.freedesktop.org; Fri, 14 Sep 2012 13:29:35 +0900 (KST) From: Inki Dae To: airlied@linux.ie, dri-devel@lists.freedesktop.org Subject: [PATCH 2/4] drm/exynos: fix duplicated mutex lock issue Date: Fri, 14 Sep 2012 13:29:34 +0900 Message-id: <1347596974-12511-1-git-send-email-inki.dae@samsung.com> X-Mailer: git-send-email 1.7.4.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrFJMWRmVeSWpSXmKPExsVy+t9jAd31m4ICDF594rW48vU9mwOjx/3u 40wBjFFcNimpOZllqUX6dglcGafXTmUqmMBVsXrDdNYGxjMcXYycHBICJhKH/61mhrDFJC7c W88GYgsJLGKU+Hksq4uRC8hezyQxtXE5WIJNQFVi4or7YLaIgKlEx6SlLCA2s0ChxMKep2C2 sICDxPdJj5lAbBag+j0dvxlBbF4BF4lfk19DLVOQWHDvLdsERu4FjAyrGEVTC5ILipPScw31 ihNzi0vz0vWS83M3MYJ9+ExqB+PKBotDjAIcjEo8vAk8QQFCrIllxZW5hxglOJiVRHhttYFC vCmJlVWpRfnxRaU5qcWHGKU5WJTEeYU/BQYICaQnlqRmp6YWpBbBZJk4OKUaGBUPXPUqt4+N 4Xj2Wveasbn+6cLsbl9W1VkXXu52tZz77t5SxQO/5imdrt++RHNH3kTBdWKcb3dFml0S6SyU lOQN+99YumQLt1Hutt2RvTdErrLyTPoQpZZ8+P/DDPGZqmmc30Pq5lg4RN24sKiooUjNRMGO 9b/KkYXVDO3ytw9a7D+UfMcmR4mlOCPRUIu5qDgRAAXU7vXdAQAA Cc: kyungmin.park@samsung.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org exynos_drm_crtc_dpms function doesn't need mutex lock because mutex lock was called by drm framework so this patch removes mutex lock call from that function to avoid duplicated mutex locking. Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_crtc.c | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_crtc.c b/drivers/gpu/drm/exynos/exynos_drm_crtc.c index b612bf5..8bd4d7e 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_crtc.c +++ b/drivers/gpu/drm/exynos/exynos_drm_crtc.c @@ -66,7 +66,6 @@ struct exynos_drm_crtc { static void exynos_drm_crtc_dpms(struct drm_crtc *crtc, int mode) { - struct drm_device *dev = crtc->dev; struct exynos_drm_crtc *exynos_crtc = to_exynos_crtc(crtc); DRM_DEBUG_KMS("crtc[%d] mode[%d]\n", crtc->base.id, mode); @@ -76,12 +75,8 @@ static void exynos_drm_crtc_dpms(struct drm_crtc *crtc, int mode) return; } - mutex_lock(&dev->struct_mutex); - exynos_drm_fn_encoder(crtc, &mode, exynos_drm_encoder_crtc_dpms); exynos_crtc->dpms = mode; - - mutex_unlock(&dev->struct_mutex); } static void exynos_drm_crtc_prepare(struct drm_crtc *crtc)