From patchwork Thu Oct 4 15:18:45 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rahul Sharma X-Patchwork-Id: 1545581 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by patchwork1.kernel.org (Postfix) with ESMTP id 274803FD9C for ; Thu, 4 Oct 2012 09:22:28 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 101CDA0CC4 for ; Thu, 4 Oct 2012 02:22:28 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) by gabe.freedesktop.org (Postfix) with ESMTP id AD390A0C23 for ; Thu, 4 Oct 2012 00:01:20 -0700 (PDT) Received: from epcpsbgm1.samsung.com (epcpsbgm1 [203.254.230.26]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MBC00KMJWT4NUC0@mailout1.samsung.com> for dri-devel@lists.freedesktop.org; Thu, 04 Oct 2012 16:01:07 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [172.20.52.124]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 45.7E.03783.3343D605; Thu, 04 Oct 2012 16:01:07 +0900 (KST) X-AuditID: cbfee61a-b7f726d000000ec7-53-506d34335e2b Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 94.7E.03783.3343D605; Thu, 04 Oct 2012 16:01:07 +0900 (KST) Received: from localhost.localdomain ([107.108.73.106]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MBC0040MWSZQ360@mmp2.samsung.com> for dri-devel@lists.freedesktop.org; Thu, 04 Oct 2012 16:01:07 +0900 (KST) From: Rahul Sharma To: dri-devel@lists.freedesktop.org Subject: [PATCH v1 03/14] drm: exynos: hdmi: fix interrupt handling Date: Thu, 04 Oct 2012 20:48:45 +0530 Message-id: <1349363936-8531-4-git-send-email-rahul.sharma@samsung.com> X-Mailer: git-send-email 1.7.0.4 In-reply-to: <1349363936-8531-1-git-send-email-rahul.sharma@samsung.com> References: <1349363936-8531-1-git-send-email-rahul.sharma@samsung.com> DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrDLMWRmVeSWpSXmKPExsWyRsSkRtfYJDfA4EyHhsWVr+/ZHBg97ncf ZwpgjOKySUnNySxLLdK3S+DKWPd5HWPBG46K/w/bWBsY17F3MXJySAiYSPx/OxXKFpO4cG89 WxcjF4eQwFJGiWmvO1i7GDnAin6erwOpERKYzijxeKIwRM1qJok7e+cxgyTYBHQlZh98xghi iwgoS/yduIoRpIhZYBGTxL87H8A2CAs4S9y538oCYrMIqErsW3udFcTmFXCXOLDsHNQVChKt yw6B2ZwCHhILf91gh9jsLvHk2iVGiF4BiW+TD7FAHCcrsekAM8guCYHbbBJ9k7+zQMyRlDi4 4gbLBEbhBYwMqxhFUwuSC4qT0nMN9YoTc4tL89L1kvNzNzECg/D0v2dSOxhXNlgcYhTgYFTi 4TXszgkQYk0sK67MPcQowcGsJMK7WTE3QIg3JbGyKrUoP76oNCe1+BCjD9AlE5mlRJPzgRGS VxJvaGxibmpsamlkZGZqikNYSZy32SMlQEggPbEkNTs1tSC1CGYcEwenVAPjlLcJYqtmOKfX J6+ed71v9/Fe++KC3f9ktIz3TIpts5146Uy2ehr/2SpL30b7W/0G2fK1up3pVzSmOMxdeCNZ u4D900bR2BtKF3I+iygZnu7yNp20NPxIhsqb8KpfnEtYdG+szX2R78dupRtd9rbhi1Itz8t4 o8ifqc2Ve46c+r9I/2mXkYYSS3FGoqEWc1FxIgA+GjHKbwIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupmkeLIzCtJLcpLzFFi42I5/e+xoK6xSW6AwddFshZXvr5nc2D0uN99 nCmAMaqB0SYjNTEltUghNS85PyUzL91WyTs43jne1MzAUNfQ0sJcSSEvMTfVVsnFJ0DXLTMH aKySQlliTilQKCCxuFhJ3w7ThNAQN10LmMYIXd+QILgeIwM0kLCGMWPd53WMBW84Kv4/bGNt YFzH3sXIwSEhYCLx83xdFyMnkCkmceHeejYQW0hgOqPE44nCXYxcQPZqJok7e+cxgyTYBHQl Zh98xghiiwgoS/yduIoRpIhZYBGTxL87H9hBEsICzhJ37reygNgsAqoS+9ZeZwWxeQXcJQ4s O8cOsU1BonXZITCbU8BDYuGvG+wQm90lnly7xDiBkXcBI8MqRtHUguSC4qT0XEO94sTc4tK8 dL3k/NxNjOAQfya1g3Flg8UhRgEORiUeXsPunAAh1sSy4srcQ4wSHMxKIrybFXMDhHhTEiur Uovy44tKc1KLDzH6AF01kVlKNDkfGH95JfGGxibmpsamliYWJmaWOISVxHmbPVIChATSE0tS s1NTC1KLYMYxcXBKNTC2rDY7wbdC/V1Y5KHwvXZ8jPde7ZgsJiN4cVWTm7CJ63l91wV91Usk +Ca46Bq1NSe83Nm70aOAf8GEX+rtEsGnL4vd3GbxefIui4DlfybtMQ5c5F1yRb33v2OE0Jzp N3Zt8airYZ15xvDL/q+/ZZymR22+vqu8pOzF6lW+og0hjxP1zI68Z/ipxFKckWioxVxUnAgA uJn5tJ4CAAA= X-CFilter-Loop: Reflected X-Mailman-Approved-At: Thu, 04 Oct 2012 00:53:11 -0700 Cc: t.stanislaws@samsung.com, l.krishna@samsung.com, joshi@samsung.com, kyungmin.park@samsung.com, fahad.k@samsung.com, rahul.sharma@samsung.com, prashanth.g@samsung.com, s.shirish@samsung.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org From: Tomasz Stanislawski This patch fixes 'unsigned < 0' check in probe. Moreover it releases an interrupt at remove. Signed-off-by: Tomasz Stanislawski Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_hdmi.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c index b3a802b..3902917 100644 --- a/drivers/gpu/drm/exynos/exynos_hdmi.c +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c @@ -64,8 +64,8 @@ struct hdmi_context { struct mutex hdmi_mutex; void __iomem *regs; - unsigned int external_irq; - unsigned int internal_irq; + int external_irq; + int internal_irq; struct i2c_client *ddc_port; struct i2c_client *hdmiphy_port; @@ -2424,6 +2424,7 @@ static int __devexit hdmi_remove(struct platform_device *pdev) pm_runtime_disable(dev); free_irq(hdata->internal_irq, hdata); + free_irq(hdata->external_irq, hdata); hdmi_resources_cleanup(hdata);