diff mbox

drm: Add missing break in the command line mode parsing code

Message ID 1349781988-32160-1-git-send-email-damien.lespiau@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Damien Lespiau Oct. 9, 2012, 11:26 a.m. UTC 
From: Damien Lespiau <damien.lespiau@intel.com>

As we parse the string given on the command line one char at a time, it
seems that we do want a break at every case.

Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
---
 drivers/gpu/drm/drm_modes.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Comments

Rodrigo Vivi Oct. 19, 2012, 4:55 p.m. UTC | #1 
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>

On Tue, Oct 9, 2012 at 8:26 AM, Damien Lespiau <damien.lespiau@gmail.com>wrote:

> From: Damien Lespiau <damien.lespiau@intel.com>
>
> As we parse the string given on the command line one char at a time, it
> seems that we do want a break at every case.
>
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> ---
>  drivers/gpu/drm/drm_modes.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c
> index 28637c1..50bd5c1 100644
> --- a/drivers/gpu/drm/drm_modes.c
> +++ b/drivers/gpu/drm/drm_modes.c
> @@ -1054,6 +1054,7 @@ bool drm_mode_parse_command_line_for_connector(const
> char *mode_option,
>                                 was_digit = false;
>                         } else
>                                 goto done;
> +                       break;
>                 case '0' ... '9':
>                         was_digit = true;
>                         break;
> --
> 1.7.7.5
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
diff mbox

Patch

diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c
index 28637c1..50bd5c1 100644
--- a/drivers/gpu/drm/drm_modes.c
+++ b/drivers/gpu/drm/drm_modes.c
@@ -1054,6 +1054,7 @@  bool drm_mode_parse_command_line_for_connector(const char *mode_option,
 				was_digit = false;
 			} else
 				goto done;
+			break;
 		case '0' ... '9':
 			was_digit = true;
 			break;