diff mbox

DRM/Radeon: Fix Load Detection on legacy primary DAC.

Message ID 1351096189-5634-1-git-send-email-eich@suse.de (mailing list archive)
State New, archived
Headers show

Commit Message

Egbert Eich Oct. 24, 2012, 4:29 p.m. UTC
An uninitialized variable led to broken load detection.

Signed-off-by: Egbert Eich <eich@suse.de>
---
 drivers/gpu/drm/radeon/radeon_legacy_encoders.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Comments

Alex Deucher Oct. 24, 2012, 4:56 p.m. UTC | #1
On Wed, Oct 24, 2012 at 12:29 PM, Egbert Eich <eich@suse.de> wrote:
> An uninitialized variable led to broken load detection.

Looks good.  Added to by -fixes queue.

Thanks!

Alex

>
> Signed-off-by: Egbert Eich <eich@suse.de>
> ---
>  drivers/gpu/drm/radeon/radeon_legacy_encoders.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_legacy_encoders.c b/drivers/gpu/drm/radeon/radeon_legacy_encoders.c
> index 2630e4e..752e98b 100644
> --- a/drivers/gpu/drm/radeon/radeon_legacy_encoders.c
> +++ b/drivers/gpu/drm/radeon/radeon_legacy_encoders.c
> @@ -668,6 +668,7 @@ static enum drm_connector_status radeon_legacy_primary_dac_detect(struct drm_enc
>         tmp |= RADEON_DAC_RANGE_CNTL_PS2 | RADEON_DAC_CMP_EN;
>         WREG32(RADEON_DAC_CNTL, tmp);
>
> +       tmp = dac_macro_cntl;
>         tmp &= ~(RADEON_DAC_PDWN_R |
>                  RADEON_DAC_PDWN_G |
>                  RADEON_DAC_PDWN_B);
> --
> 1.7.6.3
>
diff mbox

Patch

diff --git a/drivers/gpu/drm/radeon/radeon_legacy_encoders.c b/drivers/gpu/drm/radeon/radeon_legacy_encoders.c
index 2630e4e..752e98b 100644
--- a/drivers/gpu/drm/radeon/radeon_legacy_encoders.c
+++ b/drivers/gpu/drm/radeon/radeon_legacy_encoders.c
@@ -668,6 +668,7 @@  static enum drm_connector_status radeon_legacy_primary_dac_detect(struct drm_enc
 	tmp |= RADEON_DAC_RANGE_CNTL_PS2 | RADEON_DAC_CMP_EN;
 	WREG32(RADEON_DAC_CNTL, tmp);
 
+	tmp = dac_macro_cntl;
 	tmp &= ~(RADEON_DAC_PDWN_R |
 		 RADEON_DAC_PDWN_G |
 		 RADEON_DAC_PDWN_B);