From patchwork Wed Nov 7 10:28:58 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Prathyush K X-Patchwork-Id: 1710151 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by patchwork2.kernel.org (Postfix) with ESMTP id 62DE9DFB7A for ; Wed, 7 Nov 2012 11:40:24 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5D385A08DB for ; Wed, 7 Nov 2012 03:40:24 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout4.samsung.com (mailout4.samsung.com [203.254.224.34]) by gabe.freedesktop.org (Postfix) with ESMTP id 8AE1D9E787 for ; Wed, 7 Nov 2012 02:09:31 -0800 (PST) Received: from epcpsbgm1.samsung.com (epcpsbgm1 [203.254.230.26]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MD400DEI47U83I0@mailout4.samsung.com> for dri-devel@lists.freedesktop.org; Wed, 07 Nov 2012 19:09:30 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [172.20.52.124]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 4D.54.01231.A533A905; Wed, 07 Nov 2012 19:09:30 +0900 (KST) X-AuditID: cbfee61a-b7fa66d0000004cf-d6-509a335af1d8 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 2D.54.01231.A533A905; Wed, 07 Nov 2012 19:09:30 +0900 (KST) Received: from localhost.localdomain ([107.108.73.106]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MD4004XW45KF180@mmp2.samsung.com> for dri-devel@lists.freedesktop.org; Wed, 07 Nov 2012 19:09:30 +0900 (KST) From: Prathyush K To: dri-devel@lists.freedesktop.org Subject: [PATCH 2/3] drm/exynos: remove unnecessary sg_alloc_table call Date: Wed, 07 Nov 2012 15:58:58 +0530 Message-id: <1352284139-9497-2-git-send-email-prathyush.k@samsung.com> X-Mailer: git-send-email 1.7.0.4 In-reply-to: <1352284139-9497-1-git-send-email-prathyush.k@samsung.com> References: <1352284139-9497-1-git-send-email-prathyush.k@samsung.com> DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrFLMWRmVeSWpSXmKPExsWyRsSkRjfKeFaAQd8VTYsrX9+zOTB63O8+ zhTAGMVlk5Kak1mWWqRvl8CVsW3meeaCZxwVXS1zmBsY57N3MXJwSAiYSBw7I9HFyAlkiklc uLeerYuRi0NIYCmjxJ+bPxghEiYS/f0rmUFsIYHpjBKnV8tDFK1mkvizdQs7SIJNQFvi15y7 rCC2iICyxN+Jq8CamQUkJI60n2UDsYUF3CXWv10EVsMioCrRvWciWA2vgJvEp0fzoJYpSLQu OwQ2kxOovn/XbCaQQ4WAauZtZoJoFZD4NvkQC8T9shKbDjCDnCMhcJlN4sHETUwQYyQlDq64 wTKBUXgBI8MqRtHUguSC4qT0XEO94sTc4tK8dL3k/NxNjMAAPP3vmdQOxpUNFocYBTgYlXh4 J6TPDBBiTSwrrsw9xCjBwawkwsvAOytAiDclsbIqtSg/vqg0J7X4EKMP0CUTmaVEk/OB0ZFX Em9obGJuamxqaWRkZmqKQ1hJnLfZIyVASCA9sSQ1OzW1ILUIZhwTB6dUA+PO2Nijq5tZfFpi 2fTDDb52FidN2qC7QN9veWV875mp+mFWhmI+nUfPWrWpTL8hV8n0rU5qy0nPT0GLDrjkGErW RV36OyPx9LIT/c+vlhkVNbjMYf++x/6xDKveKs5twVNcTTdN7/sixLGO7WRhgDNL6REFzv2c JS+N3P77/6+YNX/+3t5TNkosxRmJhlrMRcWJAFFpQHJtAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupikeLIzCtJLcpLzFFi42I5/e+xoG6U8awAg4UTlCyufH3P5sDocb/7 OFMAY1QDo01GamJKapFCal5yfkpmXrqtkndwvHO8qZmBoa6hpYW5kkJeYm6qrZKLT4CuW2YO 0FglhbLEnFKgUEBicbGSvh2mCaEhbroWMI0Rur4hQXA9RgZoIGENY8a2meeZC55xVHS1zGFu YJzP3sXIySEhYCLR37+SGcIWk7hwbz0biC0kMJ1R4vRq+S5GLiB7NZPEn61bwBrYBLQlfs25 ywpiiwgoS/yduIoRxGYWkJA40n4WrFlYwF1i/dtFYDUsAqoS3XsmgtXwCrhJfHo0jxFimYJE 67JDYDM5ger7d81m6mLkAFrmJjFvM9MERt4FjAyrGEVTC5ILipPScw31ihNzi0vz0vWS83M3 MYID/JnUDsaVDRaHGAU4GJV4eCekzwwQYk0sK67MPcQowcGsJMLLwDsrQIg3JbGyKrUoP76o NCe1+BCjD9BRE5mlRJPzgdGXVxJvaGxibmpsamliYWJmiUNYSZy32SMlQEggPbEkNTs1tSC1 CGYcEwenVANjjalSln+E+6dz3bVVh2Iup3B+OK/+ZG6LzbTTNTtXPVl2b+XhvbnPTRcz/nX1 s7UNPKzie4f37CJON6OoCUnVE3+yrFviU8Zs5f/BzVPkqYCTgaL0c7bd2tMn/gmZ4aY7wzv+ bZvSXs7K3/ssDKZc0zcMXTphovQt4bbTjT6/m+oU0yVKpxxXYinOSDTUYi4qTgQA6YtB3J0C AAA= X-CFilter-Loop: Reflected X-Mailman-Approved-At: Wed, 07 Nov 2012 03:37:27 -0800 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org The function dma_get_sgtable will allocate a sg table internally so it is not necessary to allocate a sg table before it. The unnecessary 'sg_alloc_table' call is removed. Signed-off-by: Prathyush K --- drivers/gpu/drm/exynos/exynos_drm_dmabuf.c | 8 +------- 1 files changed, 1 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_dmabuf.c b/drivers/gpu/drm/exynos/exynos_drm_dmabuf.c index b98da30..d9307bd 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_dmabuf.c +++ b/drivers/gpu/drm/exynos/exynos_drm_dmabuf.c @@ -40,21 +40,15 @@ static struct sg_table *exynos_get_sgt(struct drm_device *drm_dev, if (!sgt) goto out; - ret = sg_alloc_table(sgt, buf->sgt->nents, GFP_KERNEL); - if (ret) - goto err_free_sgt; - ret = dma_get_sgtable(drm_dev->dev, sgt, buf->kvaddr, buf->dma_addr, buf->size); if (ret < 0) { DRM_ERROR("failed to get sgtable.\n"); - goto err_free_table; + goto err_free_sgt; } return sgt; -err_free_table: - sg_free_table(sgt); err_free_sgt: kfree(sgt); sgt = NULL;