From patchwork Mon Nov 19 09:20:30 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 1765621 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by patchwork1.kernel.org (Postfix) with ESMTP id EDC9A3FCDE for ; Mon, 19 Nov 2012 15:56:16 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EB908E61AA for ; Mon, 19 Nov 2012 07:56:16 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pa0-f49.google.com (mail-pa0-f49.google.com [209.85.220.49]) by gabe.freedesktop.org (Postfix) with ESMTP id 35F9FE6058 for ; Mon, 19 Nov 2012 01:26:40 -0800 (PST) Received: by mail-pa0-f49.google.com with SMTP id bi1so408780pad.36 for ; Mon, 19 Nov 2012 01:26:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:x-gm-message-state; bh=d3lx1jU8Q4ZvYqGf440FdxdLo2VEmaAR5zKLTTJeZh0=; b=ojE1w6wdvDwyCzdQy6HaPPcU1JvoeESe3NKl93qTJD/+UXQW1yWoHlPACWvCLflJzX 5V94uy9Yloep3+St3tDN77WCx0nGcZONhbM9I1mSdUtxgkeO8bfM6VyQvvN6twkJsFdm +yXFwxl7g+cQ+FXOKz0LCKT4U4oO0s0dEe8urUR0BzGqQgif1Q6rXhCY1Co2JjZNxFvk C0QPKj2fqT6R5RFDKRkaHszOVYbMW89jdAQkktSZiTK8F9nmvcum6zod8c9Stt92CQdR pGOWEp4BuTCR0SlrZ5o57941xSlmngw0t0F0aQqA+E95ovMRey1JiOjdWG3vHU3Ez5ut 8ZeQ== Received: by 10.68.191.200 with SMTP id ha8mr37160214pbc.51.1353317200003; Mon, 19 Nov 2012 01:26:40 -0800 (PST) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id ku7sm5939870pbc.0.2012.11.19.01.26.36 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 19 Nov 2012 01:26:39 -0800 (PST) From: Sachin Kamat To: dri-devel@lists.freedesktop.org Subject: [PATCH 1/1] drm/exynos: Fix potential NULL pointer dereference in exynos_drm_encoder.c Date: Mon, 19 Nov 2012 14:50:30 +0530 Message-Id: <1353316830-23755-1-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 X-Gm-Message-State: ALoCoQmshNLsB8FeSXRDZHqAnad7zEhlTs4zOVvKJ28khlK65rjo+hLnXNFcS/YaNxDX00l7C643 X-Mailman-Approved-At: Mon, 19 Nov 2012 07:53:20 -0800 Cc: sachin.kamat@linaro.org, patches@linaro.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Check overlay_ops is not NULL as checked in the previous 'if' condition. Fixes the following smatch error: drivers/gpu/drm/exynos/exynos_drm_encoder.c:509 exynos_drm_encoder_plane_disable() error: we previously assumed 'overlay_ops' could be null (see line 499) Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_drm_encoder.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_encoder.c b/drivers/gpu/drm/exynos/exynos_drm_encoder.c index e51503f..a44238e 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_encoder.c +++ b/drivers/gpu/drm/exynos/exynos_drm_encoder.c @@ -506,6 +506,6 @@ void exynos_drm_encoder_plane_disable(struct drm_encoder *encoder, void *data) * because the setting for disabling the overlay will be updated * at vsync. */ - if (overlay_ops->wait_for_vblank) + if (overlay_ops && overlay_ops->wait_for_vblank) overlay_ops->wait_for_vblank(manager->dev); }