diff mbox

radeon: add AGPMode 1 quirk for RV250

Message ID 1353356251.19434.22.camel@x61.thuisdomein (mailing list archive)
State New, archived
Headers show

Commit Message

Paul Bolle Nov. 19, 2012, 8:17 p.m. UTC
The Intel 82855PM host bridge / Mobility FireGL 9000 RV250 combination
in an (outdated) ThinkPad T41 needs AGPMode 1 for suspend/resume (under
KMS, that is). So add a quirk for it.

(Change R250 to RV250 in comment for preceding quirk too.)

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
0) Last tested on v3.6.7. The patch was cherry-picked on top of
v3.7-rc6.

1) A similar patch was submitted twenty months ago via
https://bugzilla.redhat.com/show_bug.cgi?id=531825 , but nothing
happened after that.

 drivers/gpu/drm/radeon/radeon_agp.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

Comments

Alex Deucher Nov. 20, 2012, 4:47 p.m. UTC | #1
On Mon, Nov 19, 2012 at 3:17 PM, Paul Bolle <pebolle@tiscali.nl> wrote:
> The Intel 82855PM host bridge / Mobility FireGL 9000 RV250 combination
> in an (outdated) ThinkPad T41 needs AGPMode 1 for suspend/resume (under
> KMS, that is). So add a quirk for it.
>
> (Change R250 to RV250 in comment for preceding quirk too.)
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>

Thanks, added to my -fixes queue.

Alex

> ---
> 0) Last tested on v3.6.7. The patch was cherry-picked on top of
> v3.7-rc6.
>
> 1) A similar patch was submitted twenty months ago via
> https://bugzilla.redhat.com/show_bug.cgi?id=531825 , but nothing
> happened after that.
>
>  drivers/gpu/drm/radeon/radeon_agp.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_agp.c b/drivers/gpu/drm/radeon/radeon_agp.c
> index 10ea17a..4243334 100644
> --- a/drivers/gpu/drm/radeon/radeon_agp.c
> +++ b/drivers/gpu/drm/radeon/radeon_agp.c
> @@ -69,9 +69,12 @@ static struct radeon_agpmode_quirk radeon_agpmode_quirk_list[] = {
>         /* Intel 82830 830 Chipset Host Bridge / Mobility M6 LY Needs AGPMode 2 (fdo #17360)*/
>         { PCI_VENDOR_ID_INTEL, 0x3575, PCI_VENDOR_ID_ATI, 0x4c59,
>                 PCI_VENDOR_ID_DELL, 0x00e3, 2},
> -       /* Intel 82852/82855 host bridge / Mobility FireGL 9000 R250 Needs AGPMode 1 (lp #296617) */
> +       /* Intel 82852/82855 host bridge / Mobility FireGL 9000 RV250 Needs AGPMode 1 (lp #296617) */
>         { PCI_VENDOR_ID_INTEL, 0x3580, PCI_VENDOR_ID_ATI, 0x4c66,
>                 PCI_VENDOR_ID_DELL, 0x0149, 1},
> +       /* Intel 82855PM host bridge / Mobility FireGL 9000 RV250 Needs AGPMode 1 for suspend/resume */
> +       { PCI_VENDOR_ID_INTEL, 0x3340, PCI_VENDOR_ID_ATI, 0x4c66,
> +               PCI_VENDOR_ID_IBM, 0x0531, 1},
>         /* Intel 82852/82855 host bridge / Mobility 9600 M10 RV350 Needs AGPMode 1 (deb #467460) */
>         { PCI_VENDOR_ID_INTEL, 0x3580, PCI_VENDOR_ID_ATI, 0x4e50,
>                 0x1025, 0x0061, 1},
> --
> 1.7.7.6
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
diff mbox

Patch

diff --git a/drivers/gpu/drm/radeon/radeon_agp.c b/drivers/gpu/drm/radeon/radeon_agp.c
index 10ea17a..4243334 100644
--- a/drivers/gpu/drm/radeon/radeon_agp.c
+++ b/drivers/gpu/drm/radeon/radeon_agp.c
@@ -69,9 +69,12 @@  static struct radeon_agpmode_quirk radeon_agpmode_quirk_list[] = {
 	/* Intel 82830 830 Chipset Host Bridge / Mobility M6 LY Needs AGPMode 2 (fdo #17360)*/
 	{ PCI_VENDOR_ID_INTEL, 0x3575, PCI_VENDOR_ID_ATI, 0x4c59,
 		PCI_VENDOR_ID_DELL, 0x00e3, 2},
-	/* Intel 82852/82855 host bridge / Mobility FireGL 9000 R250 Needs AGPMode 1 (lp #296617) */
+	/* Intel 82852/82855 host bridge / Mobility FireGL 9000 RV250 Needs AGPMode 1 (lp #296617) */
 	{ PCI_VENDOR_ID_INTEL, 0x3580, PCI_VENDOR_ID_ATI, 0x4c66,
 		PCI_VENDOR_ID_DELL, 0x0149, 1},
+	/* Intel 82855PM host bridge / Mobility FireGL 9000 RV250 Needs AGPMode 1 for suspend/resume */
+	{ PCI_VENDOR_ID_INTEL, 0x3340, PCI_VENDOR_ID_ATI, 0x4c66,
+		PCI_VENDOR_ID_IBM, 0x0531, 1},
 	/* Intel 82852/82855 host bridge / Mobility 9600 M10 RV350 Needs AGPMode 1 (deb #467460) */
 	{ PCI_VENDOR_ID_INTEL, 0x3580, PCI_VENDOR_ID_ATI, 0x4e50,
 		0x1025, 0x0061, 1},