From patchwork Fri Nov 23 03:41:58 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 1793931 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by patchwork2.kernel.org (Postfix) with ESMTP id 44B34DF230 for ; Fri, 23 Nov 2012 06:43:42 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 49A93E64F2 for ; Thu, 22 Nov 2012 22:43:42 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pa0-f49.google.com (mail-pa0-f49.google.com [209.85.220.49]) by gabe.freedesktop.org (Postfix) with ESMTP id BFF9DE5F37 for ; Thu, 22 Nov 2012 19:48:32 -0800 (PST) Received: by mail-pa0-f49.google.com with SMTP id bi1so3060302pad.36 for ; Thu, 22 Nov 2012 19:48:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=4bIJvrtTAwTWnAx6gQWWix7cAVzTAS4LHgSRlhxvwQY=; b=LQ77Das96tRpOwo0291bBFMbKk6pHTnMLHFLCmHbLAKYzE7AzQkACnWAI6DxN2KTp/ mQvzRVbznsxIFdL34iWeIScx9gkRQyoI2VX30Pv2UB5esLlmdp3UaSBKzZryUcofFQ+u YoYwbzEpcA27nU7GF2L18nv5VJcIPbme02g/8Oz9lpVpUzUtRdjekGz4OYgaFCfXhflV f5FnShNPRI8XllbVo/ouH2K+Ai8q6y/VK+CWbRWhVn6VxX0w6j3E5ogExZHj1IyiAYvD AvWuS6OsjMjnMYnVM2lkPvRSC2+YZq7eW9vCyPBh6rtxiENcdnkH0oegbRdfz+NQVezw XuJg== Received: by 10.68.248.74 with SMTP id yk10mr10599752pbc.86.1353642512748; Thu, 22 Nov 2012 19:48:32 -0800 (PST) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id x8sm2937337paw.16.2012.11.22.19.48.29 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 22 Nov 2012 19:48:32 -0800 (PST) From: Sachin Kamat To: dri-devel@lists.freedesktop.org Subject: [PATCH 4/5] drm/exynos: Use devm_clk_get in exynos_drm_g2d.c Date: Fri, 23 Nov 2012 09:11:58 +0530 Message-Id: <1353642119-10253-5-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1353642119-10253-1-git-send-email-sachin.kamat@linaro.org> References: <1353642119-10253-1-git-send-email-sachin.kamat@linaro.org> X-Gm-Message-State: ALoCoQkWoXLIeANOCIPCnvhlmMGcsLr/TPuSsjtBakNSl4XuA1xWSRCjIyIhEYVV5EkW7rnLASeh X-Mailman-Approved-At: Thu, 22 Nov 2012 22:38:55 -0800 Cc: patches@linaro.org, sachin.kamat@linaro.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org devm_clk_get is device managed and makes error handling and exit code simpler. Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_drm_g2d.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c index a9002ad..c1054cb 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c @@ -1125,7 +1125,7 @@ static int __devinit g2d_probe(struct platform_device *pdev) mutex_init(&g2d->cmdlist_mutex); mutex_init(&g2d->runqueue_mutex); - g2d->gate_clk = clk_get(dev, "fimg2d"); + g2d->gate_clk = devm_clk_get(dev, "fimg2d"); if (IS_ERR(g2d->gate_clk)) { dev_err(dev, "failed to get gate clock\n"); ret = PTR_ERR(g2d->gate_clk); @@ -1181,7 +1181,6 @@ static int __devinit g2d_probe(struct platform_device *pdev) err_put_clk: pm_runtime_disable(dev); - clk_put(g2d->gate_clk); err_destroy_workqueue: destroy_workqueue(g2d->g2d_workq); err_destroy_slab: @@ -1202,7 +1201,6 @@ static int __devexit g2d_remove(struct platform_device *pdev) } pm_runtime_disable(&pdev->dev); - clk_put(g2d->gate_clk); g2d_fini_cmdlist(g2d); destroy_workqueue(g2d->g2d_workq);