From patchwork Thu Dec 20 09:31:29 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eunchul Kim X-Patchwork-Id: 1898961 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by patchwork2.kernel.org (Postfix) with ESMTP id 9D6E2DF23A for ; Thu, 20 Dec 2012 09:33:51 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 94193E5F9B for ; Thu, 20 Dec 2012 01:33:51 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout2.samsung.com (mailout2.samsung.com [203.254.224.25]) by gabe.freedesktop.org (Postfix) with ESMTP id 07AEDE5C1D for ; Thu, 20 Dec 2012 01:31:32 -0800 (PST) Received: from epcpsbgm1.samsung.com (epcpsbgm1 [203.254.230.26]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MFB001CBP3OJCT0@mailout2.samsung.com> for dri-devel@lists.freedesktop.org; Thu, 20 Dec 2012 18:31:27 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.43]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id DD.F6.01231.FEAD2D05; Thu, 20 Dec 2012 18:31:27 +0900 (KST) X-AuditID: cbfee61a-b7fa66d0000004cf-9f-50d2daef6158 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id EB.F6.01231.EEAD2D05; Thu, 20 Dec 2012 18:31:27 +0900 (KST) Received: from localhost.localdomain ([10.90.54.32]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MFB0040GP41LE10@mmp2.samsung.com> for dri-devel@lists.freedesktop.org; Thu, 20 Dec 2012 18:31:26 +0900 (KST) From: Eunchul Kim To: dri-devel@lists.freedesktop.org, inki.dae@samsung.com Subject: [PATCH 2/8] drm/exynos: removed needless error handling about property. Date: Thu, 20 Dec 2012 18:31:29 +0900 Message-id: <1355995895-16355-3-git-send-email-chulspro.kim@samsung.com> X-Mailer: git-send-email 1.7.0.4 In-reply-to: <1355995895-16355-1-git-send-email-chulspro.kim@samsung.com> References: <1355995895-16355-1-git-send-email-chulspro.kim@samsung.com> DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrNLMWRmVeSWpSXmKPExsVy+t8zbd33ty4FGLw7w25x5et7NgdGj/vd x5kCGKO4bFJSczLLUov07RK4Mt7+f81cME2y4tixuawNjB2iXYycHBICJhJP+s4zQthiEhfu rWfrYuTiEBJYxijRMm8FO0zRu3nnWCES0xklHn5/DNYhJLCCSeJcgzKIzSagI3HkVjMziC0i YCnxYOtvZpAGZoGfjBLrnpwF6ubgEBYIkDh+txikhkVAVWLqzDtsIDavgIfEpKuXoZYpSLQu OwRmcwp4SiyZ2MAE0ioEVHOxhweiVUDi2+RDLCBhCQFZiU0HwDZJCNxmk5jw9BDUGEmJgytu sExgFF7AyLCKUTS1ILmgOCk911CvODG3uDQvXS85P3cTIyQEpXYwrmywOMQowMGoxMO7aNql ACHWxLLiytxDjBIczEoivAtvXQwQ4k1JrKxKLcqPLyrNSS0+xOgDdMlEZinR5HxgfOSVxBsa GxgbGloamplamhrgEFYS5232SAkQEkhPLEnNTk0tSC2CGcfEwSnVwCjjvu2s+qWbC/0yefeF XlgiOGv9s6Z2qbr7j0zcKk30UpoO2f/Y8JIhsfS61MmXXjo9vMeE/auVjh/iYJjl1l1xRT/T 32vxmUkfX169GdyvsfCTi4FwhGFfY1unSPLBB+vT9zD93/OJqXq1q+/em14rm7RS3zCcT4tJ +PGu7jTrct0np5sfLlBiKc5INNRiLipOBABERcOLbgIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupikeLIzCtJLcpLzFFi42I5/e+xoO77W5cCDHoamSyufH3P5sDocb/7 OFMAY1QDo01GamJKapFCal5yfkpmXrqtkndwvHO8qZmBoa6hpYW5kkJeYm6qrZKLT4CuW2YO 0FglhbLEnFKgUEBicbGSvh2mCaEhbroWMI0Rur4hQXA9RgZoIGEdY8bb/6+ZC6ZJVhw7Npe1 gbFDtIuRk0NCwETi3bxzrBC2mMSFe+vZuhi5OIQEpjNKPPz+mBEkISSwgkniXIMyiM0moCNx 5FYzM4gtImAp8WDrb2aQBmaBn4wS656cBZrEwSEsECBx/G4xSA2LgKrE1Jl32EBsXgEPiUlX L7NDLFOQaF12CMzmFPCUWDKxgQmkVQio5mIPzwRG3gWMDKsYRVMLkguKk9JzDfWKE3OLS/PS 9ZLzczcxggP8mdQOxpUNFocYBTgYlXh4F027FCDEmlhWXJl7iFGCg1lJhHfhrYsBQrwpiZVV qUX58UWlOanFhxh9gI6ayCwlmpwPjL68knhDYxMzI0sjM2MTc2NjHMJK4rzNHikBQgLpiSWp 2ampBalFMOOYODilGhg5f7NnmgU/S9x7tqJn9yqPPamC6bFrHu45qCNvIdR2PqdDS4B74ZKG N15bS+Q1P7TpnTWbvDGXwX+zwKMr8e83/bpV3n5DnP2b0FmJ+ZyuTv7M1ywqNt7Vr79RPj9n 1033/g2HHhz2mWz+KWntGdHo9brrU+qtD2fGLLxYP11szoHrp1hbjUSVWIozEg21mIuKEwHu 6yVZnQIAAA== X-CFilter-Loop: Reflected Cc: jy0.jeon@samsung.com, sw0312.kim@samsung.com, jaejoon.seo@samsung.com, kyungmin.park@samsung.com, jmock.shin@samsung.com, lsmin.lee@samsung.com, th908.kim@samsung.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org This patch removed property error handling. property couldn't be NULL. so, I removed it. Signed-off-by: Eunchul Kim --- drivers/gpu/drm/exynos/exynos_drm_fimc.c | 12 ------------ drivers/gpu/drm/exynos/exynos_drm_gsc.c | 12 ------------ drivers/gpu/drm/exynos/exynos_drm_ipp.c | 5 ----- 3 files changed, 0 insertions(+), 29 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c b/drivers/gpu/drm/exynos/exynos_drm_fimc.c index 7a3e460..5dc0251 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fimc.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fimc.c @@ -705,10 +705,6 @@ static int fimc_src_set_addr(struct device *dev, } property = &c_node->property; - if (!property) { - DRM_ERROR("failed to get property.\n"); - return -EINVAL; - } DRM_DEBUG_KMS("%s:prop_id[%d]buf_id[%d]buf_type[%d]\n", __func__, property->prop_id, buf_id, buf_type); @@ -1241,10 +1237,6 @@ static int fimc_dst_set_addr(struct device *dev, } property = &c_node->property; - if (!property) { - DRM_ERROR("failed to get property.\n"); - return -EINVAL; - } DRM_DEBUG_KMS("%s:prop_id[%d]buf_id[%d]buf_type[%d]\n", __func__, property->prop_id, buf_id, buf_type); @@ -1573,10 +1565,6 @@ static int fimc_ippdrv_start(struct device *dev, enum drm_exynos_ipp_cmd cmd) } property = &c_node->property; - if (!property) { - DRM_ERROR("failed to get property.\n"); - return -EINVAL; - } fimc_handle_irq(ctx, true, false, true); diff --git a/drivers/gpu/drm/exynos/exynos_drm_gsc.c b/drivers/gpu/drm/exynos/exynos_drm_gsc.c index c443c3b..ba5fefd 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_gsc.c +++ b/drivers/gpu/drm/exynos/exynos_drm_gsc.c @@ -720,10 +720,6 @@ static int gsc_src_set_addr(struct device *dev, } property = &c_node->property; - if (!property) { - DRM_ERROR("failed to get property.\n"); - return -EFAULT; - } DRM_DEBUG_KMS("%s:prop_id[%d]buf_id[%d]buf_type[%d]\n", __func__, property->prop_id, buf_id, buf_type); @@ -1180,10 +1176,6 @@ static int gsc_dst_set_addr(struct device *dev, } property = &c_node->property; - if (!property) { - DRM_ERROR("failed to get property.\n"); - return -EFAULT; - } DRM_DEBUG_KMS("%s:prop_id[%d]buf_id[%d]buf_type[%d]\n", __func__, property->prop_id, buf_id, buf_type); @@ -1565,10 +1557,6 @@ static int gsc_ippdrv_start(struct device *dev, enum drm_exynos_ipp_cmd cmd) } property = &c_node->property; - if (!property) { - DRM_ERROR("failed to get property.\n"); - return -EINVAL; - } gsc_handle_irq(ctx, true, false, true); diff --git a/drivers/gpu/drm/exynos/exynos_drm_ipp.c b/drivers/gpu/drm/exynos/exynos_drm_ipp.c index ba45f9a..cac94fe 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_ipp.c +++ b/drivers/gpu/drm/exynos/exynos_drm_ipp.c @@ -1487,11 +1487,6 @@ void ipp_sched_cmd(struct work_struct *work) mutex_lock(&c_node->cmd_lock); property = &c_node->property; - if (!property) { - DRM_ERROR("failed to get property:prop_id[%d]\n", - c_node->property.prop_id); - goto err_unlock; - } switch (cmd_work->ctrl) { case IPP_CTRL_PLAY: