From patchwork Fri Dec 21 08:44:57 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Inki Dae X-Patchwork-Id: 1902451 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by patchwork1.kernel.org (Postfix) with ESMTP id 4CC9E3FC64 for ; Fri, 21 Dec 2012 08:46:12 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 28EE6E6133 for ; Fri, 21 Dec 2012 00:46:12 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout2.samsung.com (mailout2.samsung.com [203.254.224.25]) by gabe.freedesktop.org (Postfix) with ESMTP id 16F5FE60CF for ; Fri, 21 Dec 2012 00:44:59 -0800 (PST) Received: from epcpsbgm2.samsung.com (epcpsbgm2 [203.254.230.27]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MFD00FZTHMRS940@mailout2.samsung.com> for dri-devel@lists.freedesktop.org; Fri, 21 Dec 2012 17:44:58 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.41]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id F6.25.12699.A8124D05; Fri, 21 Dec 2012 17:44:58 +0900 (KST) X-AuditID: cbfee61b-b7f616d00000319b-9b-50d4218ae445 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id A6.25.12699.A8124D05; Fri, 21 Dec 2012 17:44:58 +0900 (KST) Received: from daeinki-desktop.10.32.193.11 ([10.90.51.53]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MFD00MP3HMYAT70@mmp2.samsung.com> for dri-devel@lists.freedesktop.org; Fri, 21 Dec 2012 17:44:58 +0900 (KST) From: Inki Dae To: airlied@linux.ie, dri-devel@lists.freedesktop.org Subject: [PATCH] drm/exynos: fix erroneous register read Date: Fri, 21 Dec 2012 17:44:57 +0900 Message-id: <1356079497-21541-1-git-send-email-inki.dae@samsung.com> X-Mailer: git-send-email 1.7.4.1 DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrCLMWRmVeSWpSXmKPExsVy+t8zTd0uxSsBBjtmylhc+fqezYHR4373 caYAxigum5TUnMyy1CJ9uwSujNbZvxgLtnBUnDg/j7GBsZ+9i5GDQ0LAROL8lLAuRk4gU0zi wr31bF2MXBxCAssYJTrXrmGESJhIzJlyHioxnVHi8qZvLBDOeiaJuy2rWECq2ARUJSauuM8G YosImEp0TFoKFmcWsJPY9QBkGyeHsICFxI9V28FqWIDqz05rYQKxeQVcJD7O38AGsU1BYsG9 t1A1AhLfJh9igbhUVmLTAWaQvRICG9gkLk9bxQ5RLylxcMUNlgmMggsYGVYxiqYWJBcUJ6Xn GukVJ+YWl+al6yXn525ihASV9A7GVQ0WhxgFOBiVeHgjLS4HCLEmlhVX5h5ilOBgVhLhZfoK FOJNSaysSi3Kjy8qzUktPsToA3TJRGYp0eR8YMDnlcQbGhsYGxpaGpqZWpoa4BBWEudt9kgJ EBJITyxJzU5NLUgtghnHxMEp1cDIl9WzPbW7/uwi54zK9vUsSns+SjLtEnjH1n/06oQQoRcb iwVypndv6vgt9aFLwoXpQMjbGO7/7h8F80KvXPjkHaBke21Pa86rhKuH/n3IWizyN9zL95rC pa/bzJXkr1QzxHxkuxL77fK740/8DW/unHxDS6Lg1o9X9Wv2HjY8qfx5Srn71Sk8SizFGYmG WsxFxYkAye0BD1cCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrCLMWRmVeSWpSXmKPExsVy+t9jQd0uxSsBBtvXi1pc+fqezYHR4373 caYAxqgGRpuM1MSU1CKF1Lzk/JTMvHRbJe/geOd4UzMDQ11DSwtzJYW8xNxUWyUXnwBdt8wc oLFKCmWJOaVAoYDE4mIlfTtME0JD3HQtYBojdH1DguB6jAzQQMI6xozW2b8YC7ZwVJw4P4+x gbGfvYuRk0NCwERizpTzbBC2mMSFe+uBbC4OIYHpjBKXN31jgXDWM0ncbVnFAlLFJqAqMXHF fbAOEQFTiY5JS8HizAJ2ErseQEwVFrCQ+LFqO1gNC1D92WktTCA2r4CLxMf5G6C2KUgsuPeW bQIj9wJGhlWMoqkFyQXFSem5RnrFibnFpXnpesn5uZsYwUH7THoH46oGi0OMAhyMSjy8kRaX A4RYE8uKK3MPMUpwMCuJ8DJ9BQrxpiRWVqUW5ccXleakFh9i9AHaPpFZSjQ5HxhReSXxhsYm ZkaWRmbGJubGxjiElcR5mz1SAoQE0hNLUrNTUwtSi2DGMXFwSjUwJrJfKnL1uuqovIprUZXL x5zEE3meJgW3GgOyfsjZnllWIbi+R22q0XW+t4eK5lWt9lZq99C6Lpf0pfmK6iXFl4o/LRgZ U5dPZ/z1lOu+/S+/h4bLri+9EOakHhquuJn9aXXefoUoo1VHru8KvJn/y8z77dlFNqEVm79K 3iq64+O+S62+ie2iEktxRqKhFnNRcSIAuInDu4cCAAA= X-CFilter-Loop: Reflected Cc: kyungmin.park@samsung.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org This patch fixes erroneous register read. readl function needs register base address + offset but exynos_drm_gsc module used only offset to read a register. So this patch uses gsc_read function instead of readl. Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_gsc.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_gsc.c b/drivers/gpu/drm/exynos/exynos_drm_gsc.c index 5639353..bd42542 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_gsc.c +++ b/drivers/gpu/drm/exynos/exynos_drm_gsc.c @@ -1604,7 +1604,7 @@ static int gsc_ippdrv_start(struct device *dev, enum drm_exynos_ipp_cmd cmd) exynos_drm_ippnb_send_event(IPP_SET_WRITEBACK, (void *)&set_wb); /* src local path */ - cfg = readl(GSC_IN_CON); + cfg = gsc_read(GSC_IN_CON); cfg &= ~(GSC_IN_PATH_MASK | GSC_IN_LOCAL_SEL_MASK); cfg |= (GSC_IN_PATH_LOCAL | GSC_IN_LOCAL_FIMD_WB); gsc_write(cfg, GSC_IN_CON);