From patchwork Sat Dec 22 08:49:23 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eunchul Kim X-Patchwork-Id: 1905551 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by patchwork1.kernel.org (Postfix) with ESMTP id CB6463FCA5 for ; Sat, 22 Dec 2012 08:50:00 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A945AE6018 for ; Sat, 22 Dec 2012 00:50:00 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout4.samsung.com (mailout4.samsung.com [203.254.224.34]) by gabe.freedesktop.org (Postfix) with ESMTP id 846CFE5C7A for ; Sat, 22 Dec 2012 00:49:37 -0800 (PST) Received: from epcpsbgm2.samsung.com (epcpsbgm2 [203.254.230.27]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MFF0003BCINHOB0@mailout4.samsung.com> for dri-devel@lists.freedesktop.org; Sat, 22 Dec 2012 17:49:35 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.45]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id F3.5D.12699.F1475D05; Sat, 22 Dec 2012 17:49:35 +0900 (KST) X-AuditID: cbfee61b-b7f616d00000319b-b6-50d5741fe352 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id F2.5D.12699.F1475D05; Sat, 22 Dec 2012 17:49:35 +0900 (KST) Received: from localhost.localdomain ([10.90.54.32]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MFF00JZNCIJQC10@mmp2.samsung.com> for dri-devel@lists.freedesktop.org; Sat, 22 Dec 2012 17:49:35 +0900 (KST) From: Eunchul Kim To: dri-devel@lists.freedesktop.org, inki.dae@samsung.com Subject: [PATCH v3 2/8] drm/exynos: remove needless error handling to property. Date: Sat, 22 Dec 2012 17:49:23 +0900 Message-id: <1356166169-3400-3-git-send-email-chulspro.kim@samsung.com> X-Mailer: git-send-email 1.7.0.4 In-reply-to: <1356166169-3400-1-git-send-email-chulspro.kim@samsung.com> References: <1356166169-3400-1-git-send-email-chulspro.kim@samsung.com> DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrLLMWRmVeSWpSXmKPExsVy+t8zXV35kqsBBu0zlCyufH3P5sDocb/7 OFMAYxSXTUpqTmZZapG+XQJXxoILSxgLuiUrzrT1MjUwNop2MXJySAiYSPQc+88OYYtJXLi3 nq2LkYtDSGAZo0THhwYmmKKlnRugEtMZJZY0XGeFcFYwSfz99AusnU1AR+LIrWZmEFtEwFLi wdbfzCBFzAI/GSXWPTkL1MHBISzgL7H0rRxIDYuAqsS6uT8YQWxeAXeJE/dfMkNsU5BoXXYI bCangIdE57KlrCC2EFBN//JmFoheAYlvkw+xgIyUEJCV2HQAbJWEwHU2iT0LvrBBzJGUOLji BssERuEFjAyrGEVTC5ILipPSc430ihNzi0vz0vWS83M3MULCUHoH46oGi0OMAhyMSjy8F5uu BAixJpYVV+YeYpTgYFYS4d1icDVAiDclsbIqtSg/vqg0J7X4EKMP0CUTmaVEk/OBMZJXEm9o bGBsaGhpaGZqaWqAQ1hJnLfZIyVASCA9sSQ1OzW1ILUIZhwTB6dUA+Pk5t6YJXmfJh7syT3R WrYoSkxwmiCzw6Mj3VYpyrKrbxbtU+Lpu/Lpx/zLx64EOAn2HP8g61YVu+nJjOikFT6vTmis CllzKTIpyyaZe8rjsy9uL/kWrSIX8fnaek0OmXq9le9Tf6eFvY+vvpG1R1J3ysKJHesOv6y2 lXvZV/dtOYN43ve0p4pKLMUZiYZazEXFiQAjTAG5cAIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuphkeLIzCtJLcpLzFFi42I5/e+xoK58ydUAg8NTpS2ufH3P5sDocb/7 OFMAY1QDo01GamJKapFCal5yfkpmXrqtkndwvHO8qZmBoa6hpYW5kkJeYm6qrZKLT4CuW2YO 0FglhbLEnFKgUEBicbGSvh2mCaEhbroWMI0Rur4hQXA9RgZoIGEdY8aCC0sYC7olK8609TI1 MDaKdjFyckgImEgs7dzABmGLSVy4tx7I5uIQEpjOKLGk4TorhLOCSeLvp1/sIFVsAjoSR241 M4PYIgKWEg+2/mYGKWIW+Mkose7JWaAODg5hAX+JpW/lQGpYBFQl1s39wQhi8wq4S5y4/5IZ YpuCROuyQ2AzOQU8JDqXLWUFsYWAavqXN7NMYORdwMiwilE0tSC5oDgpPddIrzgxt7g0L10v OT93EyM4yJ9J72Bc1WBxiFGAg1GJh/di05UAIdbEsuLK3EOMEhzMSiK8WwyuBgjxpiRWVqUW 5ccXleakFh9i9AG6aiKzlGhyPjAC80riDY1NzIwsjcyMTcyNjXEIK4nzNnukBAgJpCeWpGan phakFsGMY+LglGpgzOK0NYtYmB4c+lGwR3yLVOfbA5mT267cf7G2ZUlM4zOnE9/cemcUuYfl hO4R58j/vjPj/vLujHu5zk8u7tV9q3G3dfnZoO+m3cHLEwKmPJ/gX810JZKRu6jz7A+/zA/t CleTnfpLHllJPJ34SCqw8m7ImXMJ8ta/NBtaU9SySq9qSAnpZnoqsRRnJBpqMRcVJwIAkJfx WZ8CAAA= X-CFilter-Loop: Reflected Cc: jy0.jeon@samsung.com, sw0312.kim@samsung.com, jaejoon.seo@samsung.com, kyungmin.park@samsung.com, jmock.shin@samsung.com, lsmin.lee@samsung.com, th908.kim@samsung.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org This patch removes property error handling. because property couldn't be NULL. Signed-off-by: Eunchul Kim --- drivers/gpu/drm/exynos/exynos_drm_fimc.c | 12 ------------ drivers/gpu/drm/exynos/exynos_drm_gsc.c | 12 ------------ drivers/gpu/drm/exynos/exynos_drm_ipp.c | 5 ----- 3 files changed, 0 insertions(+), 29 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c b/drivers/gpu/drm/exynos/exynos_drm_fimc.c index 7a3e460..5dc0251 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fimc.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fimc.c @@ -705,10 +705,6 @@ static int fimc_src_set_addr(struct device *dev, } property = &c_node->property; - if (!property) { - DRM_ERROR("failed to get property.\n"); - return -EINVAL; - } DRM_DEBUG_KMS("%s:prop_id[%d]buf_id[%d]buf_type[%d]\n", __func__, property->prop_id, buf_id, buf_type); @@ -1241,10 +1237,6 @@ static int fimc_dst_set_addr(struct device *dev, } property = &c_node->property; - if (!property) { - DRM_ERROR("failed to get property.\n"); - return -EINVAL; - } DRM_DEBUG_KMS("%s:prop_id[%d]buf_id[%d]buf_type[%d]\n", __func__, property->prop_id, buf_id, buf_type); @@ -1573,10 +1565,6 @@ static int fimc_ippdrv_start(struct device *dev, enum drm_exynos_ipp_cmd cmd) } property = &c_node->property; - if (!property) { - DRM_ERROR("failed to get property.\n"); - return -EINVAL; - } fimc_handle_irq(ctx, true, false, true); diff --git a/drivers/gpu/drm/exynos/exynos_drm_gsc.c b/drivers/gpu/drm/exynos/exynos_drm_gsc.c index c443c3b..ba5fefd 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_gsc.c +++ b/drivers/gpu/drm/exynos/exynos_drm_gsc.c @@ -720,10 +720,6 @@ static int gsc_src_set_addr(struct device *dev, } property = &c_node->property; - if (!property) { - DRM_ERROR("failed to get property.\n"); - return -EFAULT; - } DRM_DEBUG_KMS("%s:prop_id[%d]buf_id[%d]buf_type[%d]\n", __func__, property->prop_id, buf_id, buf_type); @@ -1180,10 +1176,6 @@ static int gsc_dst_set_addr(struct device *dev, } property = &c_node->property; - if (!property) { - DRM_ERROR("failed to get property.\n"); - return -EFAULT; - } DRM_DEBUG_KMS("%s:prop_id[%d]buf_id[%d]buf_type[%d]\n", __func__, property->prop_id, buf_id, buf_type); @@ -1565,10 +1557,6 @@ static int gsc_ippdrv_start(struct device *dev, enum drm_exynos_ipp_cmd cmd) } property = &c_node->property; - if (!property) { - DRM_ERROR("failed to get property.\n"); - return -EINVAL; - } gsc_handle_irq(ctx, true, false, true); diff --git a/drivers/gpu/drm/exynos/exynos_drm_ipp.c b/drivers/gpu/drm/exynos/exynos_drm_ipp.c index ba45f9a..cac94fe 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_ipp.c +++ b/drivers/gpu/drm/exynos/exynos_drm_ipp.c @@ -1487,11 +1487,6 @@ void ipp_sched_cmd(struct work_struct *work) mutex_lock(&c_node->cmd_lock); property = &c_node->property; - if (!property) { - DRM_ERROR("failed to get property:prop_id[%d]\n", - c_node->property.prop_id); - goto err_unlock; - } switch (cmd_work->ctrl) { case IPP_CTRL_PLAY: