Message ID | 1358908049.18561.12.camel@suxuemin.sh.intel.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
On Tue, Jan 22, 2013 at 9:27 PM, Su, Xuemin <xuemin.su@intel.com> wrote: > From: xueminsu <xuemin.su@intel.com> > Date: Tue, 22 Jan 2013 22:16:53 +0800 > Subject: [PATCH] radeon_display: Use pointer return error codes > > drm_mode_addfb() expects fb_create return error code > instead of NULL. > > Signed-off-by: xueminsu <xuemin.su@intel.com> Thanks. Added to my fixes queue. Alex > --- > drivers/gpu/drm/radeon/radeon_display.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c > index 1da2386..ff3def7 100644 > --- a/drivers/gpu/drm/radeon/radeon_display.c > +++ b/drivers/gpu/drm/radeon/radeon_display.c > @@ -1122,7 +1122,7 @@ radeon_user_framebuffer_create(struct drm_device *dev, > if (ret) { > kfree(radeon_fb); > drm_gem_object_unreference_unlocked(obj); > - return NULL; > + return ERR_PTR(ret); > } > > return &radeon_fb->base; > -- > 1.7.6 > > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c index 1da2386..ff3def7 100644 --- a/drivers/gpu/drm/radeon/radeon_display.c +++ b/drivers/gpu/drm/radeon/radeon_display.c @@ -1122,7 +1122,7 @@ radeon_user_framebuffer_create(struct drm_device *dev, if (ret) { kfree(radeon_fb); drm_gem_object_unreference_unlocked(obj); - return NULL; + return ERR_PTR(ret); } return &radeon_fb->base;