diff mbox

drm/radeon: remove overzealous warning in hdmi handling

Message ID 1360676459-14496-1-git-send-email-alexdeucher@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Alex Deucher Feb. 12, 2013, 1:40 p.m. UTC 
From: Alex Deucher <alexander.deucher@amd.com>

hdmi audio works fine.  The warning just confuses users.

fixes:
https://bugzilla.kernel.org/show_bug.cgi?id=44341

Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
---
 drivers/gpu/drm/radeon/r600_hdmi.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

Comments

Jerome Glisse Feb. 12, 2013, 6:21 p.m. UTC | #1 
On Tue, Feb 12, 2013 at 8:40 AM,  <alexdeucher@gmail.com> wrote:
> From: Alex Deucher <alexander.deucher@amd.com>
>
> hdmi audio works fine.  The warning just confuses users.
>
> fixes:
> https://bugzilla.kernel.org/show_bug.cgi?id=44341
>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: Jerome Glisse <jglisse@redhat.com>
> Cc: stable@vger.kernel.org
> ---
>  drivers/gpu/drm/radeon/r600_hdmi.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/r600_hdmi.c b/drivers/gpu/drm/radeon/r600_hdmi.c
> index ff80efe..95970ec 100644
> --- a/drivers/gpu/drm/radeon/r600_hdmi.c
> +++ b/drivers/gpu/drm/radeon/r600_hdmi.c
> @@ -544,7 +544,6 @@ void r600_hdmi_disable(struct drm_encoder *encoder)
>
>         /* Called for ATOM_ENCODER_MODE_HDMI only */
>         if (!dig || !dig->afmt) {
> -               WARN_ON(1);
>                 return;
>         }
>         if (!dig->afmt->enabled)
> --
> 1.7.7.5
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
diff mbox

Patch

diff --git a/drivers/gpu/drm/radeon/r600_hdmi.c b/drivers/gpu/drm/radeon/r600_hdmi.c
index ff80efe..95970ec 100644
--- a/drivers/gpu/drm/radeon/r600_hdmi.c
+++ b/drivers/gpu/drm/radeon/r600_hdmi.c
@@ -544,7 +544,6 @@  void r600_hdmi_disable(struct drm_encoder *encoder)
 
 	/* Called for ATOM_ENCODER_MODE_HDMI only */
 	if (!dig || !dig->afmt) {
-		WARN_ON(1);
 		return;
 	}
 	if (!dig->afmt->enabled)