diff mbox

gma500: medfield: Fix possible NULL pointer dereference

Message ID 1361745108-28378-1-git-send-email-s.syam@samsung.com (mailing list archive)
State New, archived
Headers show

Commit Message

Syam Sidhardhan Feb. 24, 2013, 10:31 p.m. UTC 
The use of pointer sender should be after the NULL check.

Signed-off-by: Syam Sidhardhan <s.syam@samsung.com>
---
 drivers/gpu/drm/gma500/mdfld_dsi_output.c |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

Comments

Patrik Jakobsson Feb. 25, 2013, 11:55 a.m. UTC | #1 
On Mon, Feb 25, 2013 at 04:01:48AM +0530, Syam Sidhardhan wrote:
> The use of pointer sender should be after the NULL check.
> 
> Signed-off-by: Syam Sidhardhan <s.syam@samsung.com>
> ---
>  drivers/gpu/drm/gma500/mdfld_dsi_output.c |    7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/gma500/mdfld_dsi_output.c b/drivers/gpu/drm/gma500/mdfld_dsi_output.c
> index 2d4ab48..3abf831 100644
> --- a/drivers/gpu/drm/gma500/mdfld_dsi_output.c
> +++ b/drivers/gpu/drm/gma500/mdfld_dsi_output.c
> @@ -92,8 +92,8 @@ void mdfld_dsi_brightness_init(struct mdfld_dsi_config *dsi_config, int pipe)
>  {
>  	struct mdfld_dsi_pkg_sender *sender =
>  				mdfld_dsi_get_pkg_sender(dsi_config);
> -	struct drm_device *dev = sender->dev;
> -	struct drm_psb_private *dev_priv = dev->dev_private;
> +	struct drm_device *dev;
> +	struct drm_psb_private *dev_priv;
>  	u32 gen_ctrl_val;
>  
>  	if (!sender) {
> @@ -101,6 +101,9 @@ void mdfld_dsi_brightness_init(struct mdfld_dsi_config *dsi_config, int pipe)
>  		return;
>  	}
>  
> +	dev = sender->dev;
> +	dev_priv = dev->dev_private;
> +
>  	/* Set default display backlight value to 85% (0xd8)*/
>  	mdfld_dsi_send_mcs_short(sender, write_display_brightness, 0xd8, 1,
>  				true);

Reviewed-by: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
Patrik Jakobsson April 2, 2013, 1:04 p.m. UTC | #2 
On Sun, Feb 24, 2013 at 11:31 PM, Syam Sidhardhan
<syamsidhardh@gmail.com> wrote:
> The use of pointer sender should be after the NULL check.
>
> Signed-off-by: Syam Sidhardhan <s.syam@samsung.com>
> ---
>  drivers/gpu/drm/gma500/mdfld_dsi_output.c |    7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/gma500/mdfld_dsi_output.c b/drivers/gpu/drm/gma500/mdfld_dsi_output.c
> index 2d4ab48..3abf831 100644
> --- a/drivers/gpu/drm/gma500/mdfld_dsi_output.c
> +++ b/drivers/gpu/drm/gma500/mdfld_dsi_output.c
> @@ -92,8 +92,8 @@ void mdfld_dsi_brightness_init(struct mdfld_dsi_config *dsi_config, int pipe)
>  {
>         struct mdfld_dsi_pkg_sender *sender =
>                                 mdfld_dsi_get_pkg_sender(dsi_config);
> -       struct drm_device *dev = sender->dev;
> -       struct drm_psb_private *dev_priv = dev->dev_private;
> +       struct drm_device *dev;
> +       struct drm_psb_private *dev_priv;
>         u32 gen_ctrl_val;
>
>         if (!sender) {
> @@ -101,6 +101,9 @@ void mdfld_dsi_brightness_init(struct mdfld_dsi_config *dsi_config, int pipe)
>                 return;
>         }
>
> +       dev = sender->dev;
> +       dev_priv = dev->dev_private;
> +
>         /* Set default display backlight value to 85% (0xd8)*/
>         mdfld_dsi_send_mcs_short(sender, write_display_brightness, 0xd8, 1,
>                                 true);
> --
> 1.7.9.5

Your patch has been applied to:
https://github.com/patjak/drm-gma500.git gma500-next

Thanks
Patrik Jakobsson
diff mbox

Patch

diff --git a/drivers/gpu/drm/gma500/mdfld_dsi_output.c b/drivers/gpu/drm/gma500/mdfld_dsi_output.c
index 2d4ab48..3abf831 100644
--- a/drivers/gpu/drm/gma500/mdfld_dsi_output.c
+++ b/drivers/gpu/drm/gma500/mdfld_dsi_output.c
@@ -92,8 +92,8 @@  void mdfld_dsi_brightness_init(struct mdfld_dsi_config *dsi_config, int pipe)
 {
 	struct mdfld_dsi_pkg_sender *sender =
 				mdfld_dsi_get_pkg_sender(dsi_config);
-	struct drm_device *dev = sender->dev;
-	struct drm_psb_private *dev_priv = dev->dev_private;
+	struct drm_device *dev;
+	struct drm_psb_private *dev_priv;
 	u32 gen_ctrl_val;
 
 	if (!sender) {
@@ -101,6 +101,9 @@  void mdfld_dsi_brightness_init(struct mdfld_dsi_config *dsi_config, int pipe)
 		return;
 	}
 
+	dev = sender->dev;
+	dev_priv = dev->dev_private;
+
 	/* Set default display backlight value to 85% (0xd8)*/
 	mdfld_dsi_send_mcs_short(sender, write_display_brightness, 0xd8, 1,
 				true);