From patchwork Sun Feb 24 22:31:48 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Syam Sidhardhan X-Patchwork-Id: 2180481 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by patchwork2.kernel.org (Postfix) with ESMTP id 6EDD3DF230 for ; Mon, 25 Feb 2013 09:58:00 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 47E15E6244 for ; Mon, 25 Feb 2013 01:58:00 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pb0-f48.google.com (mail-pb0-f48.google.com [209.85.160.48]) by gabe.freedesktop.org (Postfix) with ESMTP id D029CE61D7 for ; Sun, 24 Feb 2013 14:31:59 -0800 (PST) Received: by mail-pb0-f48.google.com with SMTP id wy12so1308967pbc.7 for ; Sun, 24 Feb 2013 14:31:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer; bh=T6OB+1ziEZf6bXKw1F/30vN6uqY/cMV4A7mXBiKR0Zg=; b=JUtKX7yEKZIk3Ex9Uj4OdezjAtDPlt73Ipmr4Rb3Ngyk9RcARYSN3sKYRMrAOMEUx+ mQ74CFmww5pvONzASaNU9h+p4YX3+ImO2M6gWfFyMHB+KWroZPsG8U5+hmqIO8n9ZAME 6ZNW046MUDpStc+NkADDnXtwiOe+/vQy1XVYFyIfAIFrdM7GBd+nmN+PlebODNU4XB0U q/LlWxGiyHKbV9jBgrspJJ+cW+GS23ofKL1z5nV1lJXMUoDcCN/teUg3n8NESze/7WUY urD2+yser9yQOxm0MLyGEEfjV9pWx2wUlLf9pDKSp3CDlr0qH/qwhWDFF7fIrXGUxTJM IXxQ== X-Received: by 10.66.216.231 with SMTP id ot7mr15688334pac.173.1361745119667; Sun, 24 Feb 2013 14:31:59 -0800 (PST) Received: from localhost.localdomain ([27.7.134.34]) by mx.google.com with ESMTPS id ub1sm10402607pbc.5.2013.02.24.14.31.56 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 24 Feb 2013 14:31:58 -0800 (PST) From: Syam Sidhardhan To: dri-devel@lists.freedesktop.org Subject: [PATCH] gma500: medfield: Fix possible NULL pointer dereference Date: Mon, 25 Feb 2013 04:01:48 +0530 Message-Id: <1361745108-28378-1-git-send-email-s.syam@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Mailman-Approved-At: Mon, 25 Feb 2013 01:57:47 -0800 Cc: syamsidhardh@gmail.com, alan@linux.intel.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org The use of pointer sender should be after the NULL check. Signed-off-by: Syam Sidhardhan Reviewed-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/mdfld_dsi_output.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/gma500/mdfld_dsi_output.c b/drivers/gpu/drm/gma500/mdfld_dsi_output.c index 2d4ab48..3abf831 100644 --- a/drivers/gpu/drm/gma500/mdfld_dsi_output.c +++ b/drivers/gpu/drm/gma500/mdfld_dsi_output.c @@ -92,8 +92,8 @@ void mdfld_dsi_brightness_init(struct mdfld_dsi_config *dsi_config, int pipe) { struct mdfld_dsi_pkg_sender *sender = mdfld_dsi_get_pkg_sender(dsi_config); - struct drm_device *dev = sender->dev; - struct drm_psb_private *dev_priv = dev->dev_private; + struct drm_device *dev; + struct drm_psb_private *dev_priv; u32 gen_ctrl_val; if (!sender) { @@ -101,6 +101,9 @@ void mdfld_dsi_brightness_init(struct mdfld_dsi_config *dsi_config, int pipe) return; } + dev = sender->dev; + dev_priv = dev->dev_private; + /* Set default display backlight value to 85% (0xd8)*/ mdfld_dsi_send_mcs_short(sender, write_display_brightness, 0xd8, 1, true);