From patchwork Wed Mar 6 20:02:33 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joe Perches X-Patchwork-Id: 2228241 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by patchwork2.kernel.org (Postfix) with ESMTP id E3602DF23A for ; Wed, 6 Mar 2013 21:02:47 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B5422E685D for ; Wed, 6 Mar 2013 13:02:47 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org X-Greylist: delayed 3600 seconds by postgrey-1.32 at gabe; Wed, 06 Mar 2013 13:02:35 PST Received: from labridge.com (perches-mx.perches.com [206.117.179.246]) by gabe.freedesktop.org (Postfix) with ESMTP id 4578BE5EB3; Wed, 6 Mar 2013 13:02:35 -0800 (PST) Received: from [173.51.221.202] (account joe@perches.com HELO [192.168.1.151]) by labridge.com (CommuniGate Pro SMTP 5.0.14) with ESMTPA id 20769270; Wed, 06 Mar 2013 12:02:34 -0800 Message-ID: <1362600153.1759.58.camel@joe-AO722> Subject: Re: nouveau lockdep splat From: Joe Perches To: Stephen Warren Date: Wed, 06 Mar 2013 12:02:33 -0800 In-Reply-To: <513799A5.3010609@wwwdotorg.org> References: <20130304211608.GD22274@pd.tnic> <1362501052.1933.2.camel@antimon> <20130306000429.GA30189@pd.tnic> <20130306191418.GA3400@joi.lan> <513799A5.3010609@wwwdotorg.org> X-Mailer: Evolution 3.6.2-0ubuntu0.1 Mime-Version: 1.0 Cc: Stephen Warren , nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Borislav Petkov , Andrew Morton X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org On Wed, 2013-03-06 at 12:31 -0700, Stephen Warren wrote: > On 03/06/2013 12:14 PM, Marcin Slusarz wrote: > > On Wed, Mar 06, 2013 at 01:04:29AM +0100, Borislav Petkov wrote: > >> On Tue, Mar 05, 2013 at 05:30:52PM +0100, Lucas Stach wrote: > >>> Dropping Tegra ML, it's not the place where Nouveau mails should go. > >> > >> $ ./scripts/get_maintainer.pl -f drivers/gpu/drm/nouveau/nv50_display.c > >> ... > >> linux-tegra@vger.kernel.org (open list:TEGRA SUPPORT) > >> > >> Maybe get_maintainer.pl patterns need correction... > > > > That's new feature (introduced in commit eb90d0855b75f8 "get_maintainer: allow > > keywords to match filenames") of get_maintainer.pl which now can look at file > > contents... > > get_maintainer.pl could always look at file contents IIRC. The change > was that I added keyword "tegra" to the Tegra section that now matches > this file's contents. > > ./scripts/get_maintainer.pl -f drivers/gpu/drm/nouveau > > ... might be a better invocation, although perhaps I should add an > explicit exclusion for "nouveau" to the Tegra section in MAINTAINERS. Another option might be avoid overloading the "K:" entry and use a different letter for the file name pattern match (maybe "N") and avoid looking for tegra in the file or patch without another specific "K:" keyword match. Maybe: --- MAINTAINERS | 10 +++++++--- scripts/get_maintainer.pl | 2 +- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index e95b1e9..76e0223 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -96,10 +96,14 @@ Descriptions of section entries: F: net/ X: net/ipv6/ matches all files in and below net excluding net/ipv6/ + N: Filename wildcard pattern match, for instance: + N: (?i)[^a-z]tegra + matches any filename with case insensitive "tegra" but not + any other word like integrate K: Keyword perl extended regex pattern to match content in a - patch or file, or an affected filename. For instance: + patch or file. For instance: K: of_get_profile - matches patch or file content, or filenames, that contain + matches patch or file content, that contain "of_get_profile" K: \b(printk|pr_(info|err))\b matches patch or file content, or filenames, that contain one or @@ -7866,7 +7870,7 @@ L: linux-tegra@vger.kernel.org Q: http://patchwork.ozlabs.org/project/linux-tegra/list/ T: git git://git.kernel.org/pub/scm/linux/kernel/git/swarren/linux-tegra.git S: Supported -K: (?i)[^a-z]tegra +N: (?i)[^a-z]tegra TEHUTI ETHERNET DRIVER M: Andy Gospodarek diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl index ce4cc83..5e4fb14 100755 --- a/scripts/get_maintainer.pl +++ b/scripts/get_maintainer.pl @@ -611,7 +611,7 @@ sub get_maintainers { $hash{$tvi} = $value_pd; } } - } elsif ($type eq 'K') { + } elsif ($type eq 'N') { if ($file =~ m/$value/x) { $hash{$tvi} = 0; }