From patchwork Thu Mar 21 10:03:57 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 2319051 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by patchwork1.kernel.org (Postfix) with ESMTP id 16BAF3FD8C for ; Fri, 22 Mar 2013 11:33:26 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D28B6E630B for ; Fri, 22 Mar 2013 04:33:25 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-da0-f52.google.com (mail-da0-f52.google.com [209.85.210.52]) by gabe.freedesktop.org (Postfix) with ESMTP id 967A3E5DC3 for ; Thu, 21 Mar 2013 03:15:10 -0700 (PDT) Received: by mail-da0-f52.google.com with SMTP id f10so1566020dak.39 for ; Thu, 21 Mar 2013 03:15:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer :x-gm-message-state; bh=3pbsQufh70qKW99eLIDsbWsvnGaXXDuMLS9my1tu8d0=; b=oaH3Eccy4kTb/FSnxQZKrzhL6ea9UoVOfwzW1A1QoErVpvGudcAMqMm5xvtQ+URoXi +ihLfV1CrKmxl24yBJ0ZxxGK4VpfuSXTTVgRy4wX9aRv7M28TgVuNBp2/gjbL6qCEFlW iVyVoAQkzFq1CVJ9WdxfAWwuvvMJqRRgbTnZY7B82zWRcI2Mm3Deo4htiqX9hdHYam1E DkImVpuu03fi0P5Ni8/szypWrL7v0uvgI/Sz4gwASTAfBQNLzmh+o+bVYB1UUI3d/K68 dNKVV878SLob3iWO5XrIO7p5ByErop4hVfjCAhO9EpV/RuDU6ErZwR3NNJX4Y/VFKGL1 TGJw== X-Received: by 10.67.14.105 with SMTP id ff9mr14322656pad.101.1363860910369; Thu, 21 Mar 2013 03:15:10 -0700 (PDT) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id yr10sm5989471pab.6.2013.03.21.03.15.07 (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 21 Mar 2013 03:15:09 -0700 (PDT) From: Sachin Kamat To: dri-devel@lists.freedesktop.org Subject: [PATCH 1/3] drm/exynos: hdmi: Fix incorrect usage of IS_ERR_OR_NULL Date: Thu, 21 Mar 2013 15:33:57 +0530 Message-Id: <1363860239-916-1-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 X-Gm-Message-State: ALoCoQkbwUx7zdQ3uhwnA7VO0otXdknYTMKL3BODJjep3Nq05ZqsEaplOwJS3shXj07iF+4Y7PiS X-Mailman-Approved-At: Fri, 22 Mar 2013 04:33:08 -0700 Cc: sachin.kamat@linaro.org, patches@linaro.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Use IS_ERR instead of IS_ERR_OR_NULL on clk_get results. Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_hdmi.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c index 2c5f266..10757b6 100644 --- a/drivers/gpu/drm/exynos/exynos_hdmi.c +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c @@ -2023,27 +2023,27 @@ static int hdmi_resources_init(struct hdmi_context *hdata) /* get clocks, power */ res->hdmi = devm_clk_get(dev, "hdmi"); - if (IS_ERR_OR_NULL(res->hdmi)) { + if (IS_ERR(res->hdmi)) { DRM_ERROR("failed to get clock 'hdmi'\n"); goto fail; } res->sclk_hdmi = devm_clk_get(dev, "sclk_hdmi"); - if (IS_ERR_OR_NULL(res->sclk_hdmi)) { + if (IS_ERR(res->sclk_hdmi)) { DRM_ERROR("failed to get clock 'sclk_hdmi'\n"); goto fail; } res->sclk_pixel = devm_clk_get(dev, "sclk_pixel"); - if (IS_ERR_OR_NULL(res->sclk_pixel)) { + if (IS_ERR(res->sclk_pixel)) { DRM_ERROR("failed to get clock 'sclk_pixel'\n"); goto fail; } res->sclk_hdmiphy = devm_clk_get(dev, "sclk_hdmiphy"); - if (IS_ERR_OR_NULL(res->sclk_hdmiphy)) { + if (IS_ERR(res->sclk_hdmiphy)) { DRM_ERROR("failed to get clock 'sclk_hdmiphy'\n"); goto fail; } res->hdmiphy = devm_clk_get(dev, "hdmiphy"); - if (IS_ERR_OR_NULL(res->hdmiphy)) { + if (IS_ERR(res->hdmiphy)) { DRM_ERROR("failed to get clock 'hdmiphy'\n"); goto fail; }