From patchwork Mon Apr 1 18:12:24 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guenter Roeck X-Patchwork-Id: 2376061 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by patchwork2.kernel.org (Postfix) with ESMTP id 87512DF2A1 for ; Tue, 2 Apr 2013 06:18:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 66797E62C7 for ; Mon, 1 Apr 2013 23:18:04 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org X-Greylist: delayed 402 seconds by postgrey-1.32 at gabe; Mon, 01 Apr 2013 11:19:12 PDT Received: from mail.active-venture.com (mail.active-venture.com [67.228.131.205]) by gabe.freedesktop.org (Postfix) with ESMTP id 2BCE4E5C72 for ; Mon, 1 Apr 2013 11:19:12 -0700 (PDT) Received: (qmail 56771 invoked by uid 399); 1 Apr 2013 18:12:30 -0000 X-Virus-Scan: Scanned by ClamAV 0.97.2 (no viruses); Mon, 01 Apr 2013 13:12:30 -0500 Received: from unknown (HELO localhost) (guenter@roeck-us.net@108.223.40.66) by mail.active-venture.com with ESMTPAM; 1 Apr 2013 18:12:29 -0000 X-Originating-IP: 108.223.40.66 X-Sender: guenter@roeck-us.net From: Guenter Roeck To: dri-devel@lists.freedesktop.org Subject: [PATCH] drm/tilcdc: Disable building as module Date: Mon, 1 Apr 2013 11:12:24 -0700 Message-Id: <1364839944-4863-1-git-send-email-linux@roeck-us.net> X-Mailer: git-send-email 1.7.9.7 X-Mailman-Approved-At: Mon, 01 Apr 2013 22:32:25 -0700 Cc: Russell King , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Guenter Roeck X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Attempts to compile tilcdc as module results in: drivers/gpu/drm/tilcdc/tilcdc_slave.o:(.data+0x54): multiple definition of `__mod_of_device_table' drivers/gpu/drm/tilcdc/tilcdc_tfp410.o:(.data+0x54): first defined here drivers/gpu/drm/tilcdc/tilcdc_panel.o:(.data+0x54): multiple definition of `__mod_of_device_table' drivers/gpu/drm/tilcdc/tilcdc_tfp410.o:(.data+0x54): first defined here drivers/gpu/drm/tilcdc/tilcdc_drv.o:(.data+0x184): multiple definition of `__mod_of_device_table' drivers/gpu/drm/tilcdc/tilcdc_tfp410.o:(.data+0x54): first defined here make[5]: [drivers/gpu/drm/tilcdc/tilcdc.o] Error 1 (ignored) It appears it was never even tried to build it as module, or the problem would have been seen. So running this driver as module was never really tested. Disable it. If really needed, the code wil require some structural changes and in-depth testing, which can and should be done separately. Cc: Rob Clark Signed-off-by: Guenter Roeck --- drivers/gpu/drm/tilcdc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tilcdc/Kconfig b/drivers/gpu/drm/tilcdc/Kconfig index d24d040..6ddb729 100644 --- a/drivers/gpu/drm/tilcdc/Kconfig +++ b/drivers/gpu/drm/tilcdc/Kconfig @@ -1,5 +1,5 @@ config DRM_TILCDC - tristate "DRM Support for TI LCDC Display Controller" + bool "DRM Support for TI LCDC Display Controller" depends on DRM && OF && ARM select DRM_KMS_HELPER select DRM_KMS_CMA_HELPER