From patchwork Tue Apr 16 17:31:24 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Sylwester Nawrocki/Kernel \\(PLT\\) /SRPOL/Staff Engineer/Samsung Electronics" X-Patchwork-Id: 2450241 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by patchwork1.kernel.org (Postfix) with ESMTP id C17053FD40 for ; Tue, 16 Apr 2013 17:33:20 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 74A25E64F0 for ; Tue, 16 Apr 2013 10:33:20 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 16231E5DF3 for ; Tue, 16 Apr 2013 10:33:06 -0700 (PDT) Received: from epcpsbgm1.samsung.com (epcpsbgm1 [203.254.230.26]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MLC003M0ZF5PP00@mailout1.samsung.com> for dri-devel@lists.freedesktop.org; Wed, 17 Apr 2013 02:33:05 +0900 (KST) X-AuditID: cbfee61a-b7fa86d0000045ae-61-516d8b50abf9 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 78.E7.17838.05B8D615; Wed, 17 Apr 2013 02:33:05 +0900 (KST) Received: from amdc1344.digital.local ([106.116.147.32]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MLC00F3DZCLP530@mmp1.samsung.com>; Wed, 17 Apr 2013 02:33:04 +0900 (KST) From: Sylwester Nawrocki To: inki.dae@samsung.com Subject: [PATCH 1/3] drm/exynos: Remove redundant devm_kfree() Date: Tue, 16 Apr 2013 19:31:24 +0200 Message-id: <1366133486-22973-2-git-send-email-s.nawrocki@samsung.com> X-Mailer: git-send-email 1.7.9.5 In-reply-to: <1366133486-22973-1-git-send-email-s.nawrocki@samsung.com> References: <1366133486-22973-1-git-send-email-s.nawrocki@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupkluLIzCtJLcpLzFFi42I5/e+xgG5gd26gwZQJzBYHZj9ktbjy9T2b xaT7E1gszja9YbeYcX4fk8XhN+2sDmwe97uPM3mcn7GQ0aNvyypGj8+b5AJYorhsUlJzMstS i/TtErgyuiefYS2YwlnxaG43ewPjG/YuRk4OCQETia/LdjFB2GISF+6tZwOxhQQWMUp0rtDq YuQCsjuYJP5sPAWWYBMwlOg92scIYosISEjMfHWRCaSIWWA7o8T0H0dYQBLCAnYSG3a9Aiti EVCVWLL2AFicV8BNYsGbk6xdjBxA2xQk5kyyAQlzCrhLfFu/lwlisZvE/o6rrBMYeRcwMqxi FE0tSC4oTkrPNdQrTswtLs1L10vOz93ECA6gZ1I7GFc2WBxiFOBgVOLhvVCQGyjEmlhWXJl7 iFGCg1lJhPesI1CINyWxsiq1KD++qDQntfgQozQHi5I474FW60AhgfTEktTs1NSC1CKYLBMH p1QDo/6GxW6Gnkcb1LJ9JySt4nqYu/9o1b7/Lx7l+8VaSSzrlEhl0XdkSn2q91i8MrG0tJ6B y4HFMG1mtN7eV4a7NB3OhK92vN9ewd/euOZXuu/3e3cvmz5ae0YtoPDnrfylpb7//4j4+L+t 2LZ6jZOwuk/NZ/8nP30m5VdmCqpbTDyYMVuKZUKDEktxRqKhFnNRcSIAKOFrpRwCAAA= Cc: Sylwester Nawrocki , kyungmin.park@samsung.com, linux-samsung-soc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org There is no need for explicit calls of devm_kfree(), as the allocated memory will be freed during driver's detach. Remove the redundant devm_kfree() calls from probe() and remove() callbacks. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_fimc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c b/drivers/gpu/drm/exynos/exynos_drm_fimc.c index 411f69b7..d812c57 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fimc.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fimc.c @@ -1843,7 +1843,6 @@ static int fimc_probe(struct platform_device *pdev) return 0; err_ippdrv_register: - devm_kfree(dev, ippdrv->prop_list); pm_runtime_disable(dev); err_get_irq: free_irq(ctx->irq, ctx); @@ -1857,7 +1856,6 @@ static int fimc_remove(struct platform_device *pdev) struct fimc_context *ctx = get_fimc_context(dev); struct exynos_drm_ippdrv *ippdrv = &ctx->ippdrv; - devm_kfree(dev, ippdrv->prop_list); exynos_drm_ippdrv_unregister(ippdrv); mutex_destroy(&ctx->lock);