From patchwork Wed Apr 17 09:53:02 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Sylwester Nawrocki/Kernel \\(PLT\\) /SRPOL/Staff Engineer/Samsung Electronics" X-Patchwork-Id: 2452811 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by patchwork2.kernel.org (Postfix) with ESMTP id 79DDDDF23A for ; Wed, 17 Apr 2013 09:54:51 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 57195E5D1C for ; Wed, 17 Apr 2013 02:54:51 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 8628AE6013 for ; Wed, 17 Apr 2013 02:53:47 -0700 (PDT) Received: from epcpsbgm2.samsung.com (epcpsbgm2 [203.254.230.27]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MLE00HBH8T5CIM0@mailout1.samsung.com> for dri-devel@lists.freedesktop.org; Wed, 17 Apr 2013 18:53:46 +0900 (KST) X-AuditID: cbfee61b-b7f076d0000034b6-8c-516e712a59af Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 18.FC.13494.A217E615; Wed, 17 Apr 2013 18:53:46 +0900 (KST) Received: from amdc1344.digital.local ([106.116.147.32]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MLE00E5V8SNHG80@mmp1.samsung.com>; Wed, 17 Apr 2013 18:53:46 +0900 (KST) From: Sylwester Nawrocki To: inki.dae@samsung.com Subject: [PATCH v2 1/3] drm/exynos: Remove redundant devm_kfree() Date: Wed, 17 Apr 2013 11:53:02 +0200 Message-id: <1366192384-18829-2-git-send-email-s.nawrocki@samsung.com> X-Mailer: git-send-email 1.7.9.5 In-reply-to: <1366192384-18829-1-git-send-email-s.nawrocki@samsung.com> References: <1366192384-18829-1-git-send-email-s.nawrocki@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupkluLIzCtJLcpLzFFi42I5/e+xgK5WYV6gQccyeYsDsx+yWlz5+p7N YtL9CSwWZ5vesFvMOL+PyeLwm3ZWBzaP+93HmTzOz1jI6NG3ZRWjx+dNcgEsUVw2Kak5mWWp Rfp2CVwZ3ZPPsBZM4ax4NLebvYHxDXsXIyeHhICJxN2pvawQtpjEhXvr2boYuTiEBBYxStxY fpYZwulgkpjyaQ8bSBWbgKFE79E+RhBbREBCYuari0wgRcwC2xklpv84wgKSEBZwlFj+5i5Y A4uAqsS/bfPB1vEKuEls7V8PVMMBtE5BYs4kG5Awp4C7xNYXt5lAwkJAJbtbVSYw8i5gZFjF KJpakFxQnJSea6RXnJhbXJqXrpecn7uJERxAz6R3MK5qsDjEKMDBqMTDe6EgN1CINbGsuDL3 EKMEB7OSCO/8kLxAId6UxMqq1KL8+KLSnNTiQ4zSHCxK4rwHW60DhQTSE0tSs1NTC1KLYLJM HJxSDYzzbn2X0DngwLcpOn2tpRx7dLkI2/Wog3svvarYHKnzRud7mOLxzA97t+dryd34Hu44 s61n/ZolKsbefY7r6p6XWPnc1lKazCSYfa5r35+ykISmSSvP5n468Tpxi/HvrJdZr5Yeupbu sy5jntZXPpM+4aZAwf64TyUd6Yxd5zff2OuhrHLg5VklluKMREMt5qLiRACPm8k6HAIAAA== Cc: Sylwester Nawrocki , kyungmin.park@samsung.com, linux-samsung-soc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org There is no need for explicit calls of devm_kfree(), as the allocated memory will be freed during driver's detach. Remove the redundant devm_kfree() calls from probe() and remove() callbacks. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_fimc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c b/drivers/gpu/drm/exynos/exynos_drm_fimc.c index 411f69b7..d812c57 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fimc.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fimc.c @@ -1843,7 +1843,6 @@ static int fimc_probe(struct platform_device *pdev) return 0; err_ippdrv_register: - devm_kfree(dev, ippdrv->prop_list); pm_runtime_disable(dev); err_get_irq: free_irq(ctx->irq, ctx); @@ -1857,7 +1856,6 @@ static int fimc_remove(struct platform_device *pdev) struct fimc_context *ctx = get_fimc_context(dev); struct exynos_drm_ippdrv *ippdrv = &ctx->ippdrv; - devm_kfree(dev, ippdrv->prop_list); exynos_drm_ippdrv_unregister(ippdrv); mutex_destroy(&ctx->lock);