From patchwork Tue Apr 23 11:34:36 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Sylwester Nawrocki/Kernel \\(PLT\\) /SRPOL/Staff Engineer/Samsung Electronics" X-Patchwork-Id: 2477261 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by patchwork2.kernel.org (Postfix) with ESMTP id E984ADF2E5 for ; Tue, 23 Apr 2013 11:37:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9A5E6E6118 for ; Tue, 23 Apr 2013 04:37:50 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 1189EE60C3 for ; Tue, 23 Apr 2013 04:35:29 -0700 (PDT) Received: from epcpsbgm1.samsung.com (epcpsbgm1 [203.254.230.26]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MLP00C93HIXFM51@mailout1.samsung.com> for dri-devel@lists.freedesktop.org; Tue, 23 Apr 2013 20:35:28 +0900 (KST) X-AuditID: cbfee61a-b7f156d000002a55-73-517671ff0cf1 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id F5.C8.10837.FF176715; Tue, 23 Apr 2013 20:35:28 +0900 (KST) Received: from amdc1344.digital.local ([106.116.147.32]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MLP00JJYHI03840@mmp2.samsung.com>; Tue, 23 Apr 2013 20:35:27 +0900 (KST) From: Sylwester Nawrocki To: inki.dae@samsung.com Subject: [PATCH v3 1/3] drm/exynos: remove redundant devm_kfree() Date: Tue, 23 Apr 2013 13:34:36 +0200 Message-id: <1366716878-5692-2-git-send-email-s.nawrocki@samsung.com> X-Mailer: git-send-email 1.7.9.5 In-reply-to: <1366716878-5692-1-git-send-email-s.nawrocki@samsung.com> References: <1366716878-5692-1-git-send-email-s.nawrocki@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrJLMWRmVeSWpSXmKPExsVy+t9jQV2GorJAg0vNTBYvD85mtzgw+yGr xZWv79ksJt2fwGLxdtFKVovdW+YyWyzeYmtxtukNu8WM8/uYLCb/LbE4/Kad1WLG5JdsFjt3 P2J04PW4332cyeP8jIWMHn1bVjF6fN4kF8ASxWWTkpqTWZZapG+XwJXRPfkMa8EUzopHc7vZ GxjfsHcxcnBICJhIvHni08XICWSKSVy4t56ti5GLQ0hgOqPEw023mSGcDiaJO+v6GEGq2AQM JXqPQtgiAhISM19dZAIpYhZ4wiTR3bKeCSQhLOAosX/LI0aQDSwCqhL98ytAwrwCrhKbDi1k hFisIDFnkg1ImFPATWLC+5esILYQUMmWNxdZJzDyLmBkWMUomlqQXFCclJ5rqFecmFtcmpeu l5yfu4kRHIDPpHYwrmywOMQowMGoxMMr4F4aKMSaWFZcmXuIUYKDWUmEd2JeWaAQb0piZVVq UX58UWlOavEhRmkOFiVx3gOt1oFCAumJJanZqakFqUUwWSYOTqkGxhmtp1qO2JTrTvtnOPd1 p+tx9YfRh8z1j9zJnHfDY8rtY0t+Pk2wc7UL552/4Ca34D3mnRprNz46tS782GbZD1kbNqwo VbF+GnX3fsjU2Re3s4uY3FrYcU/+plbm+tMxtx8tETiWacoSIPGwYj6fePTVwAfzuDxfTZdk sk6NyW8O/1N9bXrsmz9KLMUZiYZazEXFiQC6BtDcPAIAAA== Cc: linux-samsung-soc@vger.kernel.org, jy0.jeon@samsung.com, devicetree-discuss@lists.ozlabs.org, sw0312.kim@samsung.com, jaejoon.seo@samsung.com, dri-devel@lists.freedesktop.org, kyungmin.park@samsung.com, jmock.shin@samsung.com, Sylwester Nawrocki , lsmin.lee@samsung.com, th908.kim@samsung.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org There is no need for explicit calls of devm_kfree(), as the allocated memory will be freed during driver's detach. Remove the redundant devm_kfree() calls from probe() and remove() callbacks. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_fimc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c b/drivers/gpu/drm/exynos/exynos_drm_fimc.c index 411f69b7..d812c57 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fimc.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fimc.c @@ -1843,7 +1843,6 @@ static int fimc_probe(struct platform_device *pdev) return 0; err_ippdrv_register: - devm_kfree(dev, ippdrv->prop_list); pm_runtime_disable(dev); err_get_irq: free_irq(ctx->irq, ctx); @@ -1857,7 +1856,6 @@ static int fimc_remove(struct platform_device *pdev) struct fimc_context *ctx = get_fimc_context(dev); struct exynos_drm_ippdrv *ippdrv = &ctx->ippdrv; - devm_kfree(dev, ippdrv->prop_list); exynos_drm_ippdrv_unregister(ippdrv); mutex_destroy(&ctx->lock);