| Message ID | 1366889766-8738-1-git-send-email-sachin.kamat@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 26 April 2013 10:11, Inki Dae <inki.dae@samsung.com> wrote: > > >> -----Original Message----- >> From: Sachin Kamat [mailto:sachin.kamat@linaro.org] >> Sent: Thursday, April 25, 2013 8:36 PM >> To: dri-devel@lists.freedesktop.org >> Cc: inki.dae@samsung.com; jy0922.shim@samsung.com; sachin.kamat@linaro.org >> Subject: [PATCH Resend] drm/exynos: Select VIDEOMODE_HELPERS for FIMD >> >> FIMD also requires video mode helper APIs. >> Without this patch we get the following build error: >> drivers/gpu/drm/exynos/exynos_drm_fimd.c:895: undefined reference to >> `of_get_fb_videomode' >> make: *** [vmlinux] Error 1 >> >> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> >> --- >> drivers/gpu/drm/exynos/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/gpu/drm/exynos/Kconfig >> b/drivers/gpu/drm/exynos/Kconfig >> index 406f32a..8edca41 100644 >> --- a/drivers/gpu/drm/exynos/Kconfig >> +++ b/drivers/gpu/drm/exynos/Kconfig >> @@ -27,6 +27,7 @@ config DRM_EXYNOS_FIMD >> depends on OF && DRM_EXYNOS && !FB_S3C && !ARCH_MULTIPLATFORM >> select OF_VIDEOMODE > > The above line isn't needed anymore. I just removed and merged it. Thanks Inki. > And I can't find this patch on dri-devel mailing list. Maybe you didn't still > subscribe dri-devel mailing list. Let me check what this problem is. dri-devel was supposed to be a open list. Has this been changed recently?
Hi Inki, On 26 April 2013 10:11, Inki Dae <inki.dae@samsung.com> wrote: > > The above line isn't needed anymore. I just removed and merged it. And I > can't find this patch on dri-devel mailing list. Maybe you didn't still > subscribe dri-devel mailing list. I could find this patch on the dri-devel mailing list. Here is the link: http://lists.freedesktop.org/archives/dri-devel/2013-April/037957.html
diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kconfig index 406f32a..8edca41 100644 --- a/drivers/gpu/drm/exynos/Kconfig +++ b/drivers/gpu/drm/exynos/Kconfig @@ -27,6 +27,7 @@ config DRM_EXYNOS_FIMD depends on OF && DRM_EXYNOS && !FB_S3C && !ARCH_MULTIPLATFORM select OF_VIDEOMODE select FB_MODE_HELPERS + select VIDEOMODE_HELPERS help Choose this option if you want to use Exynos FIMD for DRM.
FIMD also requires video mode helper APIs. Without this patch we get the following build error: drivers/gpu/drm/exynos/exynos_drm_fimd.c:895: undefined reference to `of_get_fb_videomode' make: *** [vmlinux] Error 1 Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> --- drivers/gpu/drm/exynos/Kconfig | 1 + 1 file changed, 1 insertion(+)