From patchwork Wed May 22 12:14:16 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Seung-Woo Kim X-Patchwork-Id: 2601541 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by patchwork1.kernel.org (Postfix) with ESMTP id DCDD73FD2B for ; Wed, 22 May 2013 12:17:20 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A38EDE636C for ; Wed, 22 May 2013 05:17:20 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout4.samsung.com (mailout4.samsung.com [203.254.224.34]) by gabe.freedesktop.org (Postfix) with ESMTP id 3731EE634C for ; Wed, 22 May 2013 05:14:15 -0700 (PDT) Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MN7006008NPGH40@mailout4.samsung.com> for dri-devel@lists.freedesktop.org; Wed, 22 May 2013 21:14:13 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [172.20.52.116]) by epcpsbgr4.samsung.com (EPCPMTA) with SMTP id 65.04.29708.596BC915; Wed, 22 May 2013 21:14:13 +0900 (KST) X-AuditID: cbfee690-b7f6f6d00000740c-70-519cb695b9a0 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 84.07.16109.596BC915; Wed, 22 May 2013 21:14:13 +0900 (KST) Received: from localhost.localdomain ([10.90.8.56]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MN700GSA8NNB920@mmp2.samsung.com>; Wed, 22 May 2013 21:14:13 +0900 (KST) From: Seung-Woo Kim To: dri-devel@lists.freedesktop.org, inki.dae@samsung.com Subject: [PATCH 3/4] drm/exynos: remove unnecessary devm_kfree Date: Wed, 22 May 2013 21:14:16 +0900 Message-id: <1369224857-18661-4-git-send-email-sw0312.kim@samsung.com> X-Mailer: git-send-email 1.7.4.1 In-reply-to: <1369224857-18661-1-git-send-email-sw0312.kim@samsung.com> References: <1369224857-18661-1-git-send-email-sw0312.kim@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrCLMWRmVeSWpSXmKPExsWyRsSkRHfqtjmBBrOOKVv0njvJZHHl63s2 i0n3J7BYnG16w24xY/JLNgdWj+3fHrB63O8+zuTRt2UVYwBzFJdNSmpOZllqkb5dAldGa/M7 9oK5fBUvLy9hbGCcw9PFyMkhIWAi0X/pGjuELSZx4d56ti5GLg4hgaWMEk0fZzPCFF3bdIoV IjGdUeLoiulQTjOTxJErK5hBqtgEdCT2L/nNCmKLCFhKPNj6GyzOLOAu0fzyGFhcWMBO4vrf f0wgNouAqkRz8zsWEJtXwE2i6fhKZohtChIL7r1lA7E5gXrnHbsNdp4QUM33T9dYQBZLCPxn k3i94QMzxCABiW+TDwElOIASshKbDkDNkZQ4uOIGywRG4QWMDKsYRVMLkguKk9KLTPSKE3OL S/PS9ZLzczcxAkP49L9nE3Yw3jtgfYgxGWjcRGYp0eR8YAzklcQbGpsZWZiamBobmVuakSas JM6r3mIdKCSQnliSmp2aWpBaFF9UmpNafIiRiYNTqoGR9fTnN653c+as+CXNvXnpJwfRy1O1 bJ67v1F2+5jqo2Dnu1AkWP+v1bG7pw+0yE9e0lkkrd91sq71YELbVgX1gMw5lm6J8jFZ9hae S7MMN5Xwaq9vMve0YDZmWhmf8+z55Jkh6eVxan++cdzM9Lf/WfKgjqPsUmbGXZXu1bMC5zf9 PmmwukKJpTgj0VCLuag4EQAPzxOOdwIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrIIsWRmVeSWpSXmKPExsVy+t9jQd2p2+YEGlw7LmPRe+4kk8WVr+/Z LCbdn8BicbbpDbvFjMkv2RxYPbZ/e8Dqcb/7OJNH35ZVjAHMUQ2MNhmpiSmpRQqpecn5KZl5 6bZK3sHxzvGmZgaGuoaWFuZKCnmJuam2Si4+AbpumTlAS5UUyhJzSoFCAYnFxUr6dpgmhIa4 6VrANEbo+oYEwfUYGaCBhDWMGa3N79gL5vJVvLy8hLGBcQ5PFyMnh4SAicS1TadYIWwxiQv3 1rN1MXJxCAlMZ5Q4umI6K4TTzCRx5MoKZpAqNgEdif1LfoN1iAhYSjzY+hsszizgLtH88hhY XFjATuL6339MIDaLgKpEc/M7FhCbV8BNoun4SmaIbQoSC+69ZQOxOYF65x27zQ5iCwHVfP90 jWUCI+8CRoZVjKKpBckFxUnpuYZ6xYm5xaV56XrJ+bmbGMER8kxqB+PKBotDjAIcjEo8vA9q ZwcKsSaWFVfmHmKU4GBWEuFVCJoTKMSbklhZlVqUH19UmpNafIgxGeiqicxSosn5wOjNK4k3 NDYxM7I0Mje0MDI2J01YSZz3QKt1oJBAemJJanZqakFqEcwWJg5OqQZGFt0E009sCvG3BMy/ TVohMvmH6OUkAf9qo/lNV3Ye+9e0++O6/U86Jslw273t1fSYPKkv5sKE3ecUc4M+vfgm+1uh lrv/Bee79FahLp1Y6/hbkjyfpnPIrngxS8zJ/i1Dzr6XpQEfavMWLJ/I+k3UROr8IW9ZiROS 2yde40zPmX0i0GvqEyYbJZbijERDLeai4kQAxmFwo9QCAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Cc: kyungmin.park@samsung.com, sw0312.kim@samsung.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org devm_kfree does not need for fail case of probe function and for remove function. Signed-off-by: Seung-Woo Kim --- drivers/gpu/drm/exynos/exynos_drm_gsc.c | 2 -- drivers/gpu/drm/exynos/exynos_drm_rotator.c | 2 -- 2 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_gsc.c b/drivers/gpu/drm/exynos/exynos_drm_gsc.c index 487595a..98032d6 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_gsc.c +++ b/drivers/gpu/drm/exynos/exynos_drm_gsc.c @@ -1748,7 +1748,6 @@ static int gsc_probe(struct platform_device *pdev) return 0; err_ippdrv_register: - devm_kfree(dev, ippdrv->prop_list); pm_runtime_disable(dev); err_get_irq: free_irq(ctx->irq, ctx); @@ -1761,7 +1760,6 @@ static int gsc_remove(struct platform_device *pdev) struct gsc_context *ctx = get_gsc_context(dev); struct exynos_drm_ippdrv *ippdrv = &ctx->ippdrv; - devm_kfree(dev, ippdrv->prop_list); exynos_drm_ippdrv_unregister(ippdrv); mutex_destroy(&ctx->lock); diff --git a/drivers/gpu/drm/exynos/exynos_drm_rotator.c b/drivers/gpu/drm/exynos/exynos_drm_rotator.c index 947f09f..3aa502a 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_rotator.c +++ b/drivers/gpu/drm/exynos/exynos_drm_rotator.c @@ -709,7 +709,6 @@ static int rotator_probe(struct platform_device *pdev) return 0; err_ippdrv_register: - devm_kfree(dev, ippdrv->prop_list); pm_runtime_disable(dev); err_clk_get: free_irq(rot->irq, rot); @@ -722,7 +721,6 @@ static int rotator_remove(struct platform_device *pdev) struct rot_context *rot = dev_get_drvdata(dev); struct exynos_drm_ippdrv *ippdrv = &rot->ippdrv; - devm_kfree(dev, ippdrv->prop_list); exynos_drm_ippdrv_unregister(ippdrv); pm_runtime_disable(dev);