| Message ID | 1370410478-32221-1-git-send-email-sw0312.kim@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
2013/6/5 Seung-Woo Kim <sw0312.kim@samsung.com> > The definition of regulator_bulk_enable is fixed with __must_check > and this causes following build warning. > warning: ignoring return value of 'regulator_bulk_enable', > declared with attribute warn_unused_result > This patch fixes to check return value of the function. > > Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com> > --- > drivers/gpu/drm/exynos/exynos_hdmi.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c > b/drivers/gpu/drm/exynos/exynos_hdmi.c > index 2f78532..f807b13 100644 > --- a/drivers/gpu/drm/exynos/exynos_hdmi.c > +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c > @@ -1699,7 +1699,9 @@ static void hdmi_poweron(struct hdmi_context *hdata) > > mutex_unlock(&hdata->hdmi_mutex); > > - regulator_bulk_enable(res->regul_count, res->regul_bulk); > + if (regulator_bulk_enable(res->regul_count, res->regul_bulk)) > + DRM_ERROR("failed to enable regulator bulk\n"); > Now it's not error case; having no return type, so just changed it into DRM_DEBUG_KMS. However, we need to add more exception codes to this function later. Applied. Thanks, Inki Dae > + > clk_enable(res->hdmiphy); > clk_enable(res->hdmi); > clk_enable(res->sclk_hdmi); > -- > 1.7.4.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel >
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c index 2f78532..f807b13 100644 --- a/drivers/gpu/drm/exynos/exynos_hdmi.c +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c @@ -1699,7 +1699,9 @@ static void hdmi_poweron(struct hdmi_context *hdata) mutex_unlock(&hdata->hdmi_mutex); - regulator_bulk_enable(res->regul_count, res->regul_bulk); + if (regulator_bulk_enable(res->regul_count, res->regul_bulk)) + DRM_ERROR("failed to enable regulator bulk\n"); + clk_enable(res->hdmiphy); clk_enable(res->hdmi); clk_enable(res->sclk_hdmi);
The definition of regulator_bulk_enable is fixed with __must_check and this causes following build warning. warning: ignoring return value of 'regulator_bulk_enable', declared with attribute warn_unused_result This patch fixes to check return value of the function. Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com> --- drivers/gpu/drm/exynos/exynos_hdmi.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)