| Message ID | 1370959891-8923-8-git-send-email-rahul.sharma@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hello Rahul, this patch is not related with others and it looks good to me. On 2013? 06? 11? 23:11, Rahul Sharma wrote: > Cleanup by removing flags variable from drm_hdmi_dt_parse_pdata > which is not used anywhere. Swtiching to of_get_named_gpio instead > of of_get_named_gpio_flags solved this. > > Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com> Acked-by: Seung-Woo Kim <sw0312.kim@samsung.com> > --- > drivers/gpu/drm/exynos/exynos_hdmi.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c > index 1eb5ffb..fc6a9b0 100644 > --- a/drivers/gpu/drm/exynos/exynos_hdmi.c > +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c > @@ -2081,7 +2081,6 @@ static struct s5p_hdmi_platform_data *drm_hdmi_dt_parse_pdata > { > struct device_node *np = dev->of_node; > struct s5p_hdmi_platform_data *pd; > - enum of_gpio_flags flags; > u32 value; > > pd = devm_kzalloc(dev, sizeof(*pd), GFP_KERNEL); > @@ -2095,7 +2094,7 @@ static struct s5p_hdmi_platform_data *drm_hdmi_dt_parse_pdata > goto err_data; > } > > - pd->hpd_gpio = of_get_named_gpio_flags(np, "hpd-gpio", 0, &flags); > + pd->hpd_gpio = of_get_named_gpio(np, "hpd-gpio", 0); > > return pd; > >
Applied. Thanks, Inki Dae 2013/6/14 ??? <sw0312.kim@samsung.com> > Hello Rahul, > > this patch is not related with others and it looks good to me. > > On 2013? 06? 11? 23:11, Rahul Sharma wrote: > > Cleanup by removing flags variable from drm_hdmi_dt_parse_pdata > > which is not used anywhere. Swtiching to of_get_named_gpio instead > > of of_get_named_gpio_flags solved this. > > > > Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com> > > Acked-by: Seung-Woo Kim <sw0312.kim@samsung.com> > > > --- > > drivers/gpu/drm/exynos/exynos_hdmi.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c > b/drivers/gpu/drm/exynos/exynos_hdmi.c > > index 1eb5ffb..fc6a9b0 100644 > > --- a/drivers/gpu/drm/exynos/exynos_hdmi.c > > +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c > > @@ -2081,7 +2081,6 @@ static struct s5p_hdmi_platform_data > *drm_hdmi_dt_parse_pdata > > { > > struct device_node *np = dev->of_node; > > struct s5p_hdmi_platform_data *pd; > > - enum of_gpio_flags flags; > > u32 value; > > > > pd = devm_kzalloc(dev, sizeof(*pd), GFP_KERNEL); > > @@ -2095,7 +2094,7 @@ static struct s5p_hdmi_platform_data > *drm_hdmi_dt_parse_pdata > > goto err_data; > > } > > > > - pd->hpd_gpio = of_get_named_gpio_flags(np, "hpd-gpio", 0, &flags); > > + pd->hpd_gpio = of_get_named_gpio(np, "hpd-gpio", 0); > > > > return pd; > > > > > > -- > Seung-Woo Kim > Samsung Software R&D Center > -- > > -- > To unsubscribe from this list: send the line "unsubscribe > linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
Thanks Mr. Dae, Please discard the REST of the patches in this series. I am posting a another patch-set which has all the patches independent of hdmiphy related changes. regards, Rahul Sharma. On Mon, Jun 17, 2013 at 8:22 AM, Inki Dae <inki.dae@samsung.com> wrote: > Applied. > > Thanks, > Inki Dae > > > 2013/6/14 ??? <sw0312.kim@samsung.com> >> >> Hello Rahul, >> >> this patch is not related with others and it looks good to me. >> >> On 2013? 06? 11? 23:11, Rahul Sharma wrote: >> > Cleanup by removing flags variable from drm_hdmi_dt_parse_pdata >> > which is not used anywhere. Swtiching to of_get_named_gpio instead >> > of of_get_named_gpio_flags solved this. >> > >> > Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com> >> >> Acked-by: Seung-Woo Kim <sw0312.kim@samsung.com> >> >> > --- >> > drivers/gpu/drm/exynos/exynos_hdmi.c | 3 +-- >> > 1 file changed, 1 insertion(+), 2 deletions(-) >> > >> > diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c >> > b/drivers/gpu/drm/exynos/exynos_hdmi.c >> > index 1eb5ffb..fc6a9b0 100644 >> > --- a/drivers/gpu/drm/exynos/exynos_hdmi.c >> > +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c >> > @@ -2081,7 +2081,6 @@ static struct s5p_hdmi_platform_data >> > *drm_hdmi_dt_parse_pdata >> > { >> > struct device_node *np = dev->of_node; >> > struct s5p_hdmi_platform_data *pd; >> > - enum of_gpio_flags flags; >> > u32 value; >> > >> > pd = devm_kzalloc(dev, sizeof(*pd), GFP_KERNEL); >> > @@ -2095,7 +2094,7 @@ static struct s5p_hdmi_platform_data >> > *drm_hdmi_dt_parse_pdata >> > goto err_data; >> > } >> > >> > - pd->hpd_gpio = of_get_named_gpio_flags(np, "hpd-gpio", 0, &flags); >> > + pd->hpd_gpio = of_get_named_gpio(np, "hpd-gpio", 0); >> > >> > return pd; >> > >> > >> >> -- >> Seung-Woo Kim >> Samsung Software R&D Center >> -- >> >> -- >> To unsubscribe from this list: send the line "unsubscribe >> linux-samsung-soc" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel >
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c index 1eb5ffb..fc6a9b0 100644 --- a/drivers/gpu/drm/exynos/exynos_hdmi.c +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c @@ -2081,7 +2081,6 @@ static struct s5p_hdmi_platform_data *drm_hdmi_dt_parse_pdata { struct device_node *np = dev->of_node; struct s5p_hdmi_platform_data *pd; - enum of_gpio_flags flags; u32 value; pd = devm_kzalloc(dev, sizeof(*pd), GFP_KERNEL); @@ -2095,7 +2094,7 @@ static struct s5p_hdmi_platform_data *drm_hdmi_dt_parse_pdata goto err_data; } - pd->hpd_gpio = of_get_named_gpio_flags(np, "hpd-gpio", 0, &flags); + pd->hpd_gpio = of_get_named_gpio(np, "hpd-gpio", 0); return pd;
Cleanup by removing flags variable from drm_hdmi_dt_parse_pdata which is not used anywhere. Swtiching to of_get_named_gpio instead of of_get_named_gpio_flags solved this. Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com> --- drivers/gpu/drm/exynos/exynos_hdmi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)