From patchwork Fri Jun 14 22:13:12 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 2725211 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 0384DC0AB1 for ; Fri, 14 Jun 2013 22:15:19 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3D7DC20303 for ; Fri, 14 Jun 2013 22:15:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 5E284202F9 for ; Fri, 14 Jun 2013 22:15:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6FB09E6109 for ; Fri, 14 Jun 2013 15:15:17 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-ea0-f179.google.com (mail-ea0-f179.google.com [209.85.215.179]) by gabe.freedesktop.org (Postfix) with ESMTP id A2C9FE5C8A for ; Fri, 14 Jun 2013 15:13:26 -0700 (PDT) Received: by mail-ea0-f179.google.com with SMTP id b15so629604eae.24 for ; Fri, 14 Jun 2013 15:13:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=c3vesw2d9u5xcGXrnCQXTQ5TWD6c7eoa2LABSBfScLQ=; b=asoOiyufcdi1cfoNHkBEmd4ogFrraxOIGruyG6Aou8EAfiV8710/NzgYOQt9aUi9xd U1fZhUE2c7fIogtaWS0aGJHj7XRiWZSqGOhpKVCLlo16EhTtd826NKnwLZwn+0rgsk4P 1XR+D9BPtxP7yWmQ9fA6csxoDOvvJmKtDAX1M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=c3vesw2d9u5xcGXrnCQXTQ5TWD6c7eoa2LABSBfScLQ=; b=dDWkneacyHJC9BvadjFVCbrj8eFkSR6B87UzPalro3rHnI0o6O3J3kglpxyt8ruvKF w15uKOtONOJEvYp03fqPX7ec26OUCGENtDPXpwsiqKlkbZf/qJoQ6sNGVUZp+mNkq5Fh E22tCLYKwBkNKL7RtXc0tYAIpOoem0wpx4RGDCz/I1M7XvJn73Hm3RjEYZcg/ehOExmJ xX6AQBm5HXPwAvrLP5jr/OPXnvCgwLiWXBcjguUZ9IGbm66FGpBdQJtvCub78rXvVFT4 sFkvOi7eQH5dKtAsHks/o3HOt95q+NAMO5hBOxI38Rbs9kkeym2qSbBj6A7h3Cb2T4nh HTaw== X-Received: by 10.15.63.204 with SMTP id m52mr5295545eex.59.1371248005637; Fri, 14 Jun 2013 15:13:25 -0700 (PDT) Received: from phenom.ffwll.local (178-83-130-250.dynamic.hispeed.ch. [178.83.130.250]) by mx.google.com with ESMTPSA id m1sm6258301eex.17.2013.06.14.15.13.23 for (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 14 Jun 2013 15:13:24 -0700 (PDT) From: Daniel Vetter To: DRI Development Subject: [PATCH 2/6] drm/crtc-helper: no need to check for fb->depth/bpp Date: Sat, 15 Jun 2013 00:13:12 +0200 Message-Id: <1371247996-6052-3-git-send-email-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1371247996-6052-1-git-send-email-daniel.vetter@ffwll.ch> References: <1371247996-6052-1-git-send-email-daniel.vetter@ffwll.ch> X-Gm-Message-State: ALoCoQkA1T3mf6LZiboj0TwxpVA5OXvnz+ie83ATozVkMyVM2x8s85i9/vtX3P0DigGQTfahL9fS Cc: Daniel Vetter X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP ... since we already check for fb->pixel_format, which encodes all this. The other two fields are only for backwards compat of older drivers (and we might want to look into eventually just killing them). Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_crtc_helper.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c index e57cfec..1ace9c1 100644 --- a/drivers/gpu/drm/drm_crtc_helper.c +++ b/drivers/gpu/drm/drm_crtc_helper.c @@ -645,11 +645,6 @@ int drm_crtc_helper_set_config(struct drm_mode_set *set) mode_changed = true; } else if (set->fb == NULL) { mode_changed = true; - } else if (set->fb->depth != set->crtc->fb->depth) { - mode_changed = true; - } else if (set->fb->bits_per_pixel != - set->crtc->fb->bits_per_pixel) { - mode_changed = true; } else if (set->fb->pixel_format != set->crtc->fb->pixel_format) { mode_changed = true;